public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/64491] [5 Regression] incorrect warning: loop exit may only be reached after undefined behavior
Date: Wed, 18 Feb 2015 13:57:00 -0000	[thread overview]
Message-ID: <bug-64491-4-7qzYYxpMju@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64491-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64491

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ams at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think this is just a bogus warning introduced in r217891, the generated code
looks ok.
Code like:
  <bb 5>:
  # f_27 = PHI <f_23(4), f_17(8)>
  if (f_27 != 0)
    goto <bb 6>;
  else
    goto <bb 7>;

  <bb 6>:
  _11 = f_27 + -1;
  iftmp.0_12 = A[_11];
  if (f_27 != 7)
    goto <bb 7>;
  else
    goto <bb 8>;

  <bb 7>:
  # iftmp.0_28 = PHI <iftmp.0_12(6), 0(5)>
  _13 = f_27 + 1;
  iftmp.1_14 = A[_13];

  <bb 8>:
  # iftmp.1_4 = PHI <iftmp.1_14(7), 0(6)>
  # iftmp.0_29 = PHI <iftmp.0_28(7), iftmp.0_12(6)>
  _15 = iftmp.0_29 | iftmp.1_4;
  B[f_27] = _15;
  f_17 = f_27 + 1;
  if (f_17 == 8)
    goto <bb 9>;
  else
    goto <bb 5>;
is transformed by dom1 into an extra early exit from the loop, if f_27 == 7, we
jump to a new bb outside of the loop that does:
  <bb 11>:
  # iftmp.1_2 = PHI <0(6)>
  # iftmp.0_3 = PHI <iftmp.0_12(6)>
  _1 = iftmp.0_3 | iftmp.1_2;
  B[f_27] = _1;
  f_26 = f_27 + 1;
  goto <bb 10>;
But indeed dom nor anything else doesn't figure out that the f_17 == 8
exit condition of the loop is then never true, the loop will always exit
through the jump to bb 11.
Supposedly the warning needs to be limited to the case where the loop has only
a single exit, or when the undefined behavior occurs on all loop exits.


  parent reply	other threads:[~2015-02-18 13:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-04 20:24 [Bug c++/64491] New: " stuwph at live dot de
2015-01-04 20:46 ` [Bug c++/64491] " redi at gcc dot gnu.org
2015-01-10 15:58 ` joona.kiiski at iki dot fi
2015-01-10 16:04 ` joona.kiiski at iki dot fi
2015-01-10 16:49 ` [Bug c++/64491] [5 Regression] incorrect " Joost.VandeVondele at mat dot ethz.ch
2015-01-11 22:10 ` [Bug middle-end/64491] " joona.kiiski at gmail dot com
2015-01-12  7:18 ` Joost.VandeVondele at mat dot ethz.ch
2015-02-09  0:06 ` pinskia at gcc dot gnu.org
2015-02-18 13:57 ` jakub at gcc dot gnu.org [this message]
2015-02-18 16:25 ` ams at gcc dot gnu.org
2015-02-18 16:28 ` jakub at gcc dot gnu.org
2015-02-20 11:28 ` ams at gcc dot gnu.org
2015-02-24 17:01 ` ams at gcc dot gnu.org
2015-02-24 19:18 ` jakub at gcc dot gnu.org
2015-03-18 12:50 ` rguenth at gcc dot gnu.org
2015-03-18 12:53 ` jakub at gcc dot gnu.org
2015-03-18 14:27 ` ams at gcc dot gnu.org
2015-03-18 14:29 ` ams at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64491-4-7qzYYxpMju@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).