public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "andrey.vihrov at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/64504] Invalid free() with _GLIBCXX_DEBUG and -fwhole-program Date: Sun, 25 Jan 2015 18:35:00 -0000 [thread overview] Message-ID: <bug-64504-4-GTwAXJ2bTO@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-64504-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64504 --- Comment #3 from Andrey Vihrov <andrey.vihrov at gmail dot com> --- I compiled the example program without and with -fwhole-program to assembly code, and here are the differences: http://pastie.org/9859649 As I understand, normally the ".weak" directive ensures that there is only one definition of std::string::_Rep::_S_empty_rep_storage per whole program. But with -fwhole-program the .weak directive disappears, and instead another local definition is created. Looking at libstdc++ source code, I see // The following storage is init'd to 0 by the linker, resulting // (carefully) in an empty string with one reference. static size_type _S_empty_rep_storage[]; . . . // Linker sets _S_empty_rep_storage to all 0s (one reference, empty string) // at static init time (before static ctors are run). template<typename _CharT, typename _Traits, typename _Alloc> typename basic_string<_CharT, _Traits, _Alloc>::size_type basic_string<_CharT, _Traits, _Alloc>::_Rep::_S_empty_rep_storage[ (sizeof(_Rep_base) + sizeof(_CharT) + sizeof(size_type) - 1) / sizeof(size_type)]; I can get kind of the same difference in assembly by compiling this code: template<typename T = void> struct S { static char arr[]; }; template<typename T> char S<T>::arr[3]; int main() { return S<>::arr[1]; } Without -fwhole-program ".weak" and stuff is emitted, with the option the array probably becomes static and so the program is compiled to "return 0". So it looks like the problem here is that with -fwhole-program GCC does not consider the possible existence of the same template instantiation in other translation units.
next prev parent reply other threads:[~2015-01-25 18:35 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-05 19:46 [Bug libstdc++/64504] New: " andrey.vihrov at gmail dot com 2015-01-06 11:18 ` [Bug libstdc++/64504] " redi at gcc dot gnu.org 2015-01-06 14:08 ` andrey.vihrov at gmail dot com 2015-01-25 18:35 ` andrey.vihrov at gmail dot com [this message] 2015-01-26 10:56 ` rguenth at gcc dot gnu.org 2015-01-26 11:06 ` redi at gcc dot gnu.org 2015-06-09 15:12 ` andrey.vihrov at gmail dot com 2015-06-09 16:56 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64504-4-GTwAXJ2bTO@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).