* [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr
[not found] <bug-64557-4@http.gcc.gnu.org/bugzilla/>
@ 2015-01-10 21:47 ` wmi at google dot com
2015-01-10 22:07 ` ppluzhnikov at google dot com
` (4 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: wmi at google dot com @ 2015-01-10 21:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64557
--- Comment #1 from wmi at google dot com ---
The experimental patch is to call get_addr for VALUE of base before plus other
constant, when creating mem_addr for dependence check and for store_info.
bootstrap and regression on x86_64-linux-gnu are ok.
Index: dse.c
===================================================================
--- dse.c (revision 219421)
+++ dse.c (working copy)
@@ -1564,6 +1564,7 @@ record_store (rtx body, bb_info_t bb_inf
= rtx_group_vec[group_id];
mem_addr = group->canon_base_addr;
}
+ mem_addr = get_addr (mem_addr);
if (offset)
mem_addr = plus_constant (get_address_mode (mem), mem_addr, offset);
}
@@ -2177,6 +2178,7 @@ check_mem_read_rtx (rtx *loc, bb_info_t
= rtx_group_vec[group_id];
mem_addr = group->canon_base_addr;
}
+ mem_addr = get_addr (mem_addr);
if (offset)
mem_addr = plus_constant (get_address_mode (mem), mem_addr, offset);
}
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr
[not found] <bug-64557-4@http.gcc.gnu.org/bugzilla/>
2015-01-10 21:47 ` [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr wmi at google dot com
@ 2015-01-10 22:07 ` ppluzhnikov at google dot com
2015-01-23 17:56 ` wmi at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: ppluzhnikov at google dot com @ 2015-01-10 22:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64557
Paul Pluzhnikov <ppluzhnikov at google dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ppluzhnikov at google dot com
--- Comment #2 from Paul Pluzhnikov <ppluzhnikov at google dot com> ---
Google ref: b/18933287
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr
[not found] <bug-64557-4@http.gcc.gnu.org/bugzilla/>
2015-01-10 21:47 ` [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr wmi at google dot com
2015-01-10 22:07 ` ppluzhnikov at google dot com
@ 2015-01-23 17:56 ` wmi at gcc dot gnu.org
2015-02-20 12:05 ` uros at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 6+ messages in thread
From: wmi at gcc dot gnu.org @ 2015-01-23 17:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64557
--- Comment #4 from wmi at gcc dot gnu.org ---
Author: wmi
Date: Fri Jan 23 17:55:32 2015
New Revision: 220051
URL: https://gcc.gnu.org/viewcvs?rev=220051&root=gcc&view=rev
Log:
Backported from trunk.
2015-01-22 Wei Mi <wmi@google.com>
PR rtl-optimization/64557
* dse.c (record_store): Call get_addr for mem_addr.
(check_mem_read_rtx): Likewise.
Modified:
branches/gcc-4_9-branch/gcc/ChangeLog
branches/gcc-4_9-branch/gcc/dse.c
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr
[not found] <bug-64557-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2015-01-23 17:56 ` wmi at gcc dot gnu.org
@ 2015-02-20 12:05 ` uros at gcc dot gnu.org
2015-02-20 12:06 ` ubizjak at gmail dot com
2015-10-15 10:41 ` vogt at linux dot vnet.ibm.com
5 siblings, 0 replies; 6+ messages in thread
From: uros at gcc dot gnu.org @ 2015-02-20 12:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64557
--- Comment #5 from uros at gcc dot gnu.org ---
Author: uros
Date: Fri Feb 20 12:04:21 2015
New Revision: 220854
URL: https://gcc.gnu.org/viewcvs?rev=220854&root=gcc&view=rev
Log:
Backport from mainline
2015-01-22 Wei Mi <wmi@google.com>
PR rtl-optimization/64557
* dse.c (record_store): Call get_addr for mem_addr.
(check_mem_read_rtx): Likewise.
Backport from mainline
2014-10-20 Uros Bizjak <ubizjak@gmail.com>
* varasm.c (const_alias_set): Remove.
(init_varasm_once): Remove initialization of const_alias_set.
(build_constant_desc): Do not set alias set to const_alias_set.
Backport from mainline
2014-10-14 Uros Bizjak <ubizjak@gmail.com>
PR rtl-optimization/63475
* alias.c (true_dependence_1): Always use get_addr to extract
true address operands from x_addr and mem_addr. Use extracted
address operands to check for references with alignment ANDs.
Use extracted address operands with find_base_term and
base_alias_check. For noncanonicalized operands call canon_rtx with
extracted address operand.
(write_dependence_1): Ditto.
(may_alias_p): Ditto. Remove unused calls to canon_rtx.
Backport from mainline
2014-10-10 Uros Bizjak <ubizjak@gmail.com>
PR rtl-optimization/63483
* alias.c (true_dependence_1): Do not exit early for MEM_READONLY_P
references when alignment ANDs are involved.
(write_dependence_p): Ditto.
(may_alias_p): Ditto.
Backport from mainline
2013-03-26 Richard Biener <rguenther@suse.de>
* alias.c (find_base_term): Avoid redundant and not used recursion.
(base_alias_check): Get the initial base term from the caller.
(true_dependence_1): Compute and pass base terms to base_alias_check.
(write_dependence_p): Likewise.
(may_alias_p): Likewise.
Modified:
branches/gcc-4_8-branch/gcc/ChangeLog
branches/gcc-4_8-branch/gcc/alias.c
branches/gcc-4_8-branch/gcc/dse.c
branches/gcc-4_8-branch/gcc/varasm.c
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr
[not found] <bug-64557-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2015-02-20 12:05 ` uros at gcc dot gnu.org
@ 2015-02-20 12:06 ` ubizjak at gmail dot com
2015-10-15 10:41 ` vogt at linux dot vnet.ibm.com
5 siblings, 0 replies; 6+ messages in thread
From: ubizjak at gmail dot com @ 2015-02-20 12:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64557
Uroš Bizjak <ubizjak at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |4.8.5
--- Comment #6 from Uroš Bizjak <ubizjak at gmail dot com> ---
Fixed everywhere.
>From gcc-bugs-return-477928-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Feb 20 12:14:48 2015
Return-Path: <gcc-bugs-return-477928-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 10441 invoked by alias); 20 Feb 2015 12:14:48 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 10340 invoked by uid 48); 20 Feb 2015 12:14:44 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/63892] [5 Regression] gcc.dg/sibcall-3.c fails on darwin with -m32
Date: Fri, 20 Feb 2015 12:14:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: mliska at suse dot cz
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63892-4-nxsrJjOn2f@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63892-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63892-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg02261.txt.bz2
Content-length: 364
https://gcc.gnu.org/bugzilla/show_bug.cgi?idc892
--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Thanks, looks reasonable. That will hopefully render my #c5 patch undeeded.
Can you please bootstrap/regtest it on x86_64-linux (well, I can do that too
now). Don't have access to darwin nor time to test it there, so will leave
that to others.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug rtl-optimization/64557] get_addr in true_dependence_1 cannot handle VALUE inside an expr
[not found] <bug-64557-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2015-02-20 12:06 ` ubizjak at gmail dot com
@ 2015-10-15 10:41 ` vogt at linux dot vnet.ibm.com
5 siblings, 0 replies; 6+ messages in thread
From: vogt at linux dot vnet.ibm.com @ 2015-10-15 10:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64557
Dominik Vogt <vogt at linux dot vnet.ibm.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |vogt at linux dot vnet.ibm.com
--- Comment #7 from Dominik Vogt <vogt at linux dot vnet.ibm.com> ---
This fix causes a regression on s390. Please refer to bug 67443:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67443
^ permalink raw reply [flat|nested] 6+ messages in thread