[Bug go/64573] New: Cmd.Start swallows error from fork()/clone()

[Bug go/64573] New: Cmd.Start swallows error from fork()/clone()

[eswierk at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64573

            Bug ID: 64573
           Summary: Cmd.Start swallows error from fork()/clone()
           Product: gcc
           Version: 4.9.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: eswierk at gmail dot com
                CC: cmang at google dot com

Created attachment 34428
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34428&action=edit
Proposed fix

Cmd.Start ignores the error code from the underlying fork() or clone() syscall,
instead returning a nil error while setting Process.Pid to 0.  If the caller
then tries to Wait on the command, it can end up reaping some other child
process (since waitpid(0) means wait for any child in the process group).

The attached patch should make the behavior identical to that of golang.

[Bug go/64573] Cmd.Start swallows error from fork()/clone()

[eswierk at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64573

Ed Swierk <eswierk at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34428|0                           |1
        is obsolete|                            |

--- Comment #1 from Ed Swierk <eswierk at gmail dot com> ---
Created attachment 34430
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34430&action=edit
Proposed fix (in proper patch format)

[Bug go/64573] Cmd.Start swallows error from fork()/clone()

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64573

--- Comment #2 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Fri Jan 23 23:45:04 2015
New Revision: 220068

URL: https://gcc.gnu.org/viewcvs?rev=220068&root=gcc&view=rev
Log:
    PR go/64573
syscall: Restore line somehow lost in libgo merge.

Modified:
    trunk/libgo/go/syscall/exec_unix.go

[Bug go/64573] Cmd.Start swallows error from fork()/clone()

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64573

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Ian Lance Taylor <ian at airs dot com> ---
Fixed.  Thanks for pointing out the problem.