[Bug ipa/64583] New: [5 Regression] recent inliner changes cause Chromium build failure

[Bug ipa/64583] New: [5 Regression] recent inliner changes cause Chromium build failure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

            Bug ID: 64583
           Summary: [5 Regression] recent inliner changes cause Chromium
                    build failure
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
                CC: hubicka at gcc dot gnu.org

Final chrome link fails due to relocations to discarded comdat sections:

...
obj/third_party/WebKit/Source/web/libblink_web.a(obj/third_party/WebKit/Source/web/blink_web.PopupListBox.o):PopupListBox.cpp:function
blink::PopupListBox::getRowHeight(int) 
const: warning: relocation refers to discarded section
obj/third_party/WebKit/Source/web/libblink_web.a(obj/third_party/WebKit/Source/web/blink_web.PopupListBox.o):PopupListBox.cpp:function
blink::PopupListBox::getRowHeight(int) 
const: warning: relocation refers to discarded section
obj/third_party/WebKit/Source/web/libblink_web.a(obj/third_party/WebKit/Source/web/blink_web.PopupListBox.o):PopupListBox.cpp:function
blink::PopupListBox::paintRow(blink::Gr
aphicsContext*, blink::IntRect const&, int): warning: relocation refers to
discarded section
obj/third_party/WebKit/Source/core/libwebcore_html.a(obj/third_party/WebKit/Source/core/html/canvas/webcore_html.CanvasRenderingContext2D.o):CanvasRenderingContext2D.cpp:func
tion WTF::BoundFunctionImpl<WTF::FunctionWrapper<void
(blink::GraphicsContext::*)(blink::Font const&, blink::TextRunPaintInfo const&,
blink::FloatPoint const&, blink::Font::C
ustomFontNotReadyAction)>, void (blink::GraphicsContext*, blink::Font,
blink::TextRunPaintInfo, blink::FloatPoint,
blink::Font::CustomFontNotReadyAction)>::~BoundFunctionImpl
(): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_html.a(obj/third_party/WebKit/Source/core/html/canvas/webcore_html.CanvasRenderingContext2D.o):CanvasRenderingContext2D.cpp:func
tion WTF::BoundFunctionImpl<WTF::FunctionWrapper<void
(blink::GraphicsContext::*)(blink::Font const&, blink::TextRunPaintInfo const&,
blink::FloatPoint const&, blink::Font::C
ustomFontNotReadyAction)>, void (blink::GraphicsContext*, blink::Font,
blink::TextRunPaintInfo, blink::FloatPoint,
blink::Font::CustomFontNotReadyAction)>::~BoundFunctionImpl
(): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_html.a(obj/third_party/WebKit/Source/core/html/canvas/webcore_html.CanvasRenderingContext2D.o):CanvasRenderingContext2D.cpp:func
tion blink::Font::~Font(): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_html.a(obj/third_party/WebKit/Source/core/html/canvas/webcore_html.CanvasRenderingContext2D.o):CanvasRenderingContext2D.cpp:func
tion blink::CanvasRenderingContext2D::setFont(WTF::String const&): warning:
relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_html.a(obj/third_party/WebKit/Source/core/html/canvas/webcore_html.CanvasRenderingContext2D.o):CanvasRenderingContext2D.cpp:func
tion blink::CanvasRenderingContext2D::setFont(WTF::String const&): warning:
relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setScript(WTF::String const&): warning: relocation refers to
discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setStyle(blink::FontStyle): warning: relocation refers to discarded
section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setVariantLigatures(blink::FontDescription::VariantLigatures const&):
warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setFontSmoothing(blink::FontSmoothingMode): warning: relocation
refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setFamilyDescription(blink::FontDescription::FamilyDescription
const&): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setInitial(float): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::setInitial(float): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::checkForOrientationChange(blink::RenderStyle*): warning: relocation
refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::checkForOrientationChange(blink::RenderStyle*): warning: relocation
refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::checkForGenericFamilyChange(blink::RenderStyle*, blink::RenderStyle
const*): warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_remaining.a(obj/third_party/WebKit/Source/core/css/resolver/webcore_remaining.FontBuilder.o):FontBuilder.cpp:function
blink::Fon
tBuilder::updateComputedSize(blink::RenderStyle*, blink::RenderStyle const*):
warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_rendering.a(obj/third_party/WebKit/Source/core/rendering/style/webcore_rendering.RenderStyle.o):RenderStyle.cpp:function
blink::
RenderStyle::setFontDescription(blink::FontDescription const&): warning:
relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_rendering.a(obj/third_party/WebKit/Source/core/rendering/style/webcore_rendering.RenderStyle.o):RenderStyle.cpp:function
blink::
RenderStyle::setWordSpacing(float): warning: relocation refers to discarded
section
obj/third_party/WebKit/Source/core/libwebcore_rendering.a(obj/third_party/WebKit/Source/core/rendering/style/webcore_rendering.RenderStyle.o):RenderStyle.cpp:function
blink::
RenderStyle::setLetterSpacing(float): warning: relocation refers to discarded
section
obj/third_party/WebKit/Source/core/libwebcore_rendering.a(obj/third_party/WebKit/Source/core/rendering/style/webcore_rendering.RenderStyle.o):RenderStyle.cpp:function
blink::
RenderStyle::setTextAutosizingMultiplier(float): warning: relocation refers to
discarded section
obj/third_party/WebKit/Source/core/libwebcore_generated.a(obj/third_party/WebKit/Source/core/gen/blink/core/webcore_generated.StyleBuilderFunctions.o):StyleBuilderFunctions.c
pp:function
blink::StyleBuilderFunctions::applyInitialCSSPropertyFontFamily(blink::StyleResolverState&):
warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_generated.a(obj/third_party/WebKit/Source/core/gen/blink/core/webcore_generated.StyleBuilderFunctions.o):StyleBuilderFunctions.c
pp:function
blink::StyleBuilderFunctions::applyInheritCSSPropertyFontFamily(blink::StyleResolverState&):
warning: relocation refers to discarded section
obj/third_party/WebKit/Source/core/libwebcore_generated.a(obj/third_party/WebKit/Source/core/gen/blink/core/webcore_generated.StyleBuilderFunctions.o):StyleBuilderFunctions.c
pp:function
blink::StyleBuilderFunctions::applyValueCSSPropertyFontFamily(blink::StyleResolverState&,
blink::CSSValue*): warning: relocation refers to discarded section
/usr/lib/gcc/x86_64-pc-linux-gnu/5.0.0/../../../../x86_64-pc-linux-gnu/bin/ld.gold:
error: treating warnings as errors
collect2: error: ld returned 1 exit status

Haven't looked deeper yet. gcc-4.9 is fine. gcc trunk from 11 January, too.

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

--- Comment #1 from Jan Hubicka <hubicka at ucw dot cz> ---
> Final chrome link fails due to relocations to discarded comdat sections:

Can I have --save-temps *.res file as well as -fdump-ipa-all dumps?
PLease also build with -Wl,--no-demangle so I can look for the symbols.

Honza

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

--- Comment #2 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
-fdump-ipa-all output for
obj/third_party/WebKit/Source/web/blink_web.PopupListBox.o with trunk and gcc
from 2015-01-10.

 % wget trippelsdorf.de/dump-ipa-all.tar.bz2

 % c++filt _ZNK5blink12PopupListBox12getRowHeightEi
blink::PopupListBox::getRowHeight(int) const

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |5.0

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

--- Comment #4 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Created attachment 34445
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34445&action=edit
unreduced testcase

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

--- Comment #3 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
Symbol diff gcc-2015-01-10 vs. trunk:

@@ -26,12 +26,11 @@
                  U _ZN3WTF6String6appendEt
                  U _ZN3WTF6StringC1EPKtj
 0000000000000000 W
_ZN3WTF6VectorINS_6OwnPtrIN5blink20GraphicsContextStateEEELm0ENS_16DefaultAllocatorEE14appendSlowCaseINS_10PassOwnPtrIS3_EEEEvRKT_
-0000000000000000 W
_ZN3WTF6VectorINS_6OwnPtrIN5blink20GraphicsContextStateEEELm0ENS_16DefaultAllocatorEE15reserveCapacityEm
 0000000000000000 W
_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE14appendSlowCaseIS3_EEvRKT_
 0000000000000000 W
_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE14expandCapacityEm
-0000000000000000 W
_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE15reserveCapacityEm
                  U _ZN3WTF8fastFreeEPv
                  U _ZN5blink10FloatPointC1ERKNS_8IntPointE
+0000000000000000 W _ZN5blink10FontFamilyD1Ev
 0000000000000000 W _ZN5blink10FontFamilyD2Ev
 0000000000000000 n _ZN5blink10FontFamilyD5Ev
                  U _ZN5blink11RenderTheme5themeEv

g++ --save-temps -MMD -MF
obj/third_party/WebKit/Source/web/blink_web.PopupListBox.o.d
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DDISABLE_NACL
-DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_NOTIFICATIONS -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1
-DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK
-DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG
-DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0
-DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1
-DENABLE_WEB_AUDIO=1 -DWTF_USE_WEBAUDIO_FFMPEG=1
-DWTF_USE_DEFAULT_RENDER_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0
-DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
'-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_LEGACY_DRAWPICTURECALLBACK -DSK_USE_POSIX_THREADS
-DU_STATIC_IMPLEMENTATION -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen
-I../../third_party/angle/include -I../../third_party/skia/include/utils
-I../../third_party/WebKit/Source -I../.. -I../../skia/config
-I../../third_party/khronos -I../../gpu -I../../third_party/WebKit -Igen/blink
-I../../third_party/libpng -I../../third_party/zlib -I../../third_party/libwebp
-I../../third_party/ots/include -I../../third_party/iccjpeg
-I../../third_party/libjpeg_turbo -I../../third_party/icu/source/i18n
-I../../third_party/qcms/src -I../../third_party/skia/src/core
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../skia/ext -I../../third_party/icu/source/common
-I../../third_party/npapi -I../../third_party/npapi/bindings -I../../v8/include
-fstack-protector --param=ssp-buffer-size=4 -pthread -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wno-unused-local-typedefs -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/freetype2
-I/usr/include/libpng16 -I/usr/include/harfbuzz -m64 -march=x86-64 -O2
-fno-ident -fdata-sections -ffunction-sections -funwind-tables
-Wno-c++0x-compat -fno-exceptions -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare -Wno-c++0x-compat -std=gnu++11
-Wno-narrowing -Wno-literal-suffix -c
../../third_party/WebKit/Source/web/PopupListBox.cpp -o
obj/third_party/WebKit/Source/web/blink_web.PopupListBox.o

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

--- Comment #5 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
For example:

_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE15reserveCapacityEm/24866
(void WTF::Vector<T, inlineCapacity, Allocator>::reserveCapacity(size_t) [with
T = blink::PopupItem*; long unsigned int inlineCapacity = 0ul; Allocator =
WTF::DefaultAllocator; size_t = long unsigned int]) @0x7f549a1f9dc8            
                             Type: function definition analyzed
  Visibility: externally_visible public weak comdat
comdat_group:_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE15reserveCapacityEm
one_only visibility:hidden
  References:                                                                  
                                                                               
                Referring:
  Availability: available
  First run: 0
  Function flags: body

vs.

_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE15reserveCapacityEm/24866
(void WTF::Vector<T, inlineCapacity, Allocator>::reserveCapacity(size_t) [with
T = blink::PopupItem*; long unsigned int inlineCapacity = 0ul; Allocator =
WTF::DefaultAllocator; size_t = long unsigned int]) @0x7f35e46eadc8
  Type: function definition analyzed                                           
                                                                               
                Visibility: public weak comdat
comdat_group:_ZN3WTF6VectorIPN5blink9PopupItemELm0ENS_16DefaultAllocatorEE15reserveCapacityEm
one_only visibility:hidden
  References:
  Referring:
  Function void WTF::Vector<T, inlineCapacity,
Allocator>::reserveCapacity(size_t) [with T = blink::PopupItem*; long unsigned
int inlineCapacity = 0ul; Allocator = WTF::DefaultAllocator; size_t = long
unsigned int]/24866 is inline copy in void WTF::Vector<T, inlineCapacity,
Allocator>::expandCapacity(size_t) [with T = blink::PopupItem*; long unsigned
int inlineCapacity = 0ul; Allocator = WTF::DefaultAllocator; size_t = long
unsigned int]/24594
  Availability: available
  First run: 0
  Function flags: body

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2015-01-15
     Ever confirmed|0                           |1

--- Comment #6 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
In the testcase the symbol in question seems to be optimized out because it is
comdat and unused. That looks valid.  Does possibly fix for PR64612 help here?

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

--- Comment #7 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #6)
> In the testcase the symbol in question seems to be optimized out because it
> is comdat and unused. That looks valid.  Does possibly fix for PR64612 help
> here?

Martin has got a more detailed linker error: http://pastebin.com/wbcKdpVA

So _ZN5blink10FontFamilyD1Ev seems to be the culprit.

Will test the PR64612 patch tomorrow.

[Bug ipa/64583] [5 Regression] recent inliner changes cause Chromium build failure

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64583

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #8 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Martin confirmed the fix for PR64612 solves Chrmium build

*** This bug has been marked as a duplicate of bug 64612 ***