public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" @ 2015-01-15 7:50 chengniansun at gmail dot com 2015-01-16 6:38 ` [Bug c/64610] " chengniansun at gmail dot com ` (5 more replies) 0 siblings, 6 replies; 7+ messages in thread From: chengniansun at gmail dot com @ 2015-01-15 7:50 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 Bug ID: 64610 Summary: No -Wbool-compare warning on "(0 != a) >= 0" Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: chengniansun at gmail dot com There is no warning on the expression "(0 != a) >= 0". I think the cause of this bug is different from the one I reported just now (PR64609). $: cat s.c int a; void fn1() { ((0 != a) >= 0); } $: $: gcc-trunk -Wbool-compare -c s.c $: $: clang-trunk -Wno-unused-value -c s.c s.c:2:24: warning: comparison of constant 0 with boolean expression is always true [-Wtautological-constant-out-of-range-compare] void fn1() { ((0 != a) >= 0); } ~~~~~~~~ ^ ~ 1 warning generated. $: $: ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/64610] No -Wbool-compare warning on "(0 != a) >= 0" 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com @ 2015-01-16 6:38 ` chengniansun at gmail dot com 2015-01-23 5:20 ` mpolacek at gcc dot gnu.org ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: chengniansun at gmail dot com @ 2015-01-16 6:38 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 --- Comment #1 from Chengnian Sun <chengniansun at gmail dot com> --- I have another test case, for which either -Wtype-limits or -Wbool-compare does not warn. $: cat s.c void f(int b) { (b == 1) >= 0UL; } $: $: gcc-trunk -Wtype-limits -Wbool-compare -c s.c $: ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/64610] No -Wbool-compare warning on "(0 != a) >= 0" 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com 2015-01-16 6:38 ` [Bug c/64610] " chengniansun at gmail dot com @ 2015-01-23 5:20 ` mpolacek at gcc dot gnu.org 2015-03-17 6:56 ` mpolacek at gcc dot gnu.org ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: mpolacek at gcc dot gnu.org @ 2015-01-23 5:20 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpolacek at gcc dot gnu.org --- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Thanks for your report. I'll look at enhancing this warning in the GCC 6 stage1. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/64610] No -Wbool-compare warning on "(0 != a) >= 0" 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com 2015-01-16 6:38 ` [Bug c/64610] " chengniansun at gmail dot com 2015-01-23 5:20 ` mpolacek at gcc dot gnu.org @ 2015-03-17 6:56 ` mpolacek at gcc dot gnu.org 2015-04-27 16:49 ` mpolacek at gcc dot gnu.org ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: mpolacek at gcc dot gnu.org @ 2015-03-17 6:56 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2015-03-17 Ever confirmed|0 |1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/64610] No -Wbool-compare warning on "(0 != a) >= 0" 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com ` (2 preceding siblings ...) 2015-03-17 6:56 ` mpolacek at gcc dot gnu.org @ 2015-04-27 16:49 ` mpolacek at gcc dot gnu.org 2015-04-29 18:14 ` mpolacek at gcc dot gnu.org 2015-04-29 18:17 ` mpolacek at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: mpolacek at gcc dot gnu.org @ 2015-04-27 16:49 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|unassigned at gcc dot gnu.org |mpolacek at gcc dot gnu.org Target Milestone|--- |6.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/64610] No -Wbool-compare warning on "(0 != a) >= 0" 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com ` (3 preceding siblings ...) 2015-04-27 16:49 ` mpolacek at gcc dot gnu.org @ 2015-04-29 18:14 ` mpolacek at gcc dot gnu.org 2015-04-29 18:17 ` mpolacek at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: mpolacek at gcc dot gnu.org @ 2015-04-29 18:14 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 --- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Author: mpolacek Date: Wed Apr 29 18:13:44 2015 New Revision: 222587 URL: https://gcc.gnu.org/viewcvs?rev=222587&root=gcc&view=rev Log: PR c/64610 * c-common.c (maybe_warn_bool_compare): Warn when comparing a boolean with 0/1. * c-c++-common/Wbool-compare-1.c (fn1): Remove a few lines. * c-c++-common/Wbool-compare-2.c: New test. Added: trunk/gcc/testsuite/c-c++-common/Wbool-compare-2.c Modified: trunk/gcc/c-family/ChangeLog trunk/gcc/c-family/c-common.c trunk/gcc/testsuite/ChangeLog trunk/gcc/testsuite/c-c++-common/Wbool-compare-1.c ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug c/64610] No -Wbool-compare warning on "(0 != a) >= 0" 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com ` (4 preceding siblings ...) 2015-04-29 18:14 ` mpolacek at gcc dot gnu.org @ 2015-04-29 18:17 ` mpolacek at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: mpolacek at gcc dot gnu.org @ 2015-04-29 18:17 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64610 Marek Polacek <mpolacek at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> --- Should be fixed. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-04-29 18:17 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-01-15 7:50 [Bug c/64610] New: No -Wbool-compare warning on "(0 != a) >= 0" chengniansun at gmail dot com 2015-01-16 6:38 ` [Bug c/64610] " chengniansun at gmail dot com 2015-01-23 5:20 ` mpolacek at gcc dot gnu.org 2015-03-17 6:56 ` mpolacek at gcc dot gnu.org 2015-04-27 16:49 ` mpolacek at gcc dot gnu.org 2015-04-29 18:14 ` mpolacek at gcc dot gnu.org 2015-04-29 18:17 ` mpolacek at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).