* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
@ 2015-01-16 5:25 ` howarth at bromo dot med.uc.edu
2015-01-16 8:38 ` dominiq at lps dot ens.fr
` (11 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: howarth at bromo dot med.uc.edu @ 2015-01-16 5:25 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #1 from howarth at bromo dot med.uc.edu ---
Current gcc trunk on x86_64 Fedora 15 produces...
$ nm e.50.1.o | grep OFF
w __OFFLOAD_TABLE__
for the same testcase.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
2015-01-16 5:25 ` [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin howarth at bromo dot med.uc.edu
@ 2015-01-16 8:38 ` dominiq at lps dot ens.fr
2015-01-16 14:08 ` dominiq at lps dot ens.fr
` (10 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2015-01-16 8:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-01-16
Ever confirmed|0 |1
--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Confirmed.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
2015-01-16 5:25 ` [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin howarth at bromo dot med.uc.edu
2015-01-16 8:38 ` dominiq at lps dot ens.fr
@ 2015-01-16 14:08 ` dominiq at lps dot ens.fr
2015-01-16 15:35 ` howarth at bromo dot med.uc.edu
` (9 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: dominiq at lps dot ens.fr @ 2015-01-16 14:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Any hope to have this fixed rapidly? Thousands of failures make testing a
nightmare.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2015-01-16 14:08 ` dominiq at lps dot ens.fr
@ 2015-01-16 15:35 ` howarth at bromo dot med.uc.edu
2015-01-16 16:05 ` howarth at bromo dot med.uc.edu
` (8 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: howarth at bromo dot med.uc.edu @ 2015-01-16 15:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #5 from howarth at bromo dot med.uc.edu ---
Does this imply that significant chunks of dead code exists in this merge?
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2015-01-16 15:35 ` howarth at bromo dot med.uc.edu
@ 2015-01-16 16:05 ` howarth at bromo dot med.uc.edu
2015-01-16 20:38 ` tschwinge at gcc dot gnu.org
` (7 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: howarth at bromo dot med.uc.edu @ 2015-01-16 16:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #6 from howarth at bromo dot med.uc.edu ---
The code producing this problematic symbol appears to be...
/* Holds a decl for __OFFLOAD_TABLE__. */
static GTY(()) tree offload_symbol_decl;
/* Get the __OFFLOAD_TABLE__ symbol. */
static tree
get_offload_symbol_decl (void)
{
if (!offload_symbol_decl)
{
tree decl = build_decl (UNKNOWN_LOCATION, VAR_DECL,
get_identifier ("__OFFLOAD_TABLE__"),
ptr_type_node);
TREE_ADDRESSABLE (decl) = 1;
TREE_PUBLIC (decl) = 1;
DECL_EXTERNAL (decl) = 1;
DECL_WEAK (decl) = 1;
DECL_ATTRIBUTES (decl)
= tree_cons (get_identifier ("weak"),
NULL_TREE, DECL_ATTRIBUTES (decl));
offload_symbol_decl = decl;
}
return offload_symbol_decl;
}
in mop-low.c but get_offload_symbol_decl() is used to assign offload_table in
expand_omp_target().
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2015-01-16 16:05 ` howarth at bromo dot med.uc.edu
@ 2015-01-16 20:38 ` tschwinge at gcc dot gnu.org
2015-01-18 3:02 ` dje at gcc dot gnu.org
` (6 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-01-16 20:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |tschwinge at gcc dot gnu.org
--- Comment #7 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
<http://news.gmane.org/find-root.php?message_id=%3C87r3uuzcqg.fsf%40kepler.schwinge.homeip.net%3E>.
(In reply to howarth from comment #5)
> Does this imply that significant chunks of dead code exists in this merge?
Where do you get this idea from?
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2015-01-16 20:38 ` tschwinge at gcc dot gnu.org
@ 2015-01-18 3:02 ` dje at gcc dot gnu.org
2015-01-18 3:15 ` dje at gcc dot gnu.org
` (5 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: dje at gcc dot gnu.org @ 2015-01-18 3:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
David Edelsohn <dje at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target|x86_64-apple-darwin14 |x86_64-apple-darwin14,
| |powerpc-ibm-aix*
CC| |dje at gcc dot gnu.org
Host|x86_64-apple-darwin14 |x86_64-apple-darwin14,
| |powerpc-ibm-aix*
Build|x86_64-apple-darwin14 |x86_64-apple-darwin14,
| |powerpc-ibm-aix*
--- Comment #8 from David Edelsohn <dje at gcc dot gnu.org> ---
The same libgomp testsuite failure occur on AIX.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2015-01-18 3:02 ` dje at gcc dot gnu.org
@ 2015-01-18 3:15 ` dje at gcc dot gnu.org
2015-01-18 15:40 ` howarth at bromo dot med.uc.edu
` (4 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: dje at gcc dot gnu.org @ 2015-01-18 3:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #9 from David Edelsohn <dje at gcc dot gnu.org> ---
Locally reverting the creation of offload_table may avoid the reference to the
undefined symbol as a workaround to get sane testsuite results.
tree offload_table = build_zero_cst (ptr_type_node);
The failures on AIX are:
FAIL: libgomp.c/examples-4/e.50.1.c (test for excess errors)
Excess errors:
ld: 0711-317 ERROR: Undefined symbol: __OFFLOAD_TABLE__
ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more information.
WARNING: libgomp.c/examples-4/e.50.1.c compilation failed to produce executable
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (7 preceding siblings ...)
2015-01-18 3:15 ` dje at gcc dot gnu.org
@ 2015-01-18 15:40 ` howarth at bromo dot med.uc.edu
2015-01-18 16:23 ` howarth at bromo dot med.uc.edu
` (3 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: howarth at bromo dot med.uc.edu @ 2015-01-18 15:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #10 from howarth at bromo dot med.uc.edu ---
(In reply to David Edelsohn from comment #9)
> Locally reverting the creation of offload_table may avoid the reference to
> the undefined symbol as a workaround to get sane testsuite results.
>
> tree offload_table = build_zero_cst (ptr_type_node);
>
> The failures on AIX are:
>
> FAIL: libgomp.c/examples-4/e.50.1.c (test for excess errors)
> Excess errors:
> ld: 0711-317 ERROR: Undefined symbol: __OFFLOAD_TABLE__
> ld: 0711-345 Use the -bloadmap or -bnoquiet option to obtain more
> information.
>
> WARNING: libgomp.c/examples-4/e.50.1.c compilation failed to produce
> executable
Did you try the proposed patch to fix this?
https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01479.html
On darwin this resolves the failures when coupled with a fix for PR64635.
https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01509.html
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (8 preceding siblings ...)
2015-01-18 15:40 ` howarth at bromo dot med.uc.edu
@ 2015-01-18 16:23 ` howarth at bromo dot med.uc.edu
2015-01-18 23:08 ` dje at gcc dot gnu.org
` (2 subsequent siblings)
12 siblings, 0 replies; 13+ messages in thread
From: howarth at bromo dot med.uc.edu @ 2015-01-18 16:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #11 from howarth at bromo dot med.uc.edu ---
(In reply to David Edelsohn from comment #9)
Also, could you confirm the exact filename you are getting for the
libgomp-plugin-host_nonshm shared library on AIX (e.g, is the suffix .1.a or
.a.1? I'll update the proposed patch in PR64635 for AIX to add and use a
libgomp/config/aix/plugin-suffix.h.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (9 preceding siblings ...)
2015-01-18 16:23 ` howarth at bromo dot med.uc.edu
@ 2015-01-18 23:08 ` dje at gcc dot gnu.org
2015-01-19 12:10 ` tschwinge at gcc dot gnu.org
2015-02-24 18:41 ` tschwinge at gcc dot gnu.org
12 siblings, 0 replies; 13+ messages in thread
From: dje at gcc dot gnu.org @ 2015-01-18 23:08 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #12 from David Edelsohn <dje at gcc dot gnu.org> ---
libgomp-plugin-host_nonshm.so.1 which is inserted into
libgomp-plugin-host_nonshm.a (Traditional AIX shared library filenames do not
have version numbers.)
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (10 preceding siblings ...)
2015-01-18 23:08 ` dje at gcc dot gnu.org
@ 2015-01-19 12:10 ` tschwinge at gcc dot gnu.org
2015-02-24 18:41 ` tschwinge at gcc dot gnu.org
12 siblings, 0 replies; 13+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-01-19 12:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #13 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Thomas Schwinge from comment #7)
> <http://news.gmane.org/find-root.php?message_id=%3C87r3uuzcqg.fsf%40kepler.
> schwinge.homeip.net%3E>.
Committed in r219836.
^ permalink raw reply [flat|nested] 13+ messages in thread* [Bug libgomp/64625] ___OFFLOAD_TABLE__ symbol not produced on x86_64 darwin
[not found] <bug-64625-4@http.gcc.gnu.org/bugzilla/>
` (11 preceding siblings ...)
2015-01-19 12:10 ` tschwinge at gcc dot gnu.org
@ 2015-02-24 18:41 ` tschwinge at gcc dot gnu.org
12 siblings, 0 replies; 13+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-02-24 18:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64625
--- Comment #14 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Author: tschwinge
Date: Tue Feb 24 17:00:36 2015
New Revision: 220944
URL: https://gcc.gnu.org/viewcvs?rev=220944&root=gcc&view=rev
Log:
[PR libgomp/64625] Remove __OFFLOAD_TABLE__ variable/formal parameter.
Fixup for r219836: adjust builtin function prototypes.
PR libgomp/64625
gcc/
* omp-builtins.def (BUILT_IN_GOACC_DATA_START): Specify as
BT_FN_VOID_INT_SIZE_PTR_PTR_PTR, not
BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR.
(BUILT_IN_GOACC_ENTER_EXIT_DATA, BUILT_IN_GOACC_UPDATE): Specify as
BT_FN_VOID_INT_SIZE_PTR_PTR_PTR_INT_INT_VAR, not
BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR.
(BUILT_IN_GOACC_PARALLEL): Specify as
BT_FN_VOID_INT_OMPFN_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR, not
BT_FN_VOID_INT_OMPFN_PTR_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR.
* builtin-types.def
(BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR)
(BT_FN_VOID_INT_OMPFN_PTR_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR):
Remove function types.
(BT_FN_VOID_INT_SIZE_PTR_PTR_PTR)
(BT_FN_VOID_INT_SIZE_PTR_PTR_PTR_INT_INT_VAR)
(BT_FN_VOID_INT_OMPFN_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR):
New function types.
gcc/ada/
* gcc-interface/utils.c (DEF_FUNCTION_TYPE_VAR_8)
(DEF_FUNCTION_TYPE_VAR_12): Remove macros.
(DEF_FUNCTION_TYPE_VAR_7, DEF_FUNCTION_TYPE_VAR_11): New macros.
gcc/c-family/
* c-common.c (DEF_FUNCTION_TYPE_VAR_8, DEF_FUNCTION_TYPE_VAR_12):
Remove macros.
(DEF_FUNCTION_TYPE_VAR_7, DEF_FUNCTION_TYPE_VAR_11): New macros.
gcc/fortran/
* f95-lang.c (DEF_FUNCTION_TYPE_VAR_8, DEF_FUNCTION_TYPE_VAR_12):
Remove macros.
(DEF_FUNCTION_TYPE_VAR_7, DEF_FUNCTION_TYPE_VAR_11): New macros.
* types.def (BT_FN_VOID_INT_PTR_SIZE_PTR_PTR_PTR_INT_INT_VAR)
(BT_FN_VOID_INT_OMPFN_PTR_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR):
Remove function types.
(BT_FN_VOID_INT_SIZE_PTR_PTR_PTR)
(BT_FN_VOID_INT_SIZE_PTR_PTR_PTR_INT_INT_VAR)
(BT_FN_VOID_INT_OMPFN_SIZE_PTR_PTR_PTR_INT_INT_INT_INT_INT_VAR):
New function types.
gcc/jit/
* jit-builtins.c (DEF_FUNCTION_TYPE_VAR_8)
(DEF_FUNCTION_TYPE_VAR_12): Remove macros.
(DEF_FUNCTION_TYPE_VAR_7, DEF_FUNCTION_TYPE_VAR_11): New macros.
* jit-builtins.h (DEF_FUNCTION_TYPE_VAR_8)
(DEF_FUNCTION_TYPE_VAR_12): Remove macros.
(DEF_FUNCTION_TYPE_VAR_7, DEF_FUNCTION_TYPE_VAR_11): New macros.
gcc/lto/
* lto-lang.c (DEF_FUNCTION_TYPE_VAR_8, DEF_FUNCTION_TYPE_VAR_12):
Remove macros.
(DEF_FUNCTION_TYPE_VAR_7, DEF_FUNCTION_TYPE_VAR_11): New macros.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ada/ChangeLog
trunk/gcc/ada/gcc-interface/utils.c
trunk/gcc/builtin-types.def
trunk/gcc/c-family/ChangeLog
trunk/gcc/c-family/c-common.c
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/f95-lang.c
trunk/gcc/fortran/types.def
trunk/gcc/jit/ChangeLog
trunk/gcc/jit/jit-builtins.c
trunk/gcc/jit/jit-builtins.h
trunk/gcc/lto/ChangeLog
trunk/gcc/lto/lto-lang.c
trunk/gcc/omp-builtins.def
^ permalink raw reply [flat|nested] 13+ messages in thread