[Bug libffi/64645] New: liibffi fails to build on cygwin-32

[Bug libffi/64645] New: liibffi fails to build on cygwin-32

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

            Bug ID: 64645
           Summary: liibffi fails to build on cygwin-32
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libffi
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bernd.edlinger at hotmail dot de

I used r219767:

depbase=`echo src/x86/sysv.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool   --mode=compile /home/ED/gcc-build/./gcc/xgcc
-B/home/ED/gcc-build/./gcc/ -B/home/ED/install/i686-pc-cygwin/bin/
-B/home/ED/install/i686-pc-cygwin/lib/ -isystem
/home/ED/install/i686-pc-cygwin/include -isystem
/home/ED/install/i686-pc-cygwin/sys-include    -DHAVE_CONFIG_H -I.
-I../../../gcc-r219767/libffi  -I. -I../../../gcc-r219767/libffi/include
-Iinclude -I../../../gcc-r219767/libffi/src  -I.
-I../../../gcc-r219767/libffi/include -Iinclude
-I../../../gcc-r219767/libffi/src -g -O2 -MT src/x86/sysv.lo -MD -MP -MF
$depbase.Tpo -c -o src/x86/sysv.lo ../../../gcc-r219767/libffi/src/x86/sysv.S
&&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  /home/ED/gcc-build/./gcc/xgcc -B/home/ED/gcc-build/./gcc/
-B/home/ED/install/i686-pc-cygwin/bin/ -B/home/ED/install/i686-pc-cygwin/lib/
-isystem /home/ED/install/i686-pc-cygwin/include -isystem
/home/ED/install/i686-pc-cygwin/sys-include -DHAVE_CONFIG_H -I.
-I../../../gcc-r219767/libffi -I. -I../../../gcc-r219767/libffi/include
-Iinclude -I../../../gcc-r219767/libffi/src -I.
-I../../../gcc-r219767/libffi/include -Iinclude
-I../../../gcc-r219767/libffi/src -g -O2 -MT src/x86/sysv.lo -MD -MP -MF
src/x86/.deps/sysv.Tpo -c ../../../gcc-r219767/libffi/src/x86/sysv.S 
-DDLL_EXPORT -DPIC -o src/x86/.libs/sysv.o
../../../gcc-r219767/libffi/src/x86/sysv.S: Assembler messages:
../../../gcc-r219767/libffi/src/x86/sysv.S:828: Error: junk at end of line,
first unrecognized character is `,'
Makefile:1177: recipe for target 'src/x86/sysv.lo' failed
make[4]: *** [src/x86/sysv.lo] Error 1
make[4]: Leaving directory '/home/ED/gcc-build/i686-pc-cygwin/libffi'
Makefile:1433: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/home/ED/gcc-build/i686-pc-cygwin/libffi'
Makefile:465: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/home/ED/gcc-build/i686-pc-cygwin/libffi'
Makefile:20613: recipe for target 'all-target-libffi' failed
make[1]: *** [all-target-libffi] Error 2
make[1]: Leaving directory '/home/ED/gcc-build'
Makefile:906: recipe for target 'all' failed
make: *** [all] Error 2

[Bug libffi/64645] liibffi fails to build on cygwin-32

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

--- Comment #1 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
Created attachment 34473
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34473&action=edit
possible fix

BTW: I used binutils-2.25 here.

This patch seems to work, and I can build libjava with it.

Excluding that section from sysv.S should be OK, because
CYGWIN32 and MINGW32 do not have eh frame infos AFAIK.

[Bug libffi/64645] liibffi fails to build on cygwin-32

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

--- Comment #3 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
OK.

AFAIK Cygwin-32 does not support the unwind info at all, right?.

Cygwin-64 does support Windows-SEH style unwind info.

libjava uses a kind of hack to get the stack trace:
see libjava/sysdep/i386/backtrace.h

I've seen java exceptions with call stack using above patch.

[Bug libffi/64645] liibffi fails to build on cygwin-32

[rth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

--- Comment #4 from Richard Henderson <rth at gcc dot gnu.org> ---
(In reply to Bernd Edlinger from comment #3)
> AFAIK Cygwin-32 does not support the unwind info at all, right?.

Wrong.  This should be enough to fix it.

diff --git a/src/x86/sysv.S b/src/x86/sysv.S
index 58432d9..78f245b 100644
--- a/src/x86/sysv.S
+++ b/src/x86/sysv.S
@@ -822,6 +822,8 @@ ENDF(C(__x86.get_pc_thunk.dx))
 #ifdef __APPLE__
 .section __TEXT,__eh_frame,coalesced,no_toc+strip_static_syms+live_support
 EHFrame0:
+#elif defined(X86_WIN32)
+.section .eh_frame,"r"
 #elif defined(HAVE_AS_X86_64_UNWIND_SECTION_TYPE)
 .section .eh_frame,EH_FRAME_FLAGS,@unwind
 #else

[Bug libffi/64645] liibffi fails to build on cygwin-32

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

--- Comment #5 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
(In reply to Richard Henderson from comment #4)
> (In reply to Bernd Edlinger from comment #3)
> > AFAIK Cygwin-32 does not support the unwind info at all, right?.
> 
> Wrong.  This should be enough to fix it.
> 
> diff --git a/src/x86/sysv.S b/src/x86/sysv.S
> index 58432d9..78f245b 100644
> --- a/src/x86/sysv.S
> +++ b/src/x86/sysv.S
> @@ -822,6 +822,8 @@ ENDF(C(__x86.get_pc_thunk.dx))
>  #ifdef __APPLE__
>  .section __TEXT,__eh_frame,coalesced,no_toc+strip_static_syms+live_support
>  EHFrame0:
> +#elif defined(X86_WIN32)
> +.section .eh_frame,"r"
>  #elif defined(HAVE_AS_X86_64_UNWIND_SECTION_TYPE)
>  .section .eh_frame,EH_FRAME_FLAGS,@unwind
>  #else

OK. Patch works.
One question: would --enable-sjlj-exceptions make any difference here?

[Bug libffi/64645] liibffi fails to build on cygwin-32

[rth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Richard Henderson <rth at gcc dot gnu.org> ---
No.  In that case this unwind info would simply be ignored.
Anyway, fixed in r219860.

[Bug libffi/64645] liibffi fails to build on cygwin-32

[bernd.edlinger at hotmail dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64645

--- Comment #7 from Bernd Edlinger <bernd.edlinger at hotmail dot de> ---
(In reply to Richard Henderson from comment #6)
> No.  In that case this unwind info would simply be ignored.
> Anyway, fixed in r219860.

Thanks.