public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64662] New: [SH] QImode/HImode atomics should return sign extended SImode values
Date: Sun, 18 Jan 2015 23:27:00 -0000	[thread overview]
Message-ID: <bug-64662-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64662

            Bug ID: 64662
           Summary: [SH] QImode/HImode atomics should return sign extended
                    SImode values
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: olegendo at gcc dot gnu.org
            Target: sh*-*-*

Currently, QImode/HImode atomic insns return the values as such, although the
memory loads actually do a sign extension.  They should return sign extended
SImode values instead, so that it's easier to eliminate redundant sign/zero
extensions around atomic insns.

Example:

int test4 (volatile char* mem)
{
  return __atomic_fetch_add (mem, 1, __ATOMIC_ACQ_REL);
}

compiled with -O2 -m4 -matomic-model=soft-gusa:

        mov     #1,r3

        mova    1f,r0  ! atomic_fetch_addqi_soft_gusa  [length = 18]
        .align 2
        mov     r15,r1
        mov     #(0f-1f),r15
0:      mov.b   @r4,r2        <<< sign extending load of previous value
        mov     r2,r7
        add     r3,r7
        mov.b   r7,@r4
1:      mov     r1,r15
        rts
        exts.b  r2,r0         <<< redundant sign extension


             reply	other threads:[~2015-01-18 23:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18 23:27 olegendo at gcc dot gnu.org [this message]
2024-04-03  4:52 ` [Bug target/64662] " pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64662-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).