From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-473778-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1129 invoked by alias); 18 Jan 2015 23:27:03 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 1097 invoked by uid 48); 18 Jan 2015 23:26:57 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64662] New: [SH] QImode/HImode atomics should return sign extended SImode values
Date: Sun, 18 Jan 2015 23:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cf_gcctarget
Message-ID: <bug-64662-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg01772.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64662

            Bug ID: 64662
           Summary: [SH] QImode/HImode atomics should return sign extended
                    SImode values
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: olegendo at gcc dot gnu.org
            Target: sh*-*-*

Currently, QImode/HImode atomic insns return the values as such, although the
memory loads actually do a sign extension.  They should return sign extended
SImode values instead, so that it's easier to eliminate redundant sign/zero
extensions around atomic insns.

Example:

int test4 (volatile char* mem)
{
  return __atomic_fetch_add (mem, 1, __ATOMIC_ACQ_REL);
}

compiled with -O2 -m4 -matomic-model=soft-gusa:

        mov     #1,r3

        mova    1f,r0  ! atomic_fetch_addqi_soft_gusa  [length = 18]
        .align 2
        mov     r15,r1
        mov     #(0f-1f),r15
0:      mov.b   @r4,r2        <<< sign extending load of previous value
        mov     r2,r7
        add     r3,r7
        mov.b   r7,@r4
1:      mov     r1,r15
        rts
        exts.b  r2,r0         <<< redundant sign extension