public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/64686] [5 Regression] ICE: in edge_badness, at ipa-inline.c:912 during Firefox LTO build with enabled checking Date: Wed, 04 Feb 2015 22:56:00 -0000 [thread overview] Message-ID: <bug-64686-4-v233n3zgTX@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-64686-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64686 --- Comment #7 from Jan Hubicka <hubicka at gcc dot gnu.org> --- It is an ordering issue. We are adding edges to heap and resolving speculations at once that means that we have temporarily wrong summaries. I am testing the following that should not affect codegen in any important way except for random changes of functions with the same priority. Index: ipa-inline.c =================================================================== --- ipa-inline.c (revision 220417) +++ ipa-inline.c (working copy) @@ -1702,6 +1702,7 @@ inline_small_functions (void) { bool update = false; struct cgraph_edge *next; + bool has_speculative = false; if (dump_file) fprintf (dump_file, "Enqueueing calls in %s/%i.\n", @@ -1719,12 +1720,17 @@ inline_small_functions (void) gcc_assert (!edge->aux); update_edge_key (&edge_heap, edge); } - if (edge->speculative && !speculation_useful_p (edge, edge->aux != NULL)) + if (edge->speculative) + has_speculative = true; + } + if (has_speculative) + for (edge = node->callees; edge; edge = next) + if (edge->speculative && !speculation_useful_p (edge, + edge->aux != NULL)) { edge->resolve_speculation (); update = true; } - } if (update) { struct cgraph_node *where = node->global.inlined_to
next prev parent reply other threads:[~2015-02-04 22:56 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <bug-64686-4@http.gcc.gnu.org/bugzilla/> 2015-01-20 10:17 ` marxin at gcc dot gnu.org 2015-01-20 19:23 ` hubicka at gcc dot gnu.org 2015-01-22 5:09 ` hubicka at gcc dot gnu.org 2015-01-28 12:44 ` dcb314 at hotmail dot com 2015-01-28 12:47 ` dcb314 at hotmail dot com 2015-01-28 12:51 ` trippels at gcc dot gnu.org 2015-01-29 7:42 ` hubicka at gcc dot gnu.org 2015-02-04 22:56 ` hubicka at gcc dot gnu.org [this message] 2015-02-05 0:16 ` hubicka at gcc dot gnu.org 2015-02-05 4:47 ` hubicka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64686-4-v233n3zgTX@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).