public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64703] glibc sysdeps/powerpc/powerpc64/dl-machine.h miscompile
Date: Wed, 21 Jan 2015 09:44:00 -0000	[thread overview]
Message-ID: <bug-64703-4-GQ8NHcoTP4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64703-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64703

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #3)
> The tree level gets this right and on x86_64 RTL expansion looks ok as well.
> Can it be that PPC relies on REG_POINTER stuff and maybe the function
> pointer isn't marked that way?
> 
> That said, looks like a RTL / backend issue to me.

The opd stores were removed by tree dse:
--- pr64703.c.090t.phicprop1    2015-01-21 10:41:50.673199149 +0100
+++ pr64703.c.091t.dse1    2015-01-21 10:41:50.674199132 +0100
@@ -42,12 +42,9 @@ resolve_ifunc (long unsigned int value,
   _10 = func_9->fd_func;
   _11 = sym_map_4(D)->l_addr;
   _12 = _10 + _11;
-  opd.fd_func = _12;
   _14 = func_9->fd_toc;
   _15 = _11 + _14;
-  opd.fd_toc = _15;
   _17 = func_9->fd_aux;
-  opd.fd_aux = _17;
   value_19 = (long unsigned int) &opd;

   <bb 6>:
so I don't see how this would be a RTL or backend problem.  Though, of course
the backend would need to somehow explain to the aliasing machinery that it has
something like function descriptors and what they really mean for function
calls.  Unless we want to disable DSE altogether before any function calls,
eek.


  parent reply	other threads:[~2015-01-21  9:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  2:37 [Bug tree-optimization/64703] New: " amodra at gmail dot com
2015-01-21  2:45 ` [Bug tree-optimization/64703] " pinskia at gcc dot gnu.org
2015-01-21  9:03 ` jakub at gcc dot gnu.org
2015-01-21  9:39 ` [Bug target/64703] " rguenth at gcc dot gnu.org
2015-01-21  9:44 ` jakub at gcc dot gnu.org [this message]
2015-01-21  9:51 ` schwab@linux-m68k.org
2015-01-21 10:55 ` amodra at gmail dot com
2015-01-23  9:36 ` amodra at gmail dot com
2015-02-25  1:06 ` msebor at gcc dot gnu.org
2015-03-18  6:39 ` amodra at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64703-4-GQ8NHcoTP4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).