public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "amodra at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/64703] New: glibc sysdeps/powerpc/powerpc64/dl-machine.h miscompile Date: Wed, 21 Jan 2015 02:37:00 -0000 [thread overview] Message-ID: <bug-64703-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64703 Bug ID: 64703 Summary: glibc sysdeps/powerpc/powerpc64/dl-machine.h miscompile Product: gcc Version: 5.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: amodra at gmail dot com This testcase, extracted from glibc sysdeps/powerpc/powerpc64/dl-machine.h shows gcc optimising away the "opd" initialisation at -O1. ie. it's as if the indirect call doesn't cause gcc to see that "value" is used. Adding the asm cures the problem, as does passing the function pointer to another function rather than calling via function pointer in resolve_ifunc. struct link_map { unsigned long l_addr; int l_relocated; }; typedef struct { unsigned long fd_func; unsigned long fd_toc; unsigned long fd_aux; } Elf64_FuncDesc; extern const struct link_map *dl_rtld_map; extern unsigned long dl_hwcap; unsigned long resolve_ifunc (unsigned long value, const struct link_map *map, const struct link_map *sym_map) { Elf64_FuncDesc opd; if (map != sym_map && sym_map != dl_rtld_map && !sym_map->l_relocated) { Elf64_FuncDesc *func = (Elf64_FuncDesc *) value; opd.fd_func = func->fd_func + sym_map->l_addr; opd.fd_toc = func->fd_toc + sym_map->l_addr; opd.fd_aux = func->fd_aux; value = (unsigned long) &opd; } #if 0 __asm__ ("#%0" : : "r" (value)); #endif return ((unsigned long (*) (unsigned long)) value) (dl_hwcap); }
next reply other threads:[~2015-01-21 2:37 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-21 2:37 amodra at gmail dot com [this message] 2015-01-21 2:45 ` [Bug tree-optimization/64703] " pinskia at gcc dot gnu.org 2015-01-21 9:03 ` jakub at gcc dot gnu.org 2015-01-21 9:39 ` [Bug target/64703] " rguenth at gcc dot gnu.org 2015-01-21 9:44 ` jakub at gcc dot gnu.org 2015-01-21 9:51 ` schwab@linux-m68k.org 2015-01-21 10:55 ` amodra at gmail dot com 2015-01-23 9:36 ` amodra at gmail dot com 2015-02-25 1:06 ` msebor at gcc dot gnu.org 2015-03-18 6:39 ` amodra at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64703-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).