From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-474660-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28754 invoked by alias); 24 Jan 2015 00:57:59 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 28712 invoked by uid 48); 24 Jan 2015 00:57:54 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64760] New: [SH] Avoid multiple #imm,r0 insns with the same #imm value
Date: Sat, 24 Jan 2015 00:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cf_gcctarget
Message-ID: <bug-64760-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg02654.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64760

            Bug ID: 64760
           Summary: [SH] Avoid multiple #imm,r0 insns with the same #imm
                    value
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: olegendo at gcc dot gnu.org
            Target: sh*-*-*

In libstdc++ there is code such as:
        mov     r9,r0
        cmp/eq  #-1,r0
        mov     r1,r0
        movt    r2
        cmp/eq  #-1,r0
        movt    r1
        cmp/eq  r1,r2
        bt      ...

It seems that it's better to avoid #imm,r0 insns such as cmp/eq, and, or, xor,
tst, if the #imm value can be shared among several insns.  The insns don't have
to be same, only the constant value.

The above code could be something like:
        mov     #-1,r0
        cmp/eq  r9,r0
        movt    r2
        cmp/eq  r1,r0
        movt    r1
        cmp/eq  r1,r2

Preferably, this should be done before RA to reduce r0 pressure.  It can be
accomplished by simply loading the constant into a pseudo and replacing the
operands in the insns.

On the other hand, if the other operand (other than #imm) is likely to end up
in r0, the #imm,r0 insn is probably going to be better.

A possible metric for 'likely to be in r0' could be:
- the operand is loaded using a mov.{b|w} @(disp,Rn),R0
- the operand is needed in r0 by some other surrounding insns