[Bug ipa/64801] [5 Regression] kernel build failure due to ICF

["marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64801

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
You are right, the problem is hidden in cooperation between IPA inliner and
ICF.

If I run the test w/o ICF, inliner sets NULL to the fsp_detect FUNCTION_DECL:

#0  0x000000000074541e in symtab_node::unregister (this=0x7ffff6c47620) at
../../gcc/symtab.c:407
#1  0x000000000074b0ef in cgraph_node::remove (this=0x7ffff6c47620) at
../../gcc/cgraph.c:1741
#2  0x0000000000b891b9 in expand_call_inline (id=0x7fffffffd5c0,
stmt=0x7ffff6d54aa0, bb=<optimized out>)
    at ../../gcc/tree-inline.c:4762
#3  gimple_expand_calls_inline (id=0x7fffffffd5c0, bb=<optimized out>) at
../../gcc/tree-inline.c:4787

so that cgraph_node::get(decl) == NULL here:

    if (symtab->state != LTO_STREAMING) 
   │1784        {
B+>│1785          n = cgraph_node::get (decl);
   │1786          if (!n                      
   │1787              || (!n->clones && !n->clone_of && !n->global.inlined_to
   │1788                  && (symtab->global_info_ready      
   │1789                      && (TREE_ASM_WRITTEN (n->decl) 
   │1790                          || DECL_EXTERNAL (n->decl) 
   │1791                          || !n->analyzed            
   │1792                          || (!flag_wpa && n->in_other_partition)))))  
   │1793            release_body ();                         
   │1794        }                                                         

That's the reason why the body is not removed. On the contrary, with ICF,
aforementioned condition is satisfied and fsp_detect's body is removed.
I think the situation after IPA ICF is correct:

fsp_detect/2 (fsp_detect) @0x7ffff6c47620
  Type: function definition analyzed
  Visibility: external public
  References: 
  Referring: 
  Availability: available
  First run: 0
  Function flags: body
  Called by: elantech_detect/1 (1.00 per call) psmouse_extensions/3 (1.00 per
call) 
  Calls: 
elantech_detect/1 (elantech_detect) @0x7ffff6c47498
  Type: function definition analyzed
  Visibility: externally_visible public
  References: 
  Referring: 
  Availability: available
  First run: 0
  Function flags: body icf_merged
  Called by: 
  Calls: fsp_detect/2 (1.00 per call) 

Can you please help me Honza?
Thanks,
Martin
>From gcc-bugs-return-474916-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jan 26 15:51:44 2015
Return-Path: <gcc-bugs-return-474916-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 28568 invoked by alias); 26 Jan 2015 15:51:31 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 28292 invoked by uid 48); 26 Jan 2015 15:51:14 -0000
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/64776] [5 Regression] FAIL: gcc.dg/ipa/pr64307.c (internal compiler error) on x86_64-apple-darwin14
Date: Mon, 26 Jan 2015 15:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: dominiq at lps dot ens.fr
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64776-4-MRPoz2Ff5c@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64776-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64776-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg02910.txt.bz2
Content-length: 245

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd776

--- Comment #8 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Sorry for the duplicate comments 5 and 6. Bugzilla is very slow and I got a
confusing message about gateway timed out.