public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug jit/64810] jit not working on armv7hl ("ld: error: /tmp/libgccjit-ZGemdr/fake.so uses VFP register arguments, /tmp/ccJFCBsE.o does not")
Date: Wed, 28 Jan 2015 22:07:00 -0000	[thread overview]
Message-ID: <bug-64810-4-LIuUWY95NE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64810-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64810

--- Comment #15 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
(In reply to David Malcolm from comment #13)
> Am investigating.

What appears to be happening is the 1st time through arm_option_override,
arm_selected_cpu is NULL, but is set to non-NULL at:
  arm_selected_cpu = arm_selected_arch;
The 2nd time through, arm_selected_cpu hasn't been reset, and so the condition:

  if (arm_selected_arch)
    {
      if (arm_selected_cpu)
    {
      /* Check for conflict between mcpu and march.  */

fires, and this clause fires:

        /* -mcpu wins.  */
        arm_selected_arch = NULL;

so we have a NULL arm_selected_arch and a non-NULL arm_selected_cpu.

Fix appears to be to simply set each of these to NULL at the top of
arm_option_override, to prevent state from previous in-process runs from
affecting things:

--- a/gcc/config/arm/arm.c
+++ b/gcc/config/arm/arm.c
@@ -2627,6 +2627,10 @@ arm_gimplify_va_arg_expr (tree valist, tree type,
gimple_seq *pre_p,
 static void
 arm_option_override (void)
 {
+  arm_selected_arch = NULL;
+  arm_selected_cpu = NULL;
+  arm_selected_tune = NULL;
+  
   if (global_options_set.x_arm_arch_option)
     arm_selected_arch = &all_architectures[arm_arch_option];

With this, and the previous patch, most of the jit testsuite passes.

I still see another failure in:
FAIL: test-expressions.c.exe killed: 12479 exp8 0 0 CHILDKILLED SIGSEGV
{segmentation violation}
which appears to be (yet) another issue.


  parent reply	other threads:[~2015-01-28 22:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-64810-4@http.gcc.gnu.org/bugzilla/>
2015-01-27 12:13 ` ramana at gcc dot gnu.org
2015-01-27 12:27 ` jakub at gcc dot gnu.org
2015-01-27 14:28 ` dmalcolm at gcc dot gnu.org
2015-01-27 15:47 ` ramana.radhakrishnan at arm dot com
2015-01-27 18:48 ` dmalcolm at gcc dot gnu.org
2015-01-27 19:40 ` dmalcolm at gcc dot gnu.org
2015-01-27 20:00 ` dmalcolm at gcc dot gnu.org
2015-01-28  9:36 ` ramana.radhakrishnan at arm dot com
2015-01-28 17:59 ` dmalcolm at gcc dot gnu.org
2015-01-28 18:21 ` dmalcolm at gcc dot gnu.org
2015-01-28 20:59 ` dmalcolm at gcc dot gnu.org
2015-01-28 21:30 ` dmalcolm at gcc dot gnu.org
2015-01-28 21:36 ` dmalcolm at gcc dot gnu.org
2015-01-28 21:41 ` jakub at gcc dot gnu.org
2015-01-28 22:07 ` dmalcolm at gcc dot gnu.org [this message]
2015-01-28 22:10 ` dmalcolm at gcc dot gnu.org
2015-01-29  2:56 ` dmalcolm at gcc dot gnu.org
2015-01-29  9:20 ` ramana.radhakrishnan at arm dot com
2015-01-29 15:56 ` dmalcolm at gcc dot gnu.org
2015-01-30 11:03 ` dmalcolm at gcc dot gnu.org
2015-01-30 18:23 ` dmalcolm at gcc dot gnu.org
2015-02-02 15:21 ` dmalcolm at gcc dot gnu.org
2015-02-02 16:11 ` dmalcolm at gcc dot gnu.org
2015-02-03 17:20 ` dmalcolm at gcc dot gnu.org
2015-03-13  9:09 ` ramana at gcc dot gnu.org
2015-03-13 14:17 ` dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64810-4-LIuUWY95NE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).