[Bug target/64833] [SH]: Error: pcrel too far when compiling imagemagick and graphicsmagick on Debian sh4

["olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64833

--- Comment #14 from Oleg Endo <olegendo at gcc dot gnu.org> ---
(In reply to Kazumoto Kojima from comment #12) 
> diff --git a/config/sh/sh.c b/config/sh/sh.c
> index 0139095..86cbea7 100644
> --- a/config/sh/sh.c
> +++ b/config/sh/sh.c
> @@ -5261,6 +5261,11 @@ find_barrier (int num_mova, rtx_insn *mova, rtx_insn
> *from)
>  	       && GET_CODE (PATTERN (from)) == UNSPEC_VOLATILE
>  	       && XINT (PATTERN (from), 1) == UNSPECV_CONST_END)
>  	return from;
> +      /* get_attr_length might return the length of the original worker
> +	 for casesi_worker_2.  Get uncached length for it.  */
> +      else if (NONJUMP_INSN_P (from)
> +	       && recog_memoized (from) == CODE_FOR_casesi_worker_2)
> +	inc = insn_default_length (from);
>  
>        if (BARRIER_P (from))
>  	{

I was trying to understand what's happening there ... it's a bit confusing.  A
cleaner way would probably be to add a function in final.c to update the cached
length value for the INSN_UID in final.c.  Then, invoke that function for the
insn in fixup_mova when the pattern rtx is changed from casesi_worker_1 to
casesi_worker_2.  However, I guess that all the other insn length dependent
values will have to be re-calculated to get a consistent state.

Wouldn't it be easier/safer to just set the length of casesi_worker_1 to "8"?
>From gcc-bugs-return-490966-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Jun 29 14:56:50 2015
Return-Path: <gcc-bugs-return-490966-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 38327 invoked by alias); 29 Jun 2015 14:56:49 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 38278 invoked by uid 48); 29 Jun 2015 14:56:44 -0000
From: "olegendo at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/66563] [4.9 Regression] ICE (segmentation fault) on sh4-linux-gnu
Date: Mon, 29 Jun 2015 14:56:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 4.9.2
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: olegendo at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution:
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.9.4
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-66563-4-0jdxdZHpoB@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-66563-4@http.gcc.gnu.org/bugzilla/>
References: <bug-66563-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-06/txt/msg03298.txt.bz2
Content-length: 149

https://gcc.gnu.org/bugzilla/show_bug.cgi?idf563

--- Comment #39 from Oleg Endo <olegendo at gcc dot gnu.org> ---
Can we close this PR as fixed?