public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "richard-gccbugzilla at metafoo dot co.uk" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/64843] miscompilation of atomic_fetch_add on atomic pointer type
Date: Thu, 29 Jan 2015 00:05:00 -0000	[thread overview]
Message-ID: <bug-64843-4-zvbPfjWk50@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64843-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64843

--- Comment #5 from Richard Smith <richard-gccbugzilla at metafoo dot co.uk> ---
(In reply to joseph@codesourcery.com from comment #3)
> The first question is whether this code is actually valid.

To my reading, the C11 standard says that these operations must work on all
atomic integer types, must be disallowed on atomic_bool, and it's unspecified
if they work on any other type. However, since GCC allows them for an
atomic-qualified pointer, the other rules in 7.17.7.5 apply.

I'm not at all confident that is the intended reading, though: in the C++
specification, from which the C specification was derived, there are overloads
of atomic_fetch_add for each atomic-integral type, plus overloads for
atomic<T*>, making it mandatory to handle the pointer case. I think this is
merely a bug in C11's spec, and this wording should also allow pointers, but
AFAICS it's not in C11's DR list.


  parent reply	other threads:[~2015-01-29  0:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 19:38 [Bug c/64843] New: " richard-gccbugzilla at metafoo dot co.uk
2015-01-28 20:38 ` [Bug c/64843] " rguenth at gcc dot gnu.org
2015-01-28 21:44 ` richard-gccbugzilla at metafoo dot co.uk
2015-01-28 23:20 ` joseph at codesourcery dot com
2015-01-28 23:24 ` joseph at codesourcery dot com
2015-01-29  0:05 ` richard-gccbugzilla at metafoo dot co.uk [this message]
2015-01-29  1:04 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64843-4-zvbPfjWk50@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).