[Bug preprocessor/64864] New: [5 Regression] preprocessor linemarkers break configure checks

[Bug preprocessor/64864] New: [5 Regression] preprocessor linemarkers break configure checks

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

            Bug ID: 64864
           Summary: [5 Regression] preprocessor linemarkers break
                    configure checks
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: preprocessor
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
                CC: dodji at gcc dot gnu.org

For example (this happens for many projects that check for the boost version):
...
checking for working strtod... yes
checking for gettimeofday... yes
checking for Boost headers version >= 1.36.0... yes
checking for Boost's header version... 
configure: error: invalid value: boost_major_version=

markus@x4 core % cat test.cpp
#include <boost/version.hpp>                                                    
boost-lib-version = BOOST_LIB_VERSION

markus@x4 core % g++ -E test.cpp
# 1 "test.cpp"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 1 "<command-line>" 2
# 1 "test.cpp"
# 1 "/usr/include/boost/version.hpp" 1 3 4
# 2 "test.cpp" 2
boost-lib-version = 
# 2 "test.cpp" 3 4
                   "1_56"

markus@x4 core % /usr/x86_64-pc-linux-gnu/gcc-bin/4.9.2/g++ -E test.cpp
# 1 "test.cpp"
# 1 "<built-in>"
# 1 "<command-line>"
# 1 "/usr/include/stdc-predef.h" 1 3 4
# 1 "<command-line>" 2
# 1 "test.cpp"
# 1 "/usr/include/boost/version.hpp" 1 3 4
# 2 "test.cpp" 2
boost-lib-version = "1_56"

I know that these linemarkers are valid. 
But is it really necessary that they appear in the middle of statements? 

Using -P is a workaround, that apparently nobody uses in configure scripts.

See also PR64604.

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
But they should.
Though, it is true that it affects quite a lot of packages, e.g.
cclive emacs ember gnote ksh libcmis libgpg-error libixion liborcus ncurses
openldap
to name a few.

As before, the change was introduced with PR60723.

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I really think this is porting_to.html material, rather than a bug report.

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The line markers allows the compiler to properly distinguish between what
tokens come from where, e.g. system headers vs. normal headers (should we warn
about issues in there if -Wsystem-headers is not used and it is some warning
not enabled by default in system headers), or e.g. for #pragma GCC diagnostics
tracking.

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mpolacek at gcc dot gnu.org

--- Comment #5 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
More info here https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60723#c13

I'm going to prepare the porting_to bit, then I think we should close this bug.

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[dodji at seketeli dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

--- Comment #6 from dodji at seketeli dot org <dodji at seketeli dot org> ---
"mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> a écrit:

> I'm going to prepare the porting_to bit

Thank you for doing that!

> then I think we should close this bug.

FWIW, I agree.
>From gcc-bugs-return-475496-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Jan 30 09:17:38 2015
Return-Path: <gcc-bugs-return-475496-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 32325 invoked by alias); 30 Jan 2015 09:17:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 32010 invoked by uid 55); 30 Jan 2015 09:17:18 -0000
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/64365] [4.9 Regression] Predictive commoning after loop vectorization produces incorrect code.
Date: Fri, 30 Jan 2015 09:17:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenther at suse dot de
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64365-4-k29kutzvMM@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64365-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64365-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-01/txt/msg03490.txt.bz2
Content-length: 2163

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd365

--- Comment #14 from rguenther at suse dot de <rguenther at suse dot de> ---
On Fri, 30 Jan 2015, brooks at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?idd365
>
> --- Comment #13 from Brooks Moses <brooks at gcc dot gnu.org> ---
> FWIW, if you haven't done the 4.9 backport yet, this is what I ended up with.
> I'm not sure it's optimal, but it seems to work.

Looks optimal to me - so if you bootstrapped and tested this it is ok
to apply to the branch (with the testcase also backported of course).

> Index: gcc/tree-data-ref.c
> ==================================================================> --- gcc/tree-data-ref.c (revision 220259)
> +++ gcc/tree-data-ref.c (working copy)
> @@ -973,6 +973,24 @@
>                                 fold_convert (ssizetype, memoff));
>               memoff = build_int_cst (TREE_TYPE (memoff), 0);
>             }
> +         /* Adjust the offset so it is a multiple of the access type
> +            size and thus we separate bases that can possibly be used
> +            to produce partial overlaps (which the access_fn machinery
> +            cannot handle).  */
> +         double_int rem;
> +         if (TYPE_SIZE_UNIT (TREE_TYPE (ref))
> +             && TREE_CODE (TYPE_SIZE_UNIT (TREE_TYPE (ref))) == INTEGER_CST
> +             && !integer_zerop (TYPE_SIZE_UNIT (TREE_TYPE (ref))))
> +           rem = tree_to_double_int (off).mod
> +                (tree_to_double_int (TYPE_SIZE_UNIT (TREE_TYPE (ref))), false,
> +                 TRUNC_MOD_EXPR);
> +         else
> +           /* If we can't compute the remainder simply force the initial
> +              condition to zero.  */
> +           rem = tree_to_double_int (off);
> +         off = double_int_to_tree (ssizetype, tree_to_double_int (off) - rem);
> +         memoff = double_int_to_tree (TREE_TYPE (memoff), rem);
> +         /* And finally replace the initial condition.  */
>           access_fn = chrec_replace_initial_condition
>               (access_fn, fold_convert (orig_type, off));
>           /* ???  This is still not a suitable base object for
>
>

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

--- Comment #7 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
The list of broken packages goes on and on.
xorg-server-1.17:

sdksyms.c:313:15: error: expected expression before ‘,’ token
     (void *) &,                                                  /*
/var/tmp/portage/x11-base/xorg-server-1.17.0/work/xorg-server-1.17.0/include/os.h:92
*/
               ^
Makefile:801: recipe for target 'sdksyms.o' failed

From sdksyms.sh: 
...
topdir=$1                                                                       
shift                                                                           
LC_ALL=C                                                                        
export LC_ALL                                                                   
${CPP:-cpp} "$@" sdksyms.c > /dev/null || exit $?                               
${CPP:-cpp} "$@" sdksyms.c | ${AWK:-awk} -v topdir=$topdir '                    
BEGIN {    
...
>From gcc-bugs-return-476383-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Sun Feb 08 20:43:55 2015
Return-Path: <gcc-bugs-return-476383-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 14819 invoked by alias); 8 Feb 2015 20:43:55 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 14790 invoked by uid 48); 8 Feb 2015 20:43:51 -0000
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/64975] [AArch64] Thunderx should not default to crypto enabled
Date: Sun, 08 Feb 2015 20:43:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pinskia at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-64975-4-KDcFjKEJTV@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64975-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64975-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg00716.txt.bz2
Content-length: 477

https://gcc.gnu.org/bugzilla/show_bug.cgi?idd975

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2015-02-08
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug preprocessor/64864] [5 Regression] preprocessor linemarkers break configure checks

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64864

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #8 from Markus Trippelsdorf <trippels at gcc dot gnu.org> ---
porting_to was updated. Closing.