[Bug ipa/64872] New: [5 Regression] ICE: Segmentation fault during Chromium PGO build

[Bug ipa/64872] New: [5 Regression] ICE: Segmentation fault during Chromium PGO build

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

            Bug ID: 64872
           Summary: [5 Regression] ICE: Segmentation fault during Chromium
                    PGO build
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: trippels at gcc dot gnu.org
                CC: marxin at gcc dot gnu.org

Created attachment 34625
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34625&action=edit
testcase

Chromium build fails during -fprofile-use phase:

markus@x4 /tmp % g++ -c -O2 -fprofile-use -fprofile-correction -fno-exceptions
-fno-rtti -std=gnu++11 pickle.ii
../../base/pickle.cc:372:1: internal compiler error: Segmentation fault
0xc9823f crash_signal
        ../../gcc/gcc/toplev.c:381
0xa1811a aggregate_value_p(tree_node const*, tree_node const*)
        ../../gcc/gcc/function.c:2037
0xa1ec4e allocate_struct_function(tree_node*, bool)
        ../../gcc/gcc/function.c:4788
0x903823 cgraph_node::create_wrapper(cgraph_node*)
        ../../gcc/gcc/cgraphunit.c:2407
0x129f8cb ipa_icf::sem_function::merge(ipa_icf::sem_item*)
        ../../gcc/gcc/ipa-icf.c:766
0x12a4ca1 ipa_icf::sem_item_optimizer::merge_classes(unsigned int)
        ../../gcc/gcc/ipa-icf.c:2383
0x12a9a7c ipa_icf::sem_item_optimizer::execute()
        ../../gcc/gcc/ipa-icf.c:1734
0x12aa311 ipa_icf_driver
        ../../gcc/gcc/ipa-icf.c:2461
0x12aa311 ipa_icf::pass_ipa_icf::execute(function*)
        ../../gcc/gcc/ipa-icf.c:2509
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

As expected -fno-ipa-icf "fixes" the issue.

[Bug ipa/64872] [5 Regression] ICE: Segmentation fault during Chromium PGO build

[trippels at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

Markus Trippelsdorf <trippels at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hubicka at gcc dot gnu.org
   Target Milestone|---                         |5.0

[Bug ipa/64872] [5 Regression] ICE: Segmentation fault during Chromium PGO build

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug ipa/64872] [5 Regression] ICE: Segmentation fault during Chromium PGO build

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-01-30
     Ever confirmed|0                           |1

--- Comment #1 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
This also happens during firefox non-PGO build.

[Bug ipa/64872] [5 Regression] ICE: Segmentation fault during Chromium PGO build

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

--- Comment #2 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Created attachment 34630
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34630&action=edit
Patch I am testing

The problem is that ICF merge profiles and profile merging sometimes nukes the
function body making it impossible to produce thunk later.

[Bug ipa/64872] [5 Regression] ICE: Segmentation fault during Chromium PGO build

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Sun Feb  1 18:46:14 2015
New Revision: 220329

URL: https://gcc.gnu.org/viewcvs?rev=220329&root=gcc&view=rev
Log:

    PR ipa/64872
    * ipa-utils.c (ipa_merge_profiles): Add release argument.
    * ipa-icf.c (sem_function::merge): Do not release body when merging.
    * ipa-utils.h (ipa_merge_profiles): Update prototype.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-icf.c
    trunk/gcc/ipa-utils.c
    trunk/gcc/ipa-utils.h

[Bug ipa/64872] [5 Regression] ICE: Segmentation fault during Chromium PGO build

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64872

Jan Hubicka <hubicka at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Fixed.