public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/64883] FAIL: 17_intro/headers/c++*/all_attributes.cc (test for excess errors) on x86_64-apple-darwin14
Date: Sat, 31 Jan 2015 21:31:00 -0000	[thread overview]
Message-ID: <bug-64883-4-eEdZQokinL@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-64883-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64883

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #6)
> Perhaps unconditionally or conditionally for Darwin only include some C
> header or headers before defining those macros, then include the STL headers?

Yes, something like this:

--- a/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
@@ -18,6 +18,19 @@
 // { dg-options "-std=gnu++98" }
 // { dg-do compile }

+#ifdef __APPLE__
+// darwin headers use noreturn and deprecated, PR 64883
+#include <assert.h>
+#include <math.h>
+#include <setjmp.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <unistd.h>
+#endif
+
+// gthr-single.h uses unused, PR 64885
+#include <bits/gthr.h>
+
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' because it is reserved anyway.
 #define abi_tag 1


But it's a bit fragile, as the list of C headers might vary between darwin
versions. This would be more reliable, and we still test that libstdc++ doesn't
use those names on all other targets:

--- a/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
@@ -18,12 +18,18 @@
 // { dg-options "-std=gnu++98" }
 // { dg-do compile }

+// gthr-single.h uses unused, see PR 64885
+#include <bits/gthr.h>
+
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' because it is reserved anyway.
 #define abi_tag 1
 #define always_inline 1
-#define deprecated 1
-#define noreturn 1
+#ifndef __APPLE__
+// darwin headers use these, see PR 64883
+# define deprecated 1
+# define noreturn 1
+#endif
 #define packed 1
 #define pure 1
 #define unused 1


  parent reply	other threads:[~2015-01-31 21:31 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-64883-4@http.gcc.gnu.org/bugzilla/>
2015-01-31 13:26 ` dominiq at lps dot ens.fr
2015-01-31 13:27 ` dominiq at lps dot ens.fr
2015-01-31 15:50 ` dominiq at lps dot ens.fr
2015-01-31 16:03 ` redi at gcc dot gnu.org
2015-01-31 16:16 ` iains at gcc dot gnu.org
2015-01-31 19:28 ` redi at gcc dot gnu.org
2015-01-31 19:37 ` jakub at gcc dot gnu.org
2015-01-31 20:42 ` iains at gcc dot gnu.org
2015-01-31 21:01 ` howarth at bromo dot med.uc.edu
2015-01-31 21:07 ` redi at gcc dot gnu.org
2015-01-31 21:31 ` redi at gcc dot gnu.org [this message]
2015-01-31 22:28 ` howarth at bromo dot med.uc.edu
2015-02-01  2:07 ` howarth at bromo dot med.uc.edu
2015-02-01 12:34 ` iains at gcc dot gnu.org
2015-02-01 12:36 ` iains at gcc dot gnu.org
2015-02-01 14:09 ` iains at gcc dot gnu.org
2015-02-01 14:50 ` iains at gcc dot gnu.org
2015-02-01 15:11 ` redi at gcc dot gnu.org
2015-02-01 15:15 ` redi at gcc dot gnu.org
2015-02-01 17:53 ` iains at gcc dot gnu.org
2015-02-01 18:11 ` iains at gcc dot gnu.org
2015-02-02 11:10 ` dominiq at lps dot ens.fr
2015-02-02 11:12 ` iains at gcc dot gnu.org
2015-02-02 16:57 ` dominiq at lps dot ens.fr
2015-02-03  2:36 ` howarth at bromo dot med.uc.edu
2015-02-16 15:03 ` howarth at bromo dot med.uc.edu
2015-02-16 15:13 ` iains at gcc dot gnu.org
2015-02-16 16:00 ` howarth at bromo dot med.uc.edu
2015-02-16 16:15 ` dominiq at lps dot ens.fr
2015-03-06 12:51 ` dominiq at lps dot ens.fr
2015-03-06 13:24 ` redi at gcc dot gnu.org
2015-03-06 14:04 ` [Bug libstdc++/64883] FAIL: 17_intro/headers/c++*/all_attributes.cc (test for excess errors) on x86_64-apple-darwin10 dominiq at lps dot ens.fr
2015-03-06 16:47 ` iains at gcc dot gnu.org
2015-03-06 17:04 ` redi at gcc dot gnu.org
2015-09-11 11:07 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-64883-4-eEdZQokinL@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).