[Bug testsuite/64885] New: libstdc++ all_attributes failure

[Bug testsuite/64885] New: libstdc++ all_attributes failure

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

            Bug ID: 64885
           Summary: libstdc++ all_attributes failure
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dje at gcc dot gnu.org

The new all_attributes.cc libstdc++ testcases produce numerous excess errors on
AIX

/nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc:29:16:
error: expected ')' before numeric constant
/nasfarm/edelsohn/src/src/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc:29:16:
error: expected ')' before numeric constant
/tmp/20150130/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/powerpc-ibm-aix7.1.0.0/bits/gthr-single.h:222:1:
error: expected ',' or '...' before 'static'
/tmp/20150130/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/powerpc-ibm-aix7.1.0.0/bits/gthr.h:151:27:
error: expected ')' before end of line
/tmp/20150130/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/powerpc-ibm-aix7.1.0.0/bits/gthr.h:151:27:
error: expected initializer before end of line
/tmp/20150130/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/powerpc-ibm-aix7.1.0.0/bits/gthr.h:151:27:
error: expected declaration before end of line

[Bug testsuite/64885] libstdc++ all_attributes failure

[dje at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

David Edelsohn <dje at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |powerpc-ibm-aix
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-01-31
                 CC|                            |redi at gcc dot gnu.org
   Target Milestone|---                         |5.0
     Ever confirmed|0                           |1

--- Comment #2 from David Edelsohn <dje at gcc dot gnu.org> ---
Confirmed.

[Bug testsuite/64885] libstdc++ all_attributes failure

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

--- Comment #3 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Related to (duplicate of) pr64883.

[Bug testsuite/64885] libstdc++ all_attributes failure

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
That's a bug in gthr-single.h

--- a/libgcc/gthr-single.h
+++ b/libgcc/gthr-single.h
@@ -38,7 +38,7 @@ typedef int __gthread_recursive_mutex_t;
 #define __GTHREAD_MUTEX_INIT_FUNCTION(mx)
 #define __GTHREAD_RECURSIVE_MUTEX_INIT 0

-#define UNUSED __attribute__((unused))
+#define UNUSED __attribute__((__unused__))

 #ifdef _LIBOBJC

[Bug testsuite/64885] libstdc++ all_attributes failure

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org

[Bug testsuite/64885] libstdc++ all_attributes failure

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Simply including <bits/gthr.h> first (as suggested in PR 64883 comment 10)
causes a different error, because the gthr headers don't have #pragma GCC
system_header and so the way <ext/rope> uses __GTHREAD_MUTEX_INIT causes a
warning if that macro is first defined outside a system header.

I think the right fix is to replace ((unused)) with ((__unused__)) in
gthr-single.h

There are other gthreads headers with the same problem:

../libgcc/config/gthr-vxworks.h:#define UNUSED(x) x __attribute__((unused))
../libgcc/config/i386/gthr-win32.h:                   void (*__dtor) (void *)
__attribute__((unused)))

[Bug libgcc/64885] libstdc++ all_attributes failure

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Note the UNUSED macro (whether function-like or not) certainly doesn't belong
to headers included from STL headers either.
It should have been __gthr_unused or something similar.

[Bug libgcc/64885] libstdc++ all_attributes failure

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Ditto the header guards like
GCC_GTHR_POSIX_H
GCC_GTHR_SINGLE_H
GCC_GTHR_H
and macros like
GTHREAD_USE_WEAK
HIDE_EXPORTS

[Bug libgcc/64885] libstdc++ all_attributes failure

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yeah, they're a mess.

[Bug libgcc/64885] libstdc++ all_attributes failure

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Author: redi
Date: Mon Mar  2 18:02:18 2015
New Revision: 221120

URL: https://gcc.gnu.org/viewcvs?rev=221120&root=gcc&view=rev
Log:
    PR libgcc/64885
    * gthr-single.h: Use __unused__ attribute instead of unused.
    * config/gthr-vxworks.h: Likewise.
    * config/i386/gthr-win32.h: Likewise.

Modified:
    trunk/libgcc/ChangeLog
    trunk/libgcc/config/gthr-vxworks.h
    trunk/libgcc/config/i386/gthr-win32.h
    trunk/libgcc/gthr-single.h

[Bug libgcc/64885] libstdc++ all_attributes failure

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64885

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The FAIL should be fixed, I've created Bug 65281 for the other problems with
non-reserved macros in the gthr headers.