[Bug c++/64901] New: Overriding final function defined out of line does not lead to an error

[Bug c++/64901] New: Overriding final function defined out of line does not lead to an error

[kaballo86 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64901

            Bug ID: 64901
           Summary: Overriding final function defined out of line does not
                    lead to an error
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: kaballo86 at hotmail dot com

It was reported by talin over at ##C++ that the following snippet does not
result in a compilation error as expected:

    struct Plant {
      virtual void speak() final;
    };

    void Plant::speak(){}

    struct Flower :  Plant {
      void speak(){}
    };

    int main() {}

The issue can be reproduced with gcc-4.9.0 and upwards, and it only happens
when `Plant::speak` is defined out-of-line.

[Bug c++/64901] C++11 regression, overriding final function defined out of line does not lead to an error

[ville.voutilainen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64901

Ville Voutilainen <ville.voutilainen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |4.8.2
           Keywords|                            |accepts-invalid
   Last reconfirmed|                            |2015-02-02
                 CC|                            |ville.voutilainen at gmail dot com
     Ever confirmed|0                           |1
            Summary|Overriding final function   |C++11 regression,
                   |defined out of line does    |overriding final function
                   |not lead to an error        |defined out of line does
                   |                            |not lead to an error
      Known to fail|                            |4.9.1, 5.0

[Bug c++/64901] [4.9/5 Regression] overriding final function defined out of line does not lead to an error

[ville.voutilainen at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64901

Ville Voutilainen <ville.voutilainen at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ville.voutilainen at gmail dot com

--- Comment #1 from Ville Voutilainen <ville.voutilainen at gmail dot com> ---
Mine.

[Bug c++/64901] [4.9/5 Regression] overriding final function defined out of line does not lead to an error

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64901

--- Comment #2 from Jason Merrill <jason at gcc dot gnu.org> ---
Author: jason
Date: Tue Feb  3 02:49:42 2015
New Revision: 220363

URL: https://gcc.gnu.org/viewcvs?rev=220363&root=gcc&view=rev
Log:
    PR c++/64901
    * decl.c (duplicate_decls): Also duplicate DECL_FINAL_P and
    DECL_OVERRIDE_P.

Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c
    trunk/gcc/testsuite/g++.dg/cpp0x/override1.C

[Bug c++/64901] [4.9/5 Regression] overriding final function defined out of line does not lead to an error

[paolo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64901

--- Comment #3 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> ---
Author: paolo
Date: Wed Feb  4 15:38:50 2015
New Revision: 220409

URL: https://gcc.gnu.org/viewcvs?rev=220409&root=gcc&view=rev
Log:
2015-02-04  Ville Voutilainen  <ville.voutilainen@gmail.com>

    PR c++/64901
    * decl.c (duplicate_decls): Also duplicate DECL_FINAL_P and
    DECL_OVERRIDE_P.

Modified:
    branches/gcc-4_9-branch/gcc/cp/ChangeLog
    branches/gcc-4_9-branch/gcc/cp/decl.c
    branches/gcc-4_9-branch/gcc/testsuite/g++.dg/cpp0x/override1.C

[Bug c++/64901] [4.9/5 Regression] overriding final function defined out of line does not lead to an error

[paolo.carlini at oracle dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64901

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.3

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed for 4.9.3.