public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/64921] [4.9/5/6 Regression] FAIL: gfortran.dg/class_allocate_18.f90 Date: Tue, 28 Jul 2015 12:31:00 -0000 [thread overview] Message-ID: <bug-64921-4-eOENzIvrO9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-64921-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64921 --- Comment #23 from rguenther at suse dot de <rguenther at suse dot de> --- On Tue, 28 Jul 2015, mikael at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64921 > > --- Comment #22 from Mikael Morin <mikael at gcc dot gnu.org> --- > (In reply to rguenther@suse.de from comment #21) > > Transfer.4 _is_ null in the case we segfault. So the guard us clearly wrong. > > > OK, let's try something else. > Are you positive transfer.4 is null? > I don't see anything that would make it so. >From inspecting registers and the assembly. The debugger cannot get at the artificial decls. > If it is transfer.10 that is null, I can see the call to __final_main_T2 that > is suspicious; it seems to pass a descriptorless array to an argument expecting > a descriptor. > > Draft patch, seems to fix it > > diff --git a/gcc/fortran/class.c b/gcc/fortran/class.c > index 218973d..7a9e275 100644 > --- a/gcc/fortran/class.c > +++ b/gcc/fortran/class.c > @@ -1599,6 +1599,7 @@ generate_finalization_wrapper (gfc_symbol *derived, > gfc_namespace *ns, > final->ts.type = BT_INTEGER; > final->ts.kind = 4; > final->attr.artificial = 1; > + final->attr.always_explicit = 1; > final->attr.if_source = expr_null_wrapper ? IFSRC_IFBODY : IFSRC_DECL; > if (ns->proc_name->attr.flavor == FL_MODULE) > final->module = ns->proc_name->name; even better
next prev parent reply other threads:[~2015-07-28 12:31 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-02-03 15:42 [Bug rtl-optimization/64921] New: [5 Regression] FAIL: gfortran.dg/class_allocate_18.f90 with -fPIC hjl.tools at gmail dot com 2015-02-03 16:03 ` [Bug rtl-optimization/64921] " jakub at gcc dot gnu.org 2015-02-03 17:22 ` hjl.tools at gmail dot com 2015-02-03 17:32 ` [Bug rtl-optimization/64921] [4.9/5 Regression] FAIL: gfortran.dg/class_allocate_18.f90 hjl.tools at gmail dot com 2015-02-03 21:30 ` pault at gcc dot gnu.org 2015-02-04 3:00 ` ramana at gcc dot gnu.org 2015-02-04 18:21 ` pault at gcc dot gnu.org 2015-02-04 18:31 ` hjl.tools at gmail dot com 2015-02-04 19:00 ` dominiq at lps dot ens.fr 2015-02-04 19:03 ` dominiq at lps dot ens.fr 2015-02-09 0:07 ` pinskia at gcc dot gnu.org 2015-02-09 10:00 ` rguenth at gcc dot gnu.org 2015-02-09 14:26 ` rguenth at gcc dot gnu.org 2015-02-16 13:40 ` dominiq at lps dot ens.fr 2015-02-16 13:48 ` [Bug fortran/64921] " dominiq at lps dot ens.fr 2015-04-27 12:26 ` [Bug fortran/64921] [4.9/5/6 " mathewc at nag dot co.uk 2015-06-26 20:04 ` jakub at gcc dot gnu.org 2015-06-26 20:34 ` jakub at gcc dot gnu.org 2015-07-07 15:29 ` ktkachov at gcc dot gnu.org 2015-07-25 13:31 ` ubizjak at gmail dot com 2015-07-25 15:13 ` ubizjak at gmail dot com 2015-07-27 7:57 ` rguenth at gcc dot gnu.org 2015-07-27 18:45 ` mikael at gcc dot gnu.org 2015-07-27 19:44 ` rguenther at suse dot de 2015-07-28 12:07 ` mikael at gcc dot gnu.org 2015-07-28 12:31 ` rguenther at suse dot de [this message] 2015-07-28 12:43 ` ubizjak at gmail dot com 2015-08-05 15:42 ` mikael at gcc dot gnu.org 2015-08-05 16:42 ` mikael at gcc dot gnu.org 2015-08-05 17:04 ` mikael at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-64921-4-eOENzIvrO9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).