From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-478553-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 99180 invoked by alias); 26 Feb 2015 08:39:29 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 99097 invoked by uid 55); 26 Feb 2015 08:39:24 -0000
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/64946] [AArch64] gcc.target/aarch64/vect-abs-compile.c - "abs" vectorization fails for char/short types
Date: Thu, 26 Feb 2015 09:56:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenther at suse dot de
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: vekumar at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-64946-4-mr1y14k0rz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-64946-4@http.gcc.gnu.org/bugzilla/>
References: <bug-64946-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg02885.txt.bz2

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64946

--- Comment #7 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 26 Feb 2015, vekumar at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64946
> 
> vekumar at gcc dot gnu.org changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |rguenth at gcc dot gnu.org
> 
> --- Comment #3 from vekumar at gcc dot gnu.org ---
> Richard, 
> 
> As per your suggestion, adding a pattern for type demotion in match.pd solves
> this.
> 
> (simplify
>  ( convert (abs (convert@1 @0)))
>  ( if (INTEGRAL_TYPE_P (type)
>       /* We check for type compatibility between @0 and @1 below,
>          so there's no need to check that @1/@3 are integral types.  */
>       && INTEGRAL_TYPE_P (TREE_TYPE (@0))
>       && INTEGRAL_TYPE_P (TREE_TYPE (@1))
>       /* The precision of the type of each operand must match the
>          precision of the mode of each operand, similarly for the
>          result.  */
>       && (TYPE_PRECISION (TREE_TYPE (@0))
>           == GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (@0))))
>       && (TYPE_PRECISION (TREE_TYPE (@1))
>           == GET_MODE_PRECISION (TYPE_MODE (TREE_TYPE (@1))))
>       && TYPE_PRECISION (type) == GET_MODE_PRECISION (TYPE_MODE (type))
>       /* The inner conversion must be a widening conversion.  */
>       && TYPE_PRECISION (TREE_TYPE (@1)) > TYPE_PRECISION (TREE_TYPE (@0))
>       && ((GENERIC
>            && (TYPE_MAIN_VARIANT (TREE_TYPE (@0))
>                == TYPE_MAIN_VARIANT (type)))
>           || (GIMPLE
>               && types_compatible_p (TREE_TYPE (@0), type))))
>    (abs @0)))
> 
> 
> I have not yet tested it. Will it have implication on targets that does not
> support vectorization with short/char types?

I don't see how it could.