From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29433 invoked by alias); 24 Mar 2015 19:49:17 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 29373 invoked by uid 48); 24 Mar 2015 19:49:13 -0000 From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libgomp/64972] [5 Regression] Build failure in libgomp for i686-w64-mingw32 target after latest merge from gomp-4_0-branch Date: Tue, 24 Mar 2015 20:18:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libgomp X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: openacc X-Bugzilla-Severity: critical X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg02648.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D64972 --- Comment #14 from Jakub Jelinek --- (In reply to Kai Tietz from comment #13) > Rainer: does following patch works for you? >=20 > Index: oacc-parallel.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- oacc-parallel.c (Revision 221640) > +++ oacc-parallel.c (Arbeitskopie) > @@ -31,6 +31,9 @@ > #include "libgomp_g.h" > #include "gomp-constants.h" > #include "oacc-int.h" > +#ifdef HAVE_INTTYPES_H > +# include /* For PRIu64. */ > +#endif > #include > #include > #include > @@ -99,9 +102,14 @@ GOACC_parallel (int device, void (*fn) (void *), > gomp_fatal ("num_workers (%d) different from one is not yet supporte= d", > num_workers); >=20=20 > +#ifdef HAVE_INTTYPES_H > + gomp_debug (0, "%s: mapnum=3D%"PRIu64", hostaddrs=3D%p, size=3D%p, kin= ds=3D%p, " > + "async =3D %d\n", > + __FUNCTION__, (uint64_t) mapnum, hostaddrs, sizes, kinds, async); > +#else > gomp_debug (0, "%s: mapnum=3D%zd, hostaddrs=3D%p, sizes=3D%p, kinds=3D= %p, > async=3D%d\n", > __FUNCTION__, mapnum, hostaddrs, sizes, kinds, async); > - > +#endif > select_acc_device (device); >=20=20 > thr =3D goacc_thread (); > @@ -178,8 +186,13 @@ GOACC_data_start (int device, size_t mapnum, > bool host_fallback =3D device =3D=3D GOMP_DEVICE_HOST_FALLBACK; > struct target_mem_desc *tgt; >=20=20 > +#ifdef HAVE_INTTYPES_H > + gomp_debug (0, "%s: mapnum=3D%"PRIu64", hostaddrs=3D%p, size=3D%p, kin= ds=3D%p\n", > + __FUNCTION__, (uint64_t) mapnum, hostaddrs, sizes, kinds); > +#else > gomp_debug (0, "%s: mapnum=3D%zd, hostaddrs=3D%p, sizes=3D%p, kinds=3D= %p\n", > __FUNCTION__, mapnum, hostaddrs, sizes, kinds); > +#endif >=20=20 > select_acc_device (device); >=20=20 > Index: target.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- target.c (Revision 221640) > +++ target.c (Arbeitskopie) > @@ -33,6 +33,9 @@ > #include > #include > #include > +#ifdef HAVE_INTTYPES_H > +# include /* For PRIu64. */ > +#endif > #include > #include >=20=20 > @@ -438,9 +441,16 @@ gomp_map_vars (struct gomp_device_descr *devicep, > /* We already looked up the memory region above and it > was missing. */ > size_t size =3D k->host_end - k->host_start; > +#ifdef HAVE_INTTYPES_H > gomp_fatal ("present clause: !acc_is_present (%p, " > + PRIu64" (0x"PRIx64"))", > + (void *) k->host_start, > + (uint64_t) size, (uint64_t) size); > +#else > + gomp_fatal ("present clause: !acc_is_present (%p, " > "%zd (0x%zx))", (void *) k->host_start, > size, size); > +#endif > } > break; > case GOMP_MAP_FORCE_DEVICEPTR: The fallback case really should use %ld or %lx and casts to (unsigned long). Targets that have inttypes.h will (with the exception of M$ targets) likely also support %zd / %zx. >>From gcc-bugs-return-481505-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Mar 24 19:51:08 2015 Return-Path: Delivered-To: listarch-gcc-bugs@gcc.gnu.org Received: (qmail 37620 invoked by alias); 24 Mar 2015 19:51:08 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Delivered-To: mailing list gcc-bugs@gcc.gnu.org Received: (qmail 37254 invoked by uid 55); 24 Mar 2015 19:51:03 -0000 From: "ian at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug go/65462] Use of 'go get' with gccgo is not finding dependencies correctly Date: Tue, 24 Mar 2015 20:19:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: go X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ian at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ian at airs dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg02649.txt.bz2 Content-length: 1269 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65462 --- Comment #7 from ian at gcc dot gnu.org --- Author: ian Date: Tue Mar 24 19:50:31 2015 New Revision: 221643 URL: https://gcc.gnu.org/viewcvs?rev=221643&root=gcc&view=rev Log: PR go/65462 cmd: Fix dependencies for 'go get' with gccgo Problem described in GCC BZ 65462. Generate the list of the standard GO package names based on what was built into libgo in the libgo Makefile. Change the var name from reqPkgSrc to reqStdPkgSrc to clarify it only affects standard GO packages. Skip the attempted loading of a package only if it is a standard GO package and the flag is set indicating its source is not required to be available. This requires a corresponding change to gotools to build and link in the new file containing the list of standard GO package names that was generated by the libgo Makefile. gotools/: PR go/65462 * Makefile.am (go_cmd_go_files): Add $(libgodir)/zstdpkglist.go. * Makefile.in: Rebuild. Modified: trunk/gotools/ChangeLog trunk/gotools/Makefile.am trunk/gotools/Makefile.in trunk/libgo/Makefile.am trunk/libgo/Makefile.in trunk/libgo/go/cmd/go/build.go trunk/libgo/go/cmd/go/pkg.go trunk/libgo/go/cmd/go/test.go