public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/65076] [5 Regression] 16% tramp3d-v4.cpp compile time regression
Date: Wed, 01 Apr 2015 08:28:00 -0000	[thread overview]
Message-ID: <bug-65076-4-30gFQyW1vt@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65076-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65076

--- Comment #49 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I did some experiments about the increase of early inlining insns:

 - Early optimizers of both 4.9 and mainline process 9819 functions.
 - At release_ssa time, the statement count is 8%
 - at ipa-cp, we have 9% fewer functions at mainline (so inliing helps)
 - At copyrename2 time, GCC 4.9 has 2% more statements and same number of
functions. The difference drops to 1% at .optimized time.

I do not think pure statement count explains the problem - early optimization
is small part of the queue. Also early-inlining-insns does not have at all that
much effect on GCC 4.9 (26.1s -> 16.9s or a noise)

A difference may be in a fact, that original metric used relative time benefits
that computed estimated time saved over estimated time for executing both
caller and callee. Now this metric drops to low values when caller is huge.
New metric does not have this property and do not consider it a bad idea to
inline into huge callers as long as time seems to improve measurably.  I
suppose it may account in overall slowdown as we get large functions more
often.

It seems supported by fact that mainline hits large-function-growth limit 285
times (about 9% of all functions output), while 4.9 7 times.

I am also seeing some issues with firefox and the new javascript interpreter.
It seems that current limit of inline-unit-growth (reduced from 30 to 15%) is
too small for new firefox trees and there is very good improvement for
increasing it back to 30%.  This however of course makes this PR worse. 

I have patch to re-implement original badness metric in current tree, lets see.


  parent reply	other threads:[~2015-04-01  8:28 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16 13:00 [Bug ipa/65076] New: " trippels at gcc dot gnu.org
2015-02-16 13:14 ` [Bug ipa/65076] " rguenth at gcc dot gnu.org
2015-02-16 13:22 ` trippels at gcc dot gnu.org
2015-02-16 18:31 ` hubicka at gcc dot gnu.org
2015-02-16 19:07 ` trippels at gcc dot gnu.org
2015-02-16 19:15 ` trippels at gcc dot gnu.org
2015-02-17 10:49 ` rguenth at gcc dot gnu.org
2015-03-04  9:10 ` rguenth at gcc dot gnu.org
2015-03-18 12:56 ` rguenth at gcc dot gnu.org
2015-03-21  5:32 ` hubicka at gcc dot gnu.org
2015-03-21 10:25 ` hubicka at gcc dot gnu.org
2015-03-21 10:48 ` hubicka at gcc dot gnu.org
2015-03-21 11:32 ` hubicka at gcc dot gnu.org
2015-03-24 14:56 ` rguenth at gcc dot gnu.org
2015-03-24 17:21 ` jakub at gcc dot gnu.org
2015-03-25  8:42 ` hubicka at gcc dot gnu.org
2015-03-25  8:42 ` hubicka at ucw dot cz
2015-03-25  8:50 ` rguenther at suse dot de
2015-03-25 21:35 ` hubicka at gcc dot gnu.org
2015-03-26  3:23 ` hubicka at gcc dot gnu.org
2015-03-27  4:03 ` hubicka at gcc dot gnu.org
2015-03-27  6:21 ` hubicka at gcc dot gnu.org
2015-03-27  9:34 ` rguenth at gcc dot gnu.org
2015-03-28 22:17 ` hubicka at gcc dot gnu.org
2015-03-29 14:29 ` trippels at gcc dot gnu.org
2015-03-30  6:03 ` hubicka at gcc dot gnu.org
2015-03-30  6:15 ` hubicka at gcc dot gnu.org
2015-03-31 13:03 ` rguenth at gcc dot gnu.org
2015-03-31 13:09 ` trippels at gcc dot gnu.org
2015-03-31 14:10 ` rguenther at suse dot de
2015-03-31 14:13 ` trippels at gcc dot gnu.org
2015-03-31 14:47 ` trippels at gcc dot gnu.org
2015-03-31 15:08 ` trippels at gcc dot gnu.org
2015-03-31 15:10 ` evstupac at gmail dot com
2015-03-31 15:29 ` rguenth at gcc dot gnu.org
2015-03-31 16:06 ` hubicka at ucw dot cz
2015-03-31 16:25 ` hubicka at gcc dot gnu.org
2015-03-31 17:36 ` hubicka at gcc dot gnu.org
2015-03-31 17:53 ` hubicka at gcc dot gnu.org
2015-03-31 17:54 ` hubicka at gcc dot gnu.org
2015-03-31 20:31 ` trippels at gcc dot gnu.org
2015-04-01  8:02 ` rguenther at suse dot de
2015-04-01  8:05 ` rguenther at suse dot de
2015-04-01  8:28 ` hubicka at gcc dot gnu.org [this message]
2015-04-01  8:34 ` trippels at gcc dot gnu.org
2015-04-02  5:18 ` hubicka at gcc dot gnu.org
2015-04-02  7:07 ` hubicka at gcc dot gnu.org
2015-04-02 23:44 ` hubicka at gcc dot gnu.org
2015-04-03 18:09 ` hubicka at gcc dot gnu.org
2015-04-07  9:32 ` rguenth at gcc dot gnu.org
2015-04-22  1:32 ` [Bug ipa/65076] [5/6 " hubicka at gcc dot gnu.org
2015-04-22 12:06 ` jakub at gcc dot gnu.org
2015-07-16  9:19 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65076-4-30gFQyW1vt@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).