[Bug testsuite/65107] New: FAIL: gfortran.dg/eof_4.f90, runtime error: File 'test.dat' already exists

[Bug testsuite/65107] New: FAIL: gfortran.dg/eof_4.f90, runtime error: File 'test.dat' already exists

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65107

            Bug ID: 65107
           Summary: FAIL: gfortran.dg/eof_4.f90, runtime error: File
                    'test.dat' already exists
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vries at gcc dot gnu.org

failure in gfortran.sum:
...
FAIL: gfortran.dg/eof_4.f90   -O0  execution test
FAIL: gfortran.dg/eof_4.f90   -O1  execution test
FAIL: gfortran.dg/eof_4.f90   -O2  execution test
FAIL: gfortran.dg/eof_4.f90   -O3 -fomit-frame-pointer  execution test
FAIL: gfortran.dg/eof_4.f90   -O3 -fomit-frame-pointer -funroll-all-loops
-finline-functions  execution test
FAIL: gfortran.dg/eof_4.f90   -O3 -fomit-frame-pointer -funroll-loops 
execution test
FAIL: gfortran.dg/eof_4.f90   -O3 -g  execution test
FAIL: gfortran.dg/eof_4.f90   -Os  execution test
...

In more detail:
...
At line 12 of file src/gcc/testsuite/gfortran.dg/eof_4.f90 (unit = 99)
Fortran runtime error: File 'test.dat' already exists
FAIL: gfortran.dg/eof_4.f90   -O0  execution test
...

Probably observed earlier here: PR64770 comment 0.

The nature of the failure is that the test expects test.dat not to exist, but
it does.

The test itself does not clean up after itself, so it's missing:
...
! { dg-final { remote_file build delete "test.dat" } }
...

But cleaning after itself does not guarantee that this failure is fixed. We
need to ensure that all tests that use test.dat clean up after themselves.

[Bug testsuite/65107] FAIL: gfortran.dg/eof_4.f90, runtime error: File 'test.dat' already exists

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65107

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-02-18
     Ever confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
> Probably observed earlier here: PR64770 comment 0.

Indeed!

> But cleaning after itself does not guarantee that this failure is fixed.
> We need to ensure that all tests that use test.dat clean up after themselves.

AFAICT this is done for normal execution, but not if the test aborts.

[Bug testsuite/65107] FAIL: gfortran.dg/eof_4.f90, runtime error: File 'test.dat' already exists

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65107

--- Comment #2 from vries at gcc dot gnu.org ---
(In reply to Dominique d'Humieres from comment #1)
> > But cleaning after itself does not guarantee that this failure is fixed.
> > We need to ensure that all tests that use test.dat clean up after themselves.
> 
> AFAICT this is done for normal execution, but not if the test aborts.

You're right. The test.dat I see, is from gfortran.dg/read_eof_8.f90. Something
like this will probably fix that:
...
diff --git a/gcc/testsuite/gfortran.dg/read_eof_8.f90
b/gcc/testsuite/gfortran.dg/read_eof_8.f90
index 7436a2b..86228da 100644
--- a/gcc/testsuite/gfortran.dg/read_eof_8.f90
+++ b/gcc/testsuite/gfortran.dg/read_eof_8.f90
@@ -20,6 +20,7 @@ program test
   enddo
   call abort
 100 if (k /= 5) call abort
+  close(25, status="delete")
   stop
 101 call abort
 end program test
...

[Bug testsuite/65107] FAIL: gfortran.dg/eof_4.f90, runtime error: File 'test.dat' already exists

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65107

--- Comment #3 from vries at gcc dot gnu.org ---
Author: vries
Date: Wed Feb 18 20:07:48 2015
New Revision: 220794

URL: https://gcc.gnu.org/viewcvs?rev=220794&root=gcc&view=rev
Log:
Add missing cleanup in gfortran.dg/read_eof_8.f90

2015-02-18  Tom de Vries  <tom@codesourcery.com>

    PR testsuite/65107
    * gfortran.dg/read_eof_8.f90: Add missing close.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/read_eof_8.f90

[Bug testsuite/65107] FAIL: gfortran.dg/eof_4.f90, runtime error: File 'test.dat' already exists

[vries at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65107

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from vries at gcc dot gnu.org ---
Fixed testcase, marking resolved,fixed