public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final
@ 2015-02-19 9:58 vries at gcc dot gnu.org
2015-02-19 10:09 ` [Bug testsuite/65116] " vries at gcc dot gnu.org
` (11 more replies)
0 siblings, 12 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2015-02-19 9:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
Bug ID: 65116
Summary: additional_sources not defined anymore during dg-final
Product: gcc
Version: 5.0
Status: UNCONFIRMED
Severity: trivial
Priority: P3
Component: testsuite
Assignee: unassigned at gcc dot gnu.org
Reporter: vries at gcc dot gnu.org
When running vect-simd-clone-10.c, a file vect-simd-clone-10a.c.126t.vect is
left in the test directory.
The testcase lists vect-simd-clone-10a.c as addditional source:
...
/* { dg-additional-sources vect-simd-clone-10a.c } */
...
Then the test-case cleans up the respective tree-dump:
...
/* { dg-final { cleanup-tree-dump "vect" } } */
...
The cleanup-tree-dump calls cleanup-dump, which intends to take
additional_sources into account.
However, the global additional_sources declaration is missing, so the exists
additional_sources will always return false.
And if we add the global additional_sources declaration, it still fails,
because additional_sources is empty. It has been reset by
dg-additional-files-options, which is called by gcc_target_compile, which is
called by gcc-dg-test-1, which is called by gcc-dg-test, which is called by
dg-test as ${tool}-dg-test.
dg-test does the the dg-final-code processing after the ${tool}-dg-test so at
that point additional_sources is empty.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
@ 2015-02-19 10:09 ` vries at gcc dot gnu.org
2015-02-19 12:02 ` redi at gcc dot gnu.org
` (10 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2015-02-19 10:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #1 from vries at gcc dot gnu.org ---
Presumably same thing happens for pr47218.C, which saves temps:
...
/* { dg-options "-save-temps" } */
...
And cleans them up:
...
// { dg-final { cleanup-saved-temps }
...
but also has additional sources:
...
/* { dg-additional-sources "pr47218-1.C" } */
...
Of which the temps are not cleaned up:
...
pr47218-1.o pr47218-1.ii pr47218-1.s
...
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
2015-02-19 10:09 ` [Bug testsuite/65116] " vries at gcc dot gnu.org
@ 2015-02-19 12:02 ` redi at gcc dot gnu.org
2015-02-19 12:09 ` vries at gcc dot gnu.org
` (9 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: redi at gcc dot gnu.org @ 2015-02-19 12:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Is this related to these errors I'm seeing in the libstdc++ testsuite?
ERROR: 18_support/type_info/fundamental.cc: can't read "additional_sources": no
such variable for " dg-require-effective-target 2 dfp "
ERROR: 17_intro/shared_with_static_deps.cc: can't read "additional_sources": no
such variable for " dg-require-effective-target 4 fpic "
ERROR: 21_strings/c_strings/char/3_neg.cc: can't read "additional_sources": no
such variable for " dg-do 1 compile { target
correct_iso_cpp_string_wchar_protos } "
ERROR: 21_strings/c_strings/wchar_t/3_neg.cc: can't read
"et_cache(correct_iso_cpp_string_wchar_protos,value)": no such element in array
for " dg-do 1 compile { target correct_iso_cpp_string_wchar_protos } "
ERROR: 22_locale/collate/compare/wchar_t/wrapped_env.cc: can't read
"additional_sources": no such variable for " dg-require-iconv 4 "ISO8859-1" "
...
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
2015-02-19 10:09 ` [Bug testsuite/65116] " vries at gcc dot gnu.org
2015-02-19 12:02 ` redi at gcc dot gnu.org
@ 2015-02-19 12:09 ` vries at gcc dot gnu.org
2015-02-19 12:11 ` [Bug testsuite/65116] [4.9/5 Regression] " rguenth at gcc dot gnu.org
` (8 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2015-02-19 12:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
vries at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mkuvyrkov at gcc dot gnu.org
--- Comment #3 from vries at gcc dot gnu.org ---
I suspect those errors are due to Maxim's recent checkin. Maybe missing exist
test?
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (2 preceding siblings ...)
2015-02-19 12:09 ` vries at gcc dot gnu.org
@ 2015-02-19 12:11 ` rguenth at gcc dot gnu.org
2015-02-19 12:13 ` mkuvyrkov at gcc dot gnu.org
` (7 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-02-19 12:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Target Milestone|--- |4.9.3
Summary|additional_sources not |[4.9/5 Regression]
|defined anymore during |additional_sources not
|dg-final |defined anymore during
| |dg-final
Severity|trivial |blocker
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Also broken on the 4.9 branch. Was this ever tested?!
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (3 preceding siblings ...)
2015-02-19 12:11 ` [Bug testsuite/65116] [4.9/5 Regression] " rguenth at gcc dot gnu.org
@ 2015-02-19 12:13 ` mkuvyrkov at gcc dot gnu.org
2015-02-19 12:30 ` vries at gcc dot gnu.org
` (6 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mkuvyrkov at gcc dot gnu.org @ 2015-02-19 12:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #5 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
It was tested, but, obviously, not as well as it should. I'll revert the
change for now.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (4 preceding siblings ...)
2015-02-19 12:13 ` mkuvyrkov at gcc dot gnu.org
@ 2015-02-19 12:30 ` vries at gcc dot gnu.org
2015-02-19 18:13 ` dje at gcc dot gnu.org
` (5 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2015-02-19 12:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #6 from vries at gcc dot gnu.org ---
I reproduced the issue in the description field with and without Maxim's patch,
so AFAIU it's an orthogonal issue.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (5 preceding siblings ...)
2015-02-19 12:30 ` vries at gcc dot gnu.org
@ 2015-02-19 18:13 ` dje at gcc dot gnu.org
2015-02-19 19:43 ` vries at gcc dot gnu.org
` (4 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: dje at gcc dot gnu.org @ 2015-02-19 18:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
David Edelsohn <dje at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-02-19
CC| |dje at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #7 from David Edelsohn <dje at gcc dot gnu.org> ---
Confirmed on AIX.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (6 preceding siblings ...)
2015-02-19 18:13 ` dje at gcc dot gnu.org
@ 2015-02-19 19:43 ` vries at gcc dot gnu.org
2015-02-19 19:58 ` mkuvyrkov at gcc dot gnu.org
` (3 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2015-02-19 19:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #8 from vries at gcc dot gnu.org ---
(In reply to Maxim Kuvyrkov from comment #5)
> It was tested, but, obviously, not as well as it should. I'll revert the
> change for now.
Hi Maxim,
The change was reverted on 4-9 branch. Did you also plan to revert it on trunk?
Thanks,
- Tom
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (7 preceding siblings ...)
2015-02-19 19:43 ` vries at gcc dot gnu.org
@ 2015-02-19 19:58 ` mkuvyrkov at gcc dot gnu.org
2015-02-19 20:05 ` mkuvyrkov at gcc dot gnu.org
` (2 subsequent siblings)
11 siblings, 0 replies; 13+ messages in thread
From: mkuvyrkov at gcc dot gnu.org @ 2015-02-19 19:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #9 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
Author: mkuvyrkov
Date: Thu Feb 19 19:57:30 2015
New Revision: 220822
URL: https://gcc.gnu.org/viewcvs?rev=220822&root=gcc&view=rev
Log:
Fix PR testsuite/65116
PR testsuite/65116
* lib/target-supports.exp (check_compile): Check whether
additional_sources is defined before using it.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/lib/target-supports.exp
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] additional_sources not defined anymore during dg-final
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (8 preceding siblings ...)
2015-02-19 19:58 ` mkuvyrkov at gcc dot gnu.org
@ 2015-02-19 20:05 ` mkuvyrkov at gcc dot gnu.org
2015-02-19 23:35 ` [Bug testsuite/65116] [4.9/5 Regression] ERROR: can't read additional_sources: no such variable vries at gcc dot gnu.org
2015-03-24 17:28 ` mkuvyrkov at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: mkuvyrkov at gcc dot gnu.org @ 2015-02-19 20:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #10 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
Fixed by the above commit.
Will re-apply the change with this fix on 4.9 branch in a week if everything
looks OK.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] ERROR: can't read additional_sources: no such variable
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (9 preceding siblings ...)
2015-02-19 20:05 ` mkuvyrkov at gcc dot gnu.org
@ 2015-02-19 23:35 ` vries at gcc dot gnu.org
2015-03-24 17:28 ` mkuvyrkov at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: vries at gcc dot gnu.org @ 2015-02-19 23:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
vries at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[4.9/5 Regression] |[4.9/5 Regression] ERROR:
|additional_sources not |can't read
|defined anymore during |additional_sources: no such
|dg-final |variable
--- Comment #11 from vries at gcc dot gnu.org ---
This report got hijacked for an unrelated problem, renaming to something
appropriate.
Filed the original issue as PR65126.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Bug testsuite/65116] [4.9/5 Regression] ERROR: can't read additional_sources: no such variable
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
` (10 preceding siblings ...)
2015-02-19 23:35 ` [Bug testsuite/65116] [4.9/5 Regression] ERROR: can't read additional_sources: no such variable vries at gcc dot gnu.org
@ 2015-03-24 17:28 ` mkuvyrkov at gcc dot gnu.org
11 siblings, 0 replies; 13+ messages in thread
From: mkuvyrkov at gcc dot gnu.org @ 2015-03-24 17:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65116
--- Comment #12 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
Author: mkuvyrkov
Date: Tue Mar 24 17:19:34 2015
New Revision: 221639
URL: https://gcc.gnu.org/viewcvs?rev=221639&root=gcc&view=rev
Log:
Backport testsuite race fix from mainline
Backport from mainline:
2015-02-19 Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
PR testsuite/65116
* lib/target-supports.exp (check_compile): Check whether
additional_sources is defined before using it.
2015-02-19 Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>
* lib/target-supports.exp (check_compile): Save/restore
additional_sources that may belong to an actual test.
Modified:
branches/gcc-4_9-branch/gcc/testsuite/ChangeLog
branches/gcc-4_9-branch/gcc/testsuite/lib/target-supports.exp
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-03-24 17:20 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19 9:58 [Bug testsuite/65116] New: additional_sources not defined anymore during dg-final vries at gcc dot gnu.org
2015-02-19 10:09 ` [Bug testsuite/65116] " vries at gcc dot gnu.org
2015-02-19 12:02 ` redi at gcc dot gnu.org
2015-02-19 12:09 ` vries at gcc dot gnu.org
2015-02-19 12:11 ` [Bug testsuite/65116] [4.9/5 Regression] " rguenth at gcc dot gnu.org
2015-02-19 12:13 ` mkuvyrkov at gcc dot gnu.org
2015-02-19 12:30 ` vries at gcc dot gnu.org
2015-02-19 18:13 ` dje at gcc dot gnu.org
2015-02-19 19:43 ` vries at gcc dot gnu.org
2015-02-19 19:58 ` mkuvyrkov at gcc dot gnu.org
2015-02-19 20:05 ` mkuvyrkov at gcc dot gnu.org
2015-02-19 23:35 ` [Bug testsuite/65116] [4.9/5 Regression] ERROR: can't read additional_sources: no such variable vries at gcc dot gnu.org
2015-03-24 17:28 ` mkuvyrkov at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).