public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mkuvyrkov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/65126] [5 Regresion] additional_sources not defined anymore during dg-final
Date: Fri, 20 Feb 2015 09:57:00 -0000	[thread overview]
Message-ID: <bug-65126-4-Wtx6FdDN2M@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65126-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65126

Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkuvyrkov at gcc dot gnu.org

--- Comment #5 from Maxim Kuvyrkov <mkuvyrkov at gcc dot gnu.org> ---
The problem here is that gcc_target_compile (and, probably, other
*_target_compile procs) clears out additional_sources as soon as it is done.

I don't immediately know how to fix this properly.  A quick fix may be to delay
clearing out additional_sources till a later point.

More generally, from what I see GCC's testsuite doesn't have coordinated
maintenance of its global state (additional_* and other variables, see
gcc-dg.exp).  It would be a nice cleanup to have PUSH and POP operations for
global state that could used to 

1. clearing of state for next test
  -- the POP to a reference clean state would be done once all parts of the
test would finish, thus removing the need to clear out additional_sources after
compilation (== midway through running the test).

2. saving / restoring of state for target-supports checks.


  parent reply	other threads:[~2015-02-20  9:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 23:31 [Bug testsuite/65126] New: " vries at gcc dot gnu.org
2015-02-19 23:31 ` [Bug testsuite/65126] " vries at gcc dot gnu.org
2015-02-20  7:45 ` [Bug testsuite/65126] [5 Regresion] " rguenth at gcc dot gnu.org
2015-02-20  7:56 ` mkuvyrkov at gcc dot gnu.org
2015-02-20  8:32 ` vries at gcc dot gnu.org
2015-02-20  9:57 ` mkuvyrkov at gcc dot gnu.org [this message]
2015-02-22 14:47 ` vries at gcc dot gnu.org
2015-02-22 15:17 ` [Bug testsuite/65126] [5 Regression] " vries at gcc dot gnu.org
2015-02-23  8:42 ` vries at gcc dot gnu.org
2015-02-24  8:21 ` vries at gcc dot gnu.org
2015-02-24  8:33 ` vries at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65126-4-Wtx6FdDN2M@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).