[Bug c++/65127] New: internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[Bug c++/65127] New: internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[lukeallardyce at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

            Bug ID: 65127
           Summary: internal compiler error: tree check: expected tree
                    that contains 'decl minimal' structure, have
                    'addr_expr' in parsing_nsdmi, at cp/parser.c:18311
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: lukeallardyce at gmail dot com

void make_item()
{
  static int i{100};

  struct
  {
    int id{i++};
  } item;
}

int main()
{
  make_item<0>();
}

------

g++ -std=c++11 bug.cpp -c

bug.cpp: In instantiation of 'void make_item() [with int sz = 0]':
bug.cpp:14:16:   required from here
bug.cpp:9:5: internal compiler error: tree check: expected tree that contains
'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at
cp/parser.c:18311
   } item;
     ^

bug.cpp:9:5: internal compiler error: Abort trap: 6
g++: internal compiler error: Abort trap: 6 (program cc1plus)


GCC built from trunk on 2/16

[Bug c++/65127] [5 Regression] internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-02-20
                 CC|                            |mpolacek at gcc dot gnu.org
   Target Milestone|---                         |5.0
            Summary|internal compiler error:    |[5 Regression] internal
                   |tree check: expected tree   |compiler error: tree check:
                   |that contains 'decl         |expected tree that contains
                   |minimal' structure, have    |'decl minimal' structure,
                   |'addr_expr' in              |have 'addr_expr' in
                   |parsing_nsdmi, at           |parsing_nsdmi, at
                   |cp/parser.c:18311           |cp/parser.c:18311
     Ever confirmed|0                           |1

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
Started with r216750.

Note that we ICE even on

template<int sz> void make_item()
{
  static int i{100};

  struct
  {
    int id{i++};
  } item;
}

int main()
{
  make_item<0>();
}

which is accepted by 4.9 and clang.

[Bug c++/65127] [5 Regression] internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jason at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So it seems current_class_ptr is no longer just NULL or a PARM_DECL, but can be
also ADDR_EXPR of a PLACEHOLDER_EXPR.  Dunno if the right fix is
just
 bool
 parsing_nsdmi (void)
 {
   /* We recognize NSDMI context by the context-less 'this' pointer set up
      by the function above.  */
-   if (current_class_ptr && DECL_CONTEXT (current_class_ptr) == NULL_TREE)
+   if (current_class_ptr
+       && TREE_CODE (current_class_ptr) == PARM_DECL
+       && DECL_CONTEXT (current_class_ptr) == NULL_TREE)
     return true;
   return false;
 }
or something different.

[Bug c++/65127] [5 Regression] internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[ktietz at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktietz at gcc dot gnu.org

--- Comment #4 from Kai Tietz <ktietz at gcc dot gnu.org> ---
Hmm, this issue seems to be fixed by delayed folding.  By it I get the
following error-message:

t3.cpp: In function 'int main()':
t3.cpp:13:16: error: expected primary-expression before ')' token
   make_item<0>();
                ^
So there is still a parser-error, if this piece of code is considered to be
valid code

[Bug c++/65127] [5 Regression] internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #3)
> So it seems current_class_ptr is no longer just NULL or a PARM_DECL, but can
> be also ADDR_EXPR of a PLACEHOLDER_EXPR.  Dunno if the right fix is
> just
>  bool
>  parsing_nsdmi (void)
>  {
>    /* We recognize NSDMI context by the context-less 'this' pointer set up
>       by the function above.  */
> -   if (current_class_ptr && DECL_CONTEXT (current_class_ptr) == NULL_TREE)
> +   if (current_class_ptr
> +       && TREE_CODE (current_class_ptr) == PARM_DECL
> +       && DECL_CONTEXT (current_class_ptr) == NULL_TREE)
>      return true;
>    return false;
>  }
> or something different.

This change is OK.

[Bug c++/65127] [5 Regression] internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Tue Mar 10 19:10:43 2015
New Revision: 221332

URL: https://gcc.gnu.org/viewcvs?rev=221332&root=gcc&view=rev
Log:
    PR c++/65127
    * parser.c (parsing_nsdmi): Don't return true if current_class_ptr
    is not a PARM_DECL.

    * g++.dg/cpp0x/pr65127.C: New test.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/pr65127.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/parser.c
    trunk/gcc/testsuite/ChangeLog

[Bug c++/65127] [5 Regression] internal compiler error: tree check: expected tree that contains 'decl minimal' structure, have 'addr_expr' in parsing_nsdmi, at cp/parser.c:18311

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65127

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.