public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug testsuite/65205] New: Wrong dh-shouldfail usage in OpenACC libgomp tests
@ 2015-02-25 14:01 tschwinge at gcc dot gnu.org
2015-04-30 12:45 ` [Bug testsuite/65205] Wrong dg-shouldfail " tschwinge at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-02-25 14:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65205
Bug ID: 65205
Summary: Wrong dh-shouldfail usage in OpenACC libgomp tests
Product: gcc
Version: 5.0
Status: UNCONFIRMED
Keywords: openacc
Severity: major
Priority: P3
Component: testsuite
Assignee: jnorris at gcc dot gnu.org
Reporter: tschwinge at gcc dot gnu.org
A bunch of the OpenACC libgomp tests that we added are expected to terminate
with an error exit status, and printing specific error message. For a lot of
them, we wrongly just used dg-shouldfail directives to codify this, providing
the expected error message as the comment argument to dg-shouldfail. Separate
dg-output directives should be used instead, so that we can detect if the test
case actually does fail, but not for the expected reason (that is, with the
specific error message). (See
libgomp/testsuite/libgomp.oacc-fortran/data-already-1.f, for example.)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug testsuite/65205] Wrong dg-shouldfail usage in OpenACC libgomp tests
2015-02-25 14:01 [Bug testsuite/65205] New: Wrong dh-shouldfail usage in OpenACC libgomp tests tschwinge at gcc dot gnu.org
@ 2015-04-30 12:45 ` tschwinge at gcc dot gnu.org
2015-04-30 13:10 ` tschwinge at gcc dot gnu.org
2015-05-05 9:40 ` tschwinge at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-04-30 12:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65205
--- Comment #2 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Author: tschwinge
Date: Thu Apr 30 12:44:39 2015
New Revision: 222620
URL: https://gcc.gnu.org/viewcvs?rev=222620&root=gcc&view=rev
Log:
[PR testsuite/65205] Fix dg-shouldfail usage in OpenACC libgomp tests
PR testsuite/65205
libgomp/
* testsuite/lib/libgomp.exp
(check_effective_target_openacc_host_selected)
(check_effective_target_openacc_host_nonshm_selected): New
procedures.
* testsuite/libgomp.oacc-c-c++-common/clauses-2.c: Fix misuse of
dg-shouldfail.
* testsuite/libgomp.oacc-c-c++-common/lib-1.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-11.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-16.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-17.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-18.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-2.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-20.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-21.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-22.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-23.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-25.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-26.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-27.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-28.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-29.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-3.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-30.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-34.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-35.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-36.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-39.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-4.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-40.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-42.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-43.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-44.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-47.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-48.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-52.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-53.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-54.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-57.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-58.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-62.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-63.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-64.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-65.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-67.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-68.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-71.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-77.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-80.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/present-1.c: Likewise.
Modified:
trunk/libgomp/ChangeLog
trunk/libgomp/testsuite/lib/libgomp.exp
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/clauses-2.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-1.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-11.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-16.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-17.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-18.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-2.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-20.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-21.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-22.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-23.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-25.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-26.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-27.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-28.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-29.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-3.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-30.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-34.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-35.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-36.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-39.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-4.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-40.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-42.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-43.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-44.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-47.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-48.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-52.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-53.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-54.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-57.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-58.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-62.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-63.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-64.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-65.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-67.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-68.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-71.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-77.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-80.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/present-1.c
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug testsuite/65205] Wrong dg-shouldfail usage in OpenACC libgomp tests
2015-02-25 14:01 [Bug testsuite/65205] New: Wrong dh-shouldfail usage in OpenACC libgomp tests tschwinge at gcc dot gnu.org
2015-04-30 12:45 ` [Bug testsuite/65205] Wrong dg-shouldfail " tschwinge at gcc dot gnu.org
@ 2015-04-30 13:10 ` tschwinge at gcc dot gnu.org
2015-05-05 9:40 ` tschwinge at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-04-30 13:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65205
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Assignee|jnorris at gcc dot gnu.org |tschwinge at gcc dot gnu.org
--- Comment #3 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Applied Jim's patch in r222620.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug testsuite/65205] Wrong dg-shouldfail usage in OpenACC libgomp tests
2015-02-25 14:01 [Bug testsuite/65205] New: Wrong dh-shouldfail usage in OpenACC libgomp tests tschwinge at gcc dot gnu.org
2015-04-30 12:45 ` [Bug testsuite/65205] Wrong dg-shouldfail " tschwinge at gcc dot gnu.org
2015-04-30 13:10 ` tschwinge at gcc dot gnu.org
@ 2015-05-05 9:40 ` tschwinge at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: tschwinge at gcc dot gnu.org @ 2015-05-05 9:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65205
--- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Author: tschwinge
Date: Tue May 5 09:39:29 2015
New Revision: 222799
URL: https://gcc.gnu.org/viewcvs?rev=222799&root=gcc&view=rev
Log:
[PR testsuite/65205, libgomp/65993] Fix dg-shouldfail usage in OpenACC libgomp
tests
In dg-output, don't expect "0x" prefix for "%p" format specifier, don't expect
"(nil)" for NULL pointer.
PR testsuite/65205
PR libgomp/65993
libgomp/
* testsuite/libgomp.oacc-c-c++-common/clauses-2.c: In dg-output,
don't expect "0x" prefix for "%p" format specifier, don't expect
"(nil)" for NULL pointer.
* testsuite/libgomp.oacc-c-c++-common/lib-16.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-17.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-18.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-20.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-21.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-22.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-23.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-25.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-26.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-27.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-28.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-29.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-30.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-34.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-35.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-36.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-39.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-40.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-42.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-43.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-44.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-47.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-48.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-52.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-53.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-54.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-57.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/lib-58.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/data-already-1.c: More
accurately specify what we're looking for.
* testsuite/libgomp.oacc-c-c++-common/data-already-2.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/data-already-8.c: Likewise.
* testsuite/libgomp.oacc-fortran/data-already-1.f: Likewise.
* testsuite/libgomp.oacc-fortran/data-already-2.f: Likewise.
* testsuite/libgomp.oacc-fortran/data-already-8.f: Likewise.
Modified:
trunk/libgomp/ChangeLog
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/clauses-2.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/data-already-1.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/data-already-2.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/data-already-8.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-16.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-17.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-18.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-20.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-21.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-22.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-23.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-25.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-26.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-27.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-28.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-29.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-30.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-34.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-35.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-36.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-39.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-40.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-42.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-43.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-44.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-47.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-48.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-52.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-53.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-54.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-57.c
trunk/libgomp/testsuite/libgomp.oacc-c-c++-common/lib-58.c
trunk/libgomp/testsuite/libgomp.oacc-fortran/data-already-1.f
trunk/libgomp/testsuite/libgomp.oacc-fortran/data-already-2.f
trunk/libgomp/testsuite/libgomp.oacc-fortran/data-already-8.f
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-05 9:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-25 14:01 [Bug testsuite/65205] New: Wrong dh-shouldfail usage in OpenACC libgomp tests tschwinge at gcc dot gnu.org
2015-04-30 12:45 ` [Bug testsuite/65205] Wrong dg-shouldfail " tschwinge at gcc dot gnu.org
2015-04-30 13:10 ` tschwinge at gcc dot gnu.org
2015-05-05 9:40 ` tschwinge at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).