[Bug ipa/65245] New: [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[Bug ipa/65245] New: [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

            Bug ID: 65245
           Summary: [5 Regression] internal compiler error: in
                    address_matters_p, at symtab.c:1908
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: ipa
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org

Starting from r221040, following ICE can be seen by Steve:


Following up to my own email.  I can reproduce this with the following
cut down test case if I compile with '-O2 -fmerge-all-constants' on
MIPS.

extern const char *const _sys_siglist[128];
const char *const __new_sys_siglist[128] = { };
extern __typeof (_sys_siglist) __EI__sys_siglist __attribute__((alias (""
"__new_sys_siglist")));
extern __typeof (__new_sys_siglist) _new_sys_siglist __attribute__ ((alias
("__new_sys_siglist")));

Steve Ellcey
sellcey@imgtec.com

[Bug ipa/65245] [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 34893
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34893&action=edit
Suggested patch

I've been testing following patch.
>From gcc-bugs-return-478785-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Feb 27 19:10:44 2015
Return-Path: <gcc-bugs-return-478785-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 39928 invoked by alias); 27 Feb 2015 19:10:43 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 39835 invoked by uid 48); 27 Feb 2015 19:10:36 -0000
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/65233] [5 Regression] ICE (segfault) on arm-linux-gnueabihf
Date: Fri, 27 Feb 2015 20:46:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: aldyh at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-65233-4-9onTJnlFcy@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65233-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65233-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg03117.txt.bz2
Content-length: 1178

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide233

--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
FWIW, I also ran valgrind on cc1plus just for good measure, to see if we were
hitting some uninitialized memory issues, but I came out empty handed:

reynosa:/dev/shm/t/gcc$ valgrind --leak-check=no --track-origins=yes ./cc1plus
a.c -quiet -O3 -I./
=\x16433== Memcheck, a memory error detector
=\x16433== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al.
=\x16433== Using Valgrind-3.10.1 and LibVEX; rerun with -h for copyright info
=\x16433== Command: ./cc1plus a.c -quiet -O3 -I./
=\x16433==\x16433==\x16433== HEAP SUMMARY:
=\x16433==     in use at exit: 604,299 bytes in 3,095 blocks
=\x16433==   total heap usage: 45,429 allocs, 42,334 frees, 26,667,821 bytes
allocated
=\x16433==\x16433== For a detailed leak analysis, rerun with: --leak-check=full
=\x16433==\x16433== For counts of detected and suppressed errors, rerun with: -v
=\x16433== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

p.s. I disabled the memory leak checks because I found a handful of them, most
of which were expected or minor enough to be irrelevant.

[Bug ipa/65245] [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

--- Comment #2 from Jan Hubicka <hubicka at ucw dot cz> ---
Hi,
why do you try to merge aliases? Those should be filtered out - it is enough to
merge the actual definitions (with a body)

Honza

[Bug ipa/65245] [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[sje at gcc dot gnu.org]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 2595 bytes --]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

--- Comment #3 from Steve Ellcey <sje at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #1)
> Created attachment 34893 [details]
> Suggested patch
> 
> I've been testing following patch.

FYI: I tested this patch on MIPS and it works for me.
>From gcc-bugs-return-478796-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Fri Feb 27 21:20:21 2015
Return-Path: <gcc-bugs-return-478796-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 79919 invoked by alias); 27 Feb 2015 21:20:21 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 79856 invoked by uid 48); 27 Feb 2015 21:20:18 -0000
From: "pthaugen at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/65237] [5 Regression] r221040 caused many regressions
Date: Fri, 27 Feb 2015 22:15:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: ipa
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: pthaugen at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: cc attachments.created
Message-ID: <bug-65237-4-JChawL7R65@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65237-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65237-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-02/txt/msg03128.txt.bz2
Content-length: 493

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide237

Pat Haugen <pthaugen at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pthaugen at gcc dot gnu.org

--- Comment #11 from Pat Haugen <pthaugen at gcc dot gnu.org> ---
Created attachment 34896
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id4896&actioníit
reduced testcase

[Bug ipa/65245] [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
   Target Milestone|---                         |5.0
           Severity|normal                      |blocker

[Bug ipa/65245] [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

--- Comment #4 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Author: hubicka
Date: Sun Mar  1 20:23:21 2015
New Revision: 221090

URL: https://gcc.gnu.org/viewcvs?rev=221090&root=gcc&view=rev
Log:

2015-02-28  Martin Liska  <mliska@suse.cz>
        Jan Hubicka   <hubicka@ucw.cz>

    PR ipa/65245
    * ipa-icf-gimple.c (func_checker::compare_function_decl):
    Remove.
    (func_checker::compare_variable_decl): Skip symtab vars.
    (func_checker::compare_cst_or_decl): Update.
    * ipa-icf.c (sem_function::parse): Do not consider aliases.
    (sem_function::compare_cgraph_references): Add ADDRESS parameter;
    use correct symtab predicates.
    (sem_function::equals_wpa): Update uses of compare_cgraph_references.
    (sem_variable::parse):  Update comment.
    (sem_item_optimizer::build_graph): Consider ultimate aliases
    for references.

    * gcc.dg/ipa/ipa-icf-34.c: New test.


Added:
    trunk/gcc/testsuite/gcc.dg/ipa/ipa-icf-34.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-icf-gimple.c
    trunk/gcc/ipa-icf.c
    trunk/gcc/ipa-icf.h
    trunk/gcc/testsuite/ChangeLog

[Bug ipa/65245] [5 Regression] internal compiler error: in address_matters_p, at symtab.c:1908

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65245

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.