public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses Date: Thu, 05 Mar 2015 00:21:00 -0000 [thread overview] Message-ID: <bug-65270-4-cY4oMUOhoV@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-65270-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #18 from Jan Hubicka <hubicka at gcc dot gnu.org> --- Here is summary of my current understanding of remaining issues from my last weekend's audit. ICF specific: - ipa-icf-gimple.c needs to match dependence analysis Richard has propsed a patch for it, so I hope he will commit it tomorrow. - restrict flag may need to be matched when considering two references to variables being equal. Here I am waiting for Richards comment. I would propose matching restricts in compare_cgraph_references same way as we now compare vtables. non-ICF specific wrong codes - tree-vectorizer is picking up wrong alignment - fold-const.c's operands_equal_p probably needs same treatment for comparing mem-ref as ipa-icf-gimple has. I think in all cases one can construct testcase where tree-tail-merge would produce same incorrect merging as ipa-icf does. stuff that can wait for next stage1 - ipa-pure-const is probably wrong to check TYPE_NEEDS_CONSTRUCTION flag (something to fix for next stage1) - expand_builtin_classify_type can probably be dropped, because fold_classify_type prevails.
next prev parent reply other threads:[~2015-03-05 0:21 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-03-02 0:49 [Bug ipa/65270] New: " hubicka at gcc dot gnu.org 2015-03-02 8:58 ` [Bug ipa/65270] " rguenth at gcc dot gnu.org 2015-03-02 11:50 ` rguenth at gcc dot gnu.org 2015-03-02 14:32 ` rguenth at gcc dot gnu.org 2015-03-02 14:51 ` rguenth at gcc dot gnu.org 2015-03-02 18:25 ` hubicka at gcc dot gnu.org 2015-03-03 14:57 ` rguenther at suse dot de 2015-03-03 15:08 ` howarth at bromo dot med.uc.edu 2015-03-03 17:24 ` rguenther at suse dot de 2015-03-03 18:23 ` hubicka at gcc dot gnu.org 2015-03-03 20:38 ` hubicka at gcc dot gnu.org 2015-03-04 9:26 ` rguenth at gcc dot gnu.org 2015-03-04 9:45 ` rguenther at suse dot de 2015-03-04 10:35 ` rguenth at gcc dot gnu.org 2015-03-04 11:52 ` rguenth at gcc dot gnu.org 2015-03-04 11:57 ` rguenth at gcc dot gnu.org 2015-03-04 18:21 ` hubicka at gcc dot gnu.org 2015-03-05 0:11 ` hubicka at gcc dot gnu.org 2015-03-05 0:21 ` hubicka at gcc dot gnu.org [this message] 2015-03-05 0:42 ` hubicka at gcc dot gnu.org 2015-03-05 8:43 ` rguenth at gcc dot gnu.org 2015-03-05 9:40 ` rguenther at suse dot de 2015-03-05 9:42 ` rguenther at suse dot de 2015-03-05 9:45 ` rguenther at suse dot de 2015-03-05 11:30 ` marxin at gcc dot gnu.org 2015-03-05 19:47 ` [Bug ipa/65270] issues with merging memory accesses from different code paths hubicka at gcc dot gnu.org 2015-03-05 19:59 ` hubicka at gcc dot gnu.org 2015-03-05 20:11 ` hubicka at gcc dot gnu.org 2015-03-05 21:18 ` hubicka at gcc dot gnu.org 2015-03-06 8:32 ` rguenther at suse dot de 2015-03-06 15:41 ` hubicka at gcc dot gnu.org 2015-03-06 18:03 ` [Bug ipa/65270] [5 regression] " hubicka at gcc dot gnu.org 2015-03-09 11:11 ` rguenth at gcc dot gnu.org 2015-03-09 13:55 ` rguenth at gcc dot gnu.org 2015-03-09 13:55 ` rguenth at gcc dot gnu.org 2015-03-12 13:03 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-65270-4-cY4oMUOhoV@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).