From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23447 invoked by alias); 5 Mar 2015 00:21:52 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 23318 invoked by uid 48); 5 Mar 2015 00:21:46 -0000 From: "hubicka at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses Date: Thu, 05 Mar 2015 00:21:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at gcc dot gnu.org X-Bugzilla-Status: REOPENED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg00547.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #18 from Jan Hubicka --- Here is summary of my current understanding of remaining issues from my last weekend's audit. ICF specific: - ipa-icf-gimple.c needs to match dependence analysis Richard has propsed a patch for it, so I hope he will commit it tomorrow. - restrict flag may need to be matched when considering two references to variables being equal. Here I am waiting for Richards comment. I would propose matching restricts in compare_cgraph_references same way as we now compare vtables. non-ICF specific wrong codes - tree-vectorizer is picking up wrong alignment - fold-const.c's operands_equal_p probably needs same treatment for comparing mem-ref as ipa-icf-gimple has. I think in all cases one can construct testcase where tree-tail-merge would produce same incorrect merging as ipa-icf does. stuff that can wait for next stage1 - ipa-pure-const is probably wrong to check TYPE_NEEDS_CONSTRUCTION flag (something to fix for next stage1) - expand_builtin_classify_type can probably be dropped, because fold_classify_type prevails.