public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses
Date: Mon, 02 Mar 2015 18:25:00 -0000	[thread overview]
Message-ID: <bug-65270-4-p0a76N5T54@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65270-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270

--- Comment #5 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
Thanks for looking into this! I think this was just the most obvoious of TYPE
flags. Some more we need to look into:

Is the alias class compare enough to handle TYPE_RESTRICT?

We probably want to match TYPE_ADDR_SPACE of accesses as that affect codegen?

We apparently need to match TYPE_ATTRIBUTES on functions, because we check that
flags on calees so we can not freely redirect them. Will fix that.

Also I think TYPE_STRING_FLAG may affect expand_builtin_classify_type that
probably ought to be done at folding time during early opts?

TYPE_NEEDS_CONSTRUCTING is used by ipa-pure-const but I think the use is wrong
(i.e. if decl needs to be constructed we will drop the readonly flag)

TYPE_NONALIASED_COMPONENT seems to affect alias.c in some way.

TYPE_FINAL_P also can not be mixed in virtual tables.


  parent reply	other threads:[~2015-03-02 18:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-02  0:49 [Bug ipa/65270] New: " hubicka at gcc dot gnu.org
2015-03-02  8:58 ` [Bug ipa/65270] " rguenth at gcc dot gnu.org
2015-03-02 11:50 ` rguenth at gcc dot gnu.org
2015-03-02 14:32 ` rguenth at gcc dot gnu.org
2015-03-02 14:51 ` rguenth at gcc dot gnu.org
2015-03-02 18:25 ` hubicka at gcc dot gnu.org [this message]
2015-03-03 14:57 ` rguenther at suse dot de
2015-03-03 15:08 ` howarth at bromo dot med.uc.edu
2015-03-03 17:24 ` rguenther at suse dot de
2015-03-03 18:23 ` hubicka at gcc dot gnu.org
2015-03-03 20:38 ` hubicka at gcc dot gnu.org
2015-03-04  9:26 ` rguenth at gcc dot gnu.org
2015-03-04  9:45 ` rguenther at suse dot de
2015-03-04 10:35 ` rguenth at gcc dot gnu.org
2015-03-04 11:52 ` rguenth at gcc dot gnu.org
2015-03-04 11:57 ` rguenth at gcc dot gnu.org
2015-03-04 18:21 ` hubicka at gcc dot gnu.org
2015-03-05  0:11 ` hubicka at gcc dot gnu.org
2015-03-05  0:21 ` hubicka at gcc dot gnu.org
2015-03-05  0:42 ` hubicka at gcc dot gnu.org
2015-03-05  8:43 ` rguenth at gcc dot gnu.org
2015-03-05  9:40 ` rguenther at suse dot de
2015-03-05  9:42 ` rguenther at suse dot de
2015-03-05  9:45 ` rguenther at suse dot de
2015-03-05 11:30 ` marxin at gcc dot gnu.org
2015-03-05 19:47 ` [Bug ipa/65270] issues with merging memory accesses from different code paths hubicka at gcc dot gnu.org
2015-03-05 19:59 ` hubicka at gcc dot gnu.org
2015-03-05 20:11 ` hubicka at gcc dot gnu.org
2015-03-05 21:18 ` hubicka at gcc dot gnu.org
2015-03-06  8:32 ` rguenther at suse dot de
2015-03-06 15:41 ` hubicka at gcc dot gnu.org
2015-03-06 18:03 ` [Bug ipa/65270] [5 regression] " hubicka at gcc dot gnu.org
2015-03-09 11:11 ` rguenth at gcc dot gnu.org
2015-03-09 13:55 ` rguenth at gcc dot gnu.org
2015-03-09 13:55 ` rguenth at gcc dot gnu.org
2015-03-12 13:03 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65270-4-p0a76N5T54@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).