* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
@ 2015-03-02 13:39 ` burnus at gcc dot gnu.org
2015-03-02 13:51 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: burnus at gcc dot gnu.org @ 2015-03-02 13:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Created attachment 34920
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34920&action=edit
File "two.ii" - compile with -O2 (g++ -w -c -flto -O2 -std=c++11 two.ii)
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
2015-03-02 13:39 ` [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462 burnus at gcc dot gnu.org
@ 2015-03-02 13:51 ` rguenth at gcc dot gnu.org
2015-03-02 16:31 ` aldyh at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-03-02 13:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Target Milestone|--- |5.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
2015-03-02 13:39 ` [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462 burnus at gcc dot gnu.org
2015-03-02 13:51 ` rguenth at gcc dot gnu.org
@ 2015-03-02 16:31 ` aldyh at gcc dot gnu.org
2015-03-02 17:30 ` hubicka at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: aldyh at gcc dot gnu.org @ 2015-03-02 16:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2015-03-02
CC| |aldyh at gcc dot gnu.org
Assignee|unassigned at gcc dot gnu.org |aldyh at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Confirmed. I'll take a look.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
` (2 preceding siblings ...)
2015-03-02 16:31 ` aldyh at gcc dot gnu.org
@ 2015-03-02 17:30 ` hubicka at gcc dot gnu.org
2015-03-02 17:47 ` aldyh at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: hubicka at gcc dot gnu.org @ 2015-03-02 17:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I guess it is the case where one type come from -O0 unit and have no
TYPE_BINFO, because it is not optimized. I think just removing the check may
work these days - I changed the way leading candidate is chosen and it should
be one with BINFO after all.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
` (3 preceding siblings ...)
2015-03-02 17:30 ` hubicka at gcc dot gnu.org
@ 2015-03-02 17:47 ` aldyh at gcc dot gnu.org
2015-03-02 17:53 ` hubicka at ucw dot cz
` (2 subsequent siblings)
7 siblings, 0 replies; 8+ messages in thread
From: aldyh at gcc dot gnu.org @ 2015-03-02 17:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #3)
> I guess it is the case where one type come from -O0 unit and have no
> TYPE_BINFO, because it is not optimized. I think just removing the check may
> work these days - I changed the way leading candidate is chosen and it
> should be one with BINFO after all.
Correct, TYPE_BINFO(type2) is NULL.
Started with:
commit 87a9c1b6624ae11321799e7c9aba4a7b47567d5d
Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Mon Feb 9 20:34:18 2015 +0000
* ipa-devirt.c (odr_types_equivalent_p): Fix formating.
(add_type_duplicate): Fix comparison of BINFOs.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@220546
138bc75d-0d04-0410-96
1f-82ee72b054a4
I can post a patch.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
` (4 preceding siblings ...)
2015-03-02 17:47 ` aldyh at gcc dot gnu.org
@ 2015-03-02 17:53 ` hubicka at ucw dot cz
2015-03-02 18:44 ` aldyh at gcc dot gnu.org
2015-03-02 18:46 ` aldyh at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: hubicka at ucw dot cz @ 2015-03-02 17:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
--- Comment #5 from Jan Hubicka <hubicka at ucw dot cz> ---
> Correct, TYPE_BINFO(type2) is NULL.
>
> Started with:
>
> commit 87a9c1b6624ae11321799e7c9aba4a7b47567d5d
> Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date: Mon Feb 9 20:34:18 2015 +0000
>
> * ipa-devirt.c (odr_types_equivalent_p): Fix formating.
> (add_type_duplicate): Fix comparison of BINFOs.
Yep, previously we would have false positive about base mismatch.
>
>
> git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@220546
> 138bc75d-0d04-0410-96
> 1f-82ee72b054a4
>
> I can post a patch.
That would be nice, patch is preaproved (with the testcase) if it passes
testing.
Honza
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
` (5 preceding siblings ...)
2015-03-02 17:53 ` hubicka at ucw dot cz
@ 2015-03-02 18:44 ` aldyh at gcc dot gnu.org
2015-03-02 18:46 ` aldyh at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: aldyh at gcc dot gnu.org @ 2015-03-02 18:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Author: aldyh
Date: Mon Mar 2 18:43:56 2015
New Revision: 221121
URL: https://gcc.gnu.org/viewcvs?rev=221121&root=gcc&view=rev
Log:
PR lto/65276
* ipa-devirt.c (add_type_duplicate): Remove odr_violated assert
when checking TYPE_BINFO.
Added:
trunk/gcc/testsuite/g++.dg/lto/pr65276_0.C
trunk/gcc/testsuite/g++.dg/lto/pr65276_1.C
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ipa-devirt.c
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462
[not found] <bug-65276-4@http.gcc.gnu.org/bugzilla/>
` (6 preceding siblings ...)
2015-03-02 18:44 ` aldyh at gcc dot gnu.org
@ 2015-03-02 18:46 ` aldyh at gcc dot gnu.org
7 siblings, 0 replies; 8+ messages in thread
From: aldyh at gcc dot gnu.org @ 2015-03-02 18:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Fixed on mainline.
Thanks for the analysis and approval Honza.
^ permalink raw reply [flat|nested] 8+ messages in thread