[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Created attachment 34920
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34920&action=edit
File "two.ii" - compile with -O2 (g++ -w -c -flto -O2 -std=c++11 two.ii)

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
   Target Milestone|---                         |5.0

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-03-02
                 CC|                            |aldyh at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |aldyh at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Confirmed.  I'll take a look.

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[hubicka at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

--- Comment #3 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I guess it is the case where one type come from -O0 unit and have no
TYPE_BINFO, because it is not optimized. I think just removing the check may
work these days - I changed the way leading candidate is chosen and it should
be one with BINFO after all.

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Jan Hubicka from comment #3)
> I guess it is the case where one type come from -O0 unit and have no
> TYPE_BINFO, because it is not optimized. I think just removing the check may
> work these days - I changed the way leading candidate is chosen and it
> should be one with BINFO after all.

Correct, TYPE_BINFO(type2) is NULL.

Started with:

commit 87a9c1b6624ae11321799e7c9aba4a7b47567d5d
Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Mon Feb 9 20:34:18 2015 +0000

        * ipa-devirt.c (odr_types_equivalent_p): Fix formating.
        (add_type_duplicate): Fix comparison of BINFOs.


    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@220546
138bc75d-0d04-0410-96
1f-82ee72b054a4

I can post a patch.

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

--- Comment #5 from Jan Hubicka <hubicka at ucw dot cz> ---
> Correct, TYPE_BINFO(type2) is NULL.
> 
> Started with:
> 
> commit 87a9c1b6624ae11321799e7c9aba4a7b47567d5d
> Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date:   Mon Feb 9 20:34:18 2015 +0000
> 
>         * ipa-devirt.c (odr_types_equivalent_p): Fix formating.
>         (add_type_duplicate): Fix comparison of BINFOs.

Yep, previously we would have false positive about base mismatch.
> 
> 
>     git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@220546
> 138bc75d-0d04-0410-96
> 1f-82ee72b054a4
> 
> I can post a patch.

That would be nice, patch is preaproved (with the testcase) if it passes
testing.

Honza

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Author: aldyh
Date: Mon Mar  2 18:43:56 2015
New Revision: 221121

URL: https://gcc.gnu.org/viewcvs?rev=221121&root=gcc&view=rev
Log:
    PR lto/65276
    * ipa-devirt.c (add_type_duplicate): Remove odr_violated assert
    when checking TYPE_BINFO.

Added:
    trunk/gcc/testsuite/g++.dg/lto/pr65276_0.C
    trunk/gcc/testsuite/g++.dg/lto/pr65276_1.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ipa-devirt.c

[Bug lto/65276] [5 Regression] LTO: ICE add_type_duplicate, at ipa-devirt.c:1462

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65276

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Fixed on mainline.

Thanks for the analysis and approval Honza.