[Bug target/65278] New: [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[Bug target/65278] New: [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

            Bug ID: 65278
           Summary: [5 Regression] ICE (in output_718, at
                    config/rs6000/rs6000.md:11592) on powerpc-linux-gnu
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org

r221115 on powerpc-linux-gnu

$ g++ -c -g -O2 -fPIC DistanceEstimation.ii 
DistanceEstimation.ii: In member function 'virtual double
B::_ZTv0_n12_NK1B5m_fn1ERKiS1_(const int&, const int&) const':
DistanceEstimation.ii:14:42: internal compiler error: in output_718, at
config/rs6000/rs6000.md:11592
 TwoTreeLikelihood::~TwoTreeLikelihood() {}
                                          ^
Please submit a full bug report,
with preprocessed source if appropriate.

$ cat DistanceEstimation.ii 
class A {
  virtual double m_fn1(const int &, const int &) const;
  int d2f_variable1;
  int d2f_variable2;
  virtual double m_fn2() { m_fn1(d2f_variable1, d2f_variable2); }
};
class B : virtual A {
  double m_fn1(const int &, const int &) const { return 0; }
};
class TwoTreeLikelihood : A {
  ~TwoTreeLikelihood();
  double m_fn1(const int &, const int &) const { return 0; }
};
TwoTreeLikelihood::~TwoTreeLikelihood() {}

[Bug target/65278] [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug target/65278] [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aldyh at gcc dot gnu.org

--- Comment #1 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Cannot reproduce.  Is this 32-bit ppc?  I can't reproduce on a cross build,
running cc1plus.  Are there any special options being passed to cc1plus (check
by passing -v to g++)?

[Bug target/65278] [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

--- Comment #2 from Matthias Klose <doko at gcc dot gnu.org> ---
yes, 32bit powerpc,

/usr/lib/gcc/powerpc-linux-gnu/5/cc1plus -fpreprocessed DistanceEstimation.ii
-msecure-plt -quiet -dumpbase DistanceEstimation.ii -auxbase DistanceEstimation
-g -O2 -version -fPIC -fstack-protector-strong -Wformat -Wformat-security -o
/tmp/ccYUSH7u.s

[Bug target/65278] [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

--- Comment #3 from Matthias Klose <doko at gcc dot gnu.org> ---
Created attachment 34924
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34924&action=edit
preprocessed source

this is the unreduced source

[Bug target/65278] [5 Regression] ICE (in output_718, at config/rs6000/rs6000.md:11592) on powerpc-linux-gnu

[aldyh at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

--- Comment #4 from Aldy Hernandez <aldyh at redhat dot com> ---
On 03/02/2015 08:30 AM, doko at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278
>
> --- Comment #2 from Matthias Klose <doko at gcc dot gnu.org> ---
> yes, 32bit powerpc,
>
> /usr/lib/gcc/powerpc-linux-gnu/5/cc1plus -fpreprocessed DistanceEstimation.ii
> -msecure-plt -quiet -dumpbase DistanceEstimation.ii -auxbase DistanceEstimation
> -g -O2 -version -fPIC -fstack-protector-strong -Wformat -Wformat-security -o
> /tmp/ccYUSH7u.s
>

Still can't reproduce, even with the un-preprocessed source.

[Bug target/65278] [5 Regression] ICE on powerpc{64}-linux-gnu

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-03-02
            Summary|[5 Regression] ICE (in      |[5 Regression] ICE on
                   |output_718, at              |powerpc{64}-linux-gnu
                   |config/rs6000/rs6000.md:115 |
                   |92) on powerpc-linux-gnu    |
     Ever confirmed|0                           |1

--- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Ouch.  Can't reproduce with a stage1 compiler, but a full bootstrapped compiler
on ppc64-linux-gnu issues the following:

[aldyh@gcc1-power7 gcc]$ ./cc1plus a.cc -O2 -quiet -fPIC  -g
a.cc: In member function ‘virtual double B::_ZTv0_n24_NK1B5m_fn1ERKiS1_(const
int&, const int&) const’:
a.cc:14:42: error: unrecognizable insn:
 TwoTreeLikelihood::~TwoTreeLikelihood() {}
                                          ^
(call_insn/j 5 4 6 (parallel [
            (call (mem:SI (symbol_ref/i:DI
("_ZNK17TwoTreeLikelihood5m_fn1ERKiS1_") [flags 0x1] <function_decl
0x3fffababc138 m_fn1>) [0  S4 A8])
                (const_int 0 [0]))
            (use (const_int 0 [0]))
            (use (reg:SI 65 lr))
            (simple_return)
        ]) a.cc:8 -1
     (nil)
    (nil))
a.cc:14:42: internal compiler error: in insn_min_length, at
config/rs6000/rs6000.md:7813
0x109943bb _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
    /home/aldyh/src/gcc/gcc/rtl-error.c:110
0x1099440f _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
    /home/aldyh/src/gcc/gcc/rtl-error.c:118
0x10dc3a3b insn_min_length(rtx_insn*)
    /home/aldyh/src/gcc/gcc/config/rs6000/rs6000.md:7813
0x10688bdb shorten_branches(rtx_insn*)
    /home/aldyh/src/gcc/gcc/final.c:1221
0x10d7ca1b rs6000_output_mi_thunk
    /home/aldyh/src/gcc/gcc/config/rs6000/rs6000.c:25840
0x1057483b cgraph_node::expand_thunk(bool, bool)
    /home/aldyh/src/gcc/gcc/cgraphunit.c:1555
0x10575d83 cgraph_node::assemble_thunks_and_aliases()
    /home/aldyh/src/gcc/gcc/cgraphunit.c:1816
0x1057610f cgraph_node::expand()
    /home/aldyh/src/gcc/gcc/cgraphunit.c:1941
0x10577ea7 expand_all_functions
    /home/aldyh/src/gcc/gcc/cgraphunit.c:2014
0x10577ea7 symbol_table::compile()
    /home/aldyh/src/gcc/gcc/cgraphunit.c:2367
0x1057a587 symbol_table::compile()
    /home/aldyh/src/gcc/gcc/cgraphunit.c:2447
0x1057a587 symbol_table::finalize_compilation_unit()
    /home/aldyh/src/gcc/gcc/cgraphunit.c:2444
0x102b90f3 cp_write_global_declarations()
    /home/aldyh/src/gcc/gcc/cp/decl2.c:4754
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
>From gcc-bugs-return-479057-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Mon Mar 02 21:24:00 2015
Return-Path: <gcc-bugs-return-479057-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 26650 invoked by alias); 2 Mar 2015 21:23:59 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 26580 invoked by uid 48); 2 Mar 2015 21:23:56 -0000
From: "aldyh at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/65278] [5 Regression] ICE on powerpc{64}-linux-gnu
Date: Mon, 02 Mar 2015 21:23:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: aldyh at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: aldyh at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: assigned_to
Message-ID: <bug-65278-4-U7qQTXsnZL@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65278-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65278-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-03/txt/msg00201.txt.bz2
Content-length: 403

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide278

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |aldyh at gcc dot gnu.org

--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
I'll take a look.

[Bug target/65278] [5 Regression] ICE on powerpc{64}-linux-gnu

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING
                 CC|                            |dje at gcc dot gnu.org,
                   |                            |hubicka at gcc dot gnu.org

--- Comment #7 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
I take it back, this is entirely reproducible from a cross build, but to
powerpc64-linux-gnu.

This is an unrecognizable insn in the PPC backend:

(call_insn/j 5 4 6 (parallel [
            (call (mem:SI (symbol_ref/i:DI
("_ZNK17TwoTreeLikelihood5m_fn1ERKiS1_") [flags 0x1] <function_decl
0x3fffababc138 m_fn1>) [0  S4 A8])
                (const_int 0 [0]))
            (use (const_int 0 [0]))
            (use (reg:SI 65 lr))
            (simple_return)
        ]) a.cc:8 -1
     (nil)
    (nil))

Presumably this wants to match the following, but the symbol_ref is not in the
current file (current_file_function_operand predicate)??:

(define_insn "*sibcall_local64"
  [(call (mem:SI (match_operand:DI 0 "current_file_function_operand" "s,s"))
     (match_operand 1 "" "g,g"))
   (use (match_operand:SI 2 "immediate_operand" "O,n"))
   (use (reg:SI LR_REGNO))
   (simple_return)]
  "TARGET_64BIT && (INTVAL (operands[2]) & CALL_LONG) == 0"

This started happening with Honza's patch (below).

The offending insn gets created in rs6000_output_mi_thunk, but without the
patch there are no thunks, so this function doesn't even get called.

Perhaps either Honza or David can comment on what needs to happen here, whether
the icf code needs to be tweaked, or a non-local insn needs to be added to the
ppc backend.

commit ce7711dff63867c071494efec46da4f8b973f27d
Author: hubicka <hubicka@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Fri Feb 27 02:06:48 2015 +0000

        PR bootstrap/65150
        * ipa-icf.c (symbol_compare_collection::symbol_compare_colleciton):
        Use address_matters_p.
        (redirect_all_callers, set_addressable): New functions.
        (sem_function::merge): Reorganize and fix merging issues.
        (sem_variable::merge): Likewise.
        (sem_variable::compare_sections): Remove.
        * common.opt (fmerge-all-constants, fmerge-constants): Remove
        Optimization flag.
        * symtab.c (symtab_node::resolve_alias): When alias has aliases,
        redirect them.
        (symtab_node::make_decl_local): Set ADDRESSABLE bit when
        decl is used.
        (address_matters_1): New function.
        (symtab_node::address_matters_p): New function.
        * cgraph.c (cgraph_edge::verify_corresponds_to_fndecl): Fix
        check for merged flag.
        * cgraph.h (address_matters_p): Declare.
        (symtab_node::address_taken_from_non_vtable_p): Remove.
        (symtab_node::address_can_be_compared_p): New method.
        (ipa_ref::address_matters_p): Move here from ipa-ref.c; simplify.
        * ipa-visibility.c (symtab_node::address_taken_from_non_vtable_p):
        Remove.
        (comdat_can_be_unshared_p_1) Use address_matters_p.
        (update_vtable_references): Fix formating.
        * ipa-ref.c (ipa_ref::address_matters_p): Move inline.
        * cgraphunit.c (cgraph_node::create_wrapper): Drop UNINLINABLE flag.
        * cgraphclones.c: Preserve merged and icf_merged flags.


    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@221040
138bc75d-0d04-0410-96

[Bug target/65278] [5 Regression] ICE on powerpc{64}-linux-gnu

[hubicka at ucw dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

--- Comment #8 from Jan Hubicka <hubicka at ucw dot cz> ---
> The offending insn gets created in rs6000_output_mi_thunk, but without the
> patch there are no thunks, so this function doesn't even get called.
> 
> Perhaps either Honza or David can comment on what needs to happen here, whether
> the icf code needs to be tweaked, or a non-local insn needs to be added to the
> ppc backend.

ICF itself does not produce thunk (it uses the expand_thunk to make real RTL
wrappers, but it never uses the ASm machinery) so I suppose this may be a dup
of PR65263?

I can imagine that ICF merging actually keeps a real C++ tunk alive by
differences
of later optimizations and this thunk being redirected to externalsymbols. 
Does
the patch in PR65263 help?

Honza

[Bug target/65278] [5 Regression] ICE on powerpc{64}-linux-gnu

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65278

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #9 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Indeed, the patch in 65263 fixes it.  Thank you very much.

*** This bug has been marked as a duplicate of bug 65263 ***