[Bug c++/65292] Template function not emitted

[Bug c++/65292] Template function not emitted

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Why do you think this is an issue?

[Bug c++/65292] Template function not emitted

[raj.khem at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

--- Comment #2 from Khem Raj <raj.khem at gmail dot com> ---
(In reply to Andrew Pinski from comment #1)
> Why do you think this is an issue?

there is another file in same library where this file object resides which uses
this function and reports undefined symbol errors when linking. Has it been
inlined and thrown away ? then why the rest two were not. Anyway if there is a
plausible explanation of this behavior thats ok but I could not deduce it.

[Bug c++/65292] Template function not emitted

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Khem Raj from comment #2)
> there is another file in same library where this file object resides which
> uses this function and reports undefined symbol errors when linking.

Then you either need to include the definition of the function template in that
other file, or provide an explicit instantiation.

You can't just rely on an implicit instantiation being emitted in some other
.cpp file.

> Has it been inlined and thrown away ?

Yes.

> then why the rest two were not. 

Because the optimizer decided to optimize them differently.

[Bug c++/65292] Template function not emitted

[gnugcc at marino dot st]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

John Marino <gnugcc at marino dot st> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gnugcc at marino dot st

--- Comment #4 from John Marino <gnugcc at marino dot st> ---
Khem, I've also just discovered gcc-5 won't build webkit anymore.  If you have
already come up with a patch for libJavaScriptCore, could you share it here?

[Bug c++/65292] Template function not emitted

[raj.khem at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

--- Comment #5 from Khem Raj <raj.khem at gmail dot com> ---
(In reply to John Marino from comment #4)
> Khem, I've also just discovered gcc-5 won't build webkit anymore.  If you
> have already come up with a patch for libJavaScriptCore, could you share it
> here?

posted a patch here

https://bugreports.qt.io/browse/QTBUG-44829

[Bug c++/65292] Template function not emitted

[gnugcc at marino dot st]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

--- Comment #6 from John Marino <gnugcc at marino dot st> ---
Thanks Khem,

With your patch, webkit-qt5 continued to build on gcc7 (good news) but I did
not succeed with gcc-5.  The new error during linking is:

/usr/libexec/binutils224/elf/ld.bfd:
/wrkdirs/www/webkit-qt5/work/.build/Source/WebCore/release/libWebCore.a(MediaController.o):
relocation R_X86_64_PC32 against undefined hidden symbol
`_ZNK7WebCore16HTMLMediaElement8hasVideoEv' can not be used when making a
shared object
/usr/libexec/binutils224/elf/ld.bfd: final link failed: Bad value
Makefile.api:111: recipe for target '../lib/libQt5WebKit.so.5.3.2' failed

But libJavaScriptCore issue was fixed, thanks!

[Bug c++/65292] Template function not emitted

[gnugcc at marino dot st]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

--- Comment #7 from John Marino <gnugcc at marino dot st> ---
typo -- it was gcc 4.7, not gcc7 that succeeded.  (I say that to help answer
the question in the QT5 bug report)

[Bug c++/65292] Template function not emitted

[gnugcc at marino dot st]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65292

--- Comment #8 from John Marino <gnugcc at marino dot st> ---
As a final follow up, webkit-qt5 built on a March 8 version of gcc5 with no
changes from my previous attempt.  

Good news, thanks for the patch!
John