public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ian at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug go/65349] [5 Regression] go tool crashes, can't compile go code on 32bit linux systems
Date: Mon, 09 Mar 2015 23:41:00 -0000	[thread overview]
Message-ID: <bug-65349-4-wmWn5Iyd1e@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65349-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65349

--- Comment #1 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Mon Mar  9 23:40:58 2015
New Revision: 221291

URL: https://gcc.gnu.org/viewcvs?rev=221291&root=gcc&view=rev
Log:
    PR go/65349
runtime: Don't call malloc from __go_file_line callback.

When crashing, we call runtime_printcreatedby which calls
__go_file_line which used to call the Go malloc.  If we are
crashing due to a signal due to heap corruption of some sort,
the GO malloc lock might already be held, leading to a crash
within a crash.  Avoid that by assuming that the libbacktrace
strings will stick around, as we already do in go-callers.c.

Modified:
    trunk/libgo/runtime/go-caller.c


  parent reply	other threads:[~2015-03-09 23:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-08 15:41 [Bug go/65349] New: " doko at gcc dot gnu.org
2015-03-09 12:13 ` [Bug go/65349] " rguenth at gcc dot gnu.org
2015-03-09 14:35 ` jakub at gcc dot gnu.org
2015-03-09 23:41 ` ian at gcc dot gnu.org [this message]
2015-03-09 23:43 ` ian at gcc dot gnu.org
2015-03-09 23:44 ` ian at airs dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65349-4-wmWn5Iyd1e@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).