[Bug target/65351] New: [5 Regression] ld: absolute addressing (perhaps -mdynamic-no-pic) used in _byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o) not allowed ... on powerpc-apple-darwin9

[Bug target/65351] New: [5 Regression] ld: absolute addressing (perhaps -mdynamic-no-pic) used in _byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o) not allowed ... on powerpc-apple-darwin9

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

            Bug ID: 65351
           Summary: [5 Regression] ld: absolute addressing (perhaps
                    -mdynamic-no-pic) used in
                    _byte_common_op_match_null_string_p from
                    ../libiberty/pic/libiberty.a(regex.o) not allowed ...
                    on powerpc-apple-darwin9
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dominiq at lps dot ens.fr
              Host: powerpc-apple-darwin9
            Target: powerpc-apple-darwin9
             Build: powerpc-apple-darwin9

Boostrapping gcc on powerpc-apple-darwin9 fails with

libtool: link:  /opt/gcc/rel_build/./gcc/xg++ -B/opt/gcc/rel_build/./gcc/
-nostdinc++ -nostdinc++
-I/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/include/powerpc-apple-darwin9.8.0
-I/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/include
-I/opt/gcc/rel_work/libstdc++-v3/libsupc++
-I/opt/gcc/rel_work/libstdc++-v3/include/backward
-I/opt/gcc/rel_work/libstdc++-v3/testsuite/util
-L/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/src
-L/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/src/.libs
-L/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/libsupc++/.libs
-B/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/src/.libs
-B/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/libsupc++/.libs
-B/opt/gcc/gcc5.0r/powerpc-apple-darwin9.8.0/bin/
-B/opt/gcc/gcc5.0r/powerpc-apple-darwin9.8.0/lib/ -isystem
/opt/gcc/gcc5.0r/powerpc-apple-darwin9.8.0/include -isystem
/opt/gcc/gcc5.0r/powerpc-apple-darwin9.8.0/sys-include    -Wl,-undefined
-Wl,dynamic_lookup -o .libs/libcc1.0.so -bundle  .libs/findcomp.o
.libs/libcc1.o .libs/names.o .libs/callbacks.o .libs/connection.o
.libs/marshall.o  
-L/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/src
-L/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/src/.libs
-L/opt/gcc/rel_build/powerpc-apple-darwin9.8.0/libstdc++-v3/libsupc++/.libs 
-static-libstdc++ -static-libgcc ../libiberty/pic/libiberty.a  
-Wl,-exported_symbols_list,.libs/libcc1-symbols.expsym
ld: absolute addressing (perhaps -mdynamic-no-pic) used in
_byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o)
not allowed in slidable image. Use '-read_only_relocs suppress' to enable text
relocs
collect2: error: ld returned 1 exit status

[Bug target/65351] [5 Regression] ld: absolute addressing (perhaps -mdynamic-no-pic) used in _byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o) not allowed ... on powerpc-apple-darwin9

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|powerpc-apple-darwin9       |m32 *-apple-darwin*
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-03-08
                 CC|                            |iains at gcc dot gnu.org
               Host|powerpc-apple-darwin9       |m32 *-apple-darwin*
     Ever confirmed|0                           |1
              Build|powerpc-apple-darwin9       |m32 *-apple-darwin*

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
this affects all m32 Darwin, and has been "broken" since the pic version of
libiberty was added - but has only become noticed now this (pic libiberty) is
linked into libcc1.

[Bug target/65351] [5 Regression] ld: absolute addressing (perhaps -mdynamic-no-pic) used in _byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o) not allowed ... on powerpc-apple-darwin9

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
Patch posted at https://gcc.gnu.org/ml/gcc-patches/2015-02/msg00017.html.

[Bug target/65351] [5 Regression] ld: absolute addressing (perhaps -mdynamic-no-pic) used in _byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o) not allowed ... on powerpc-apple-darwin9

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug target/65351] [5 Regression] ld: absolute addressing (perhaps -mdynamic-no-pic) used in _byte_common_op_match_null_string_p from ../libiberty/pic/libiberty.a(regex.o) not allowed ... on powerpc-apple-darwin9

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 35174
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35174&action=edit
Patch addressing review comments

Will be posting this to @patches after some more checking.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
i686-apple-darwin is a secondary arch and supposedly (but not verified?)
affected.
A workaround is to disable building of libcc1 (but it's enabled by default it
seems).

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #4)
> i686-apple-darwin is a secondary arch and supposedly (but not verified?)
> affected.
> A workaround is to disable building of libcc1 (but it's enabled by default
> it seems).

i686-apple-darwin is affected, I will test the patch @comment #3 on linux and
then re-post (it is addressing iant's review comments).

The workaround is to disable -mdynamic-no-pic in BOOT_CFLAGS, but that's just
pretending that the problem doesn't exist, of course.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The patch looks wrong, but passing -mdynamic-no-pic in BOOT_CFLAGS for Darwin
is even more wrong.
BOOT_CFLAGS is feeding STAGE*_CFLAGS which is used to compile various stuff,
not just the compiler binary itself, and given that the flag is incompatible
with -fpic and some libraries are built with that, you just shouldn't pass that
down.
libcc1 isn't the only thing broken by that, I think --enable-host-shared will
fail miserably too on Darwin.
So, either config/mh-darwin should set some other variable (say
NONPIC_HOST_CFLAGS or whatever) to -mdynamic-no-pic and you should arrange for
it to be passed down as NONPIC_CFLAGS for modules being built for host, and
you'd use that in e.g.
 # Enable --enable-host-shared
 AC_ARG_ENABLE(host-shared,
 [AS_HELP_STRING([--enable-host-shared],
                 [build host code as shared libraries])],
-[PICFLAG=-fPIC], [PICFLAG=])
+[PICFLAG=-fPIC], [PICFLAG=$NONPIC_CFLAGS])
 AC_SUBST(enable_host_shared)
 AC_SUBST(PICFLAG)
(in gcc/ and libcpp/, perhaps elsewhere where performance criticial), or you
just not do it in config/mh-darwin, but in these two spots instead.
Really, passing some bogus flag down everywhere and then trying to remove it
again is just too weird.
Another option is to make sure you use -fPIC (or -fpic) together with
-mno-dynamic-no-pic on Darwin and that you pass it after the vars where
-mdynamic-no-pic is set, then tweak libiberty/pic, gcc & libcpp
--enable-host-shared etc. not to use that.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #7 from Iain Sandoe <iains at gcc dot gnu.org> ---
BOOT_CFLAGS has included -mdynamic-no-pic for a long time (before my time
here), so I'm not aware of what criteria were discussed then, however

-mdynamic-non-pic cannot be overridden by fPIC.

I don't have spare cycles to investigate a more fine-grained approach in the
short-term (although it seems like a reasonable way forward).

Anyway, in the light of comment #6 I'm abandoning this patch.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
But -mdynamic-no-pic can be overridden with -fPIC -mno-dynamic-no-pic , right?

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Does the following patch:

--- config/picflag.m4    2013-11-18 09:59:08.420212365 +0100
+++ config/picflag.m4    2015-03-31 18:36:21.989401000 +0200
@@ -9,7 +9,9 @@ case "${$2}" in
     *-*-darwin*)
     # PIC is the default on this platform
     # Common symbols not allowed in MH_DYLIB files
-    $1=-fno-common
+    # Cancel any earlier -mdynamic-no-pic, as that makes
+    # the code not suitable for shared libraries.
+    $1=-fno-common -mno-dynamic-no-pic
     ;;
     alpha*-dec-osf5*)
     # PIC is the default.

fix the libcc1 issue?

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35174|0                           |1
        is obsolete|                            |

--- Comment #11 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 35212
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35212&action=edit
minimum change

OK - So Jakub's patch works with a minor change (quote the two components) viz:

-    $1=-fno-common
+    $1='-fno-common -mno-dynamic-no-pic'


1. the minimum change to fix this bug is to reconfigure libiberty with the
changed picflag.m4 (the attached patch includes the regenerated
libiberty/configure so that folks can test if they like).
 -- Perhaps we should extend that to all cases where */configure.ac calls
GCC_PICFLAG (although it's not needed for this pr, it might save confusion when
someone subsequently reconfigures).

2. I investigated --enable-host-shared and this seems to be a can of worms.
 - some places in the GCC tree just don't consider the possibility that the
host/target might need pic options
 - most places just jam -fPIC regardless of the host.
 - if I go through all of these cases and add in GCC_PICFLAG /
GCC_PICFLAG_TARGET as appropriate I can get --enable-host-shared builds to
complete on m32 darwin (but it doesn't seem like stage4 change and isn't a
regression in any case).
 - Even on x86_64 linux I don't see --enable-host-shared producing any .so for
these host-side libs (it seems to just generate convenience libs with PIC
code).
 - It's possible that some other places should be linking the PIC version of
libiberty (e.g. libsupc++) …

- I need to test this minimum change on a couple more boxes.
>From gcc-bugs-return-482586-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 02 11:57:38 2015
Return-Path: <gcc-bugs-return-482586-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 27259 invoked by alias); 2 Apr 2015 11:57:38 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27193 invoked by uid 55); 2 Apr 2015 11:57:34 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug preprocessor/61977] [4.8/4.9/5 Regression] powerpc preprocessor breaks on lines that end with "vector"
Date: Thu, 02 Apr 2015 11:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: preprocessor
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.5
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61977-4-4njBcL1qO9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61977-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61977-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-04/txt/msg00138.txt.bz2
Content-length: 659

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida977

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Apr  2 11:57:02 2015
New Revision: 221839

URL: https://gcc.gnu.org/viewcvs?rev"1839&root=gcc&view=rev
Log:
    PR preprocessor/61977
    * lex.c (cpp_peek_token): Temporarily clear pfile->cb.line_change.

    * gcc.target/powerpc/pr61977-1.c: New test.
    * gcc.target/powerpc/pr61977-2.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/powerpc/pr61977-1.c
    trunk/gcc/testsuite/gcc.target/powerpc/pr61977-2.c
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libcpp/ChangeLog
    trunk/libcpp/lex.c

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Thanks for fixing that thinko.  Please regenerate not just libiberty/configure,
but also {gcc,libada,libgcc}/configure too.
The patch is ok for trunk with those changes with proper ChangeLog entry and
when posted to gcc-patches.
I agree --enable-host-shared for darwin can certainly wait for stage1 or for
whenever later anybody is actually interested in that on darwin.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So hopefully fixed now.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Jack Howarth <howarth.at.gcc at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |howarth.at.gcc at gmail dot com

--- Comment #15 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
(In reply to Jakub Jelinek from comment #14)
> So hopefully fixed now.

This breaks the bootstrap on darwin14 here...

make[3]: Entering directory
'/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/libiberty'
if [ x"-fno-common -mno-dynamic-no-pic" != x ]; then \
  gcc -c -DHAVE_CONFIG_H -g   -I. -I../../gcc-5-20150407/libiberty/../include 
-W -Wall -Wwrite-strings -Wc++-compat -Wstrict-prototypes -pedantic 
-fno-common -mno-dynamic-no-pic ../../gcc-5-20150407/libiberty/regex.c -o
pic/regex.o; \
else true; fi
clang: error: unknown argument: '-mno-dynamic-no-pic'
Makefile:1167: recipe for target 'regex.o' failed
make[3]: *** [regex.o] Error 1
make[3]: Leaving directory
'/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/libiberty'
Makefile:9585: recipe for target 'all-stage1-libiberty' failed
make[2]: *** [all-stage1-libiberty] Error 2
make[2]: Leaving directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir'
Makefile:20760: recipe for target 'stage1-bubble' failed
make[1]: *** [stage1-bubble] Error 2
make[1]: Leaving directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir'
Makefile:21064: recipe for target 'bootstrap' failed
make: *** [bootstrap] Error 2

The default system compiler (Apple Clang 6.0) doesn't understand
-mno-dynamic-no-pic.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #16 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jack Howarth from comment #15)
> (In reply to Jakub Jelinek from comment #14)
> > So hopefully fixed now.
> 
> This breaks the bootstrap on darwin14 here...
> 
> make[3]: Entering directory
> '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/libiberty'
> if [ x"-fno-common -mno-dynamic-no-pic" != x ]; then \
>   gcc -c -DHAVE_CONFIG_H -g   -I.
> -I../../gcc-5-20150407/libiberty/../include  -W -Wall -Wwrite-strings
> -Wc++-compat -Wstrict-prototypes -pedantic  -fno-common -mno-dynamic-no-pic
> ../../gcc-5-20150407/libiberty/regex.c -o pic/regex.o; \
> else true; fi
> clang: error: unknown argument: '-mno-dynamic-no-pic'
> Makefile:1167: recipe for target 'regex.o' failed
> make[3]: *** [regex.o] Error 1
> make[3]: Leaving directory
> '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir/libiberty'
> Makefile:9585: recipe for target 'all-stage1-libiberty' failed
> make[2]: *** [all-stage1-libiberty] Error 2
> make[2]: Leaving directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir'
> Makefile:20760: recipe for target 'stage1-bubble' failed
> make[1]: *** [stage1-bubble] Error 2
> make[1]: Leaving directory '/sw/src/fink.build/gcc5-5.0.0-1/darwin_objdir'
> Makefile:21064: recipe for target 'bootstrap' failed
> make: *** [bootstrap] Error 2
> 
> The default system compiler (Apple Clang 6.0) doesn't understand
> -mno-dynamic-no-pic.

hmm OK. that's going to make life difficult.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[howarth.at.gcc at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #17 from Jack Howarth <howarth.at.gcc at gmail dot com> ---
Can you revert r221891?

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35212|0                           |1
        is obsolete|                            |

--- Comment #18 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 35249
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35249&action=edit
patch under test.

treats m32 darwin as distinct from m64,

Since -mdynamic=no-pic is not used for the bootstrap compiler, this should
still work to bootstrap i686-darwin* with clang.

Testing on x86_64=darwin13 (with clang bootstrap) and on powerpc-darwin9 (GCC
bootstrap).

really, clang should respond properly to the inverse of -mdynamic-no-pic (will
try to cook up a patch for that tomorrow).

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #19 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #18)
> Created attachment 35249 [details]
> patch under test.
> 

> Since -mdynamic=no-pic is not used for the bootstrap compiler, this should
> still work to bootstrap i686-darwin* with clang.

this isn't correct on reflection, since the cancelling flag will be emitted at
stage1 as well.

However, as an interim solution it will allow default bootstraps to complete
while we find a wider fix.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #20 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
x86_64-darwin doesn't add -mdynamic-no-pic, so it is indeed not needed to add
-mno-dynamic-no-pic for it.  I've been wondering about that, but then checked
that gcc supports -mno-dynamic-no-pic even there.
So, does clang support -mno-dynamic-no-pic at least on i686 and powerpc 32-bit?
Or do we need to check for it in the config/picflag.m4 snippet?  Though, if it
doesn't support -mno-dynamic-no-pic, is there any way how to cancel that flag
in clang?

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #21 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Another option is not to add -mdynamic-no-pic for clang and other compilers
that don't support -mno-dynamic-no-pic.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #22 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #21)
> Another option is not to add -mdynamic-no-pic for clang and other compilers
> that don't support -mno-dynamic-no-pic.

clang supports (and generates appropriate code for) -mdynamic-no-pic.
as wee see (at present) it doesn't support -mno-dynamic-no-pic [(In reply to
Jakub Jelinek from comment #21)
> Another option is not to add -mdynamic-no-pic for clang and other compilers
> that don't support -mno-dynamic-no-pic.

Yeah, that seems like the safest bet :-(.
(will try to get a patch together to fix future clang versions, but that won't
alter the ones out in the wild).

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #23 from Iain Sandoe <iains at gcc dot gnu.org> ---
something like this 

dnl Check if the current compiler supports -mno-dynamic-no-pic.
AC_DEFUN([GCC_CHECK_FLAG_NO_DYNAMIC_NO_PIC], [
  AC_CACHE_CHECK([whether the current compiler supports -mno-dynamic-no-pic],
         ac_cv_have_mno_dynamic_no_pic, [
  mno_dynamic_no_pic_saved_CFLAGS="$CFLAGS"
  CFLAGS="$CFLAGS -mno-dynamic-no-pic"
  AC_TRY_COMPILE([void foo(void) { }],
         [], ac_cv_have_mno_dynamic_no_pic=yes,
         ac_cv_have_mno_dynamic_no_pic=no)
  CFLAGS="$mno_dynamic_no_pic_saved_CFLAGS"])
  if test x"$ac_cv_have_mno_dynamic_no_pic" = xyes; then
    MDYNAMIC_NO_PIC=-mdynamic-no-pic
    MNO_DYNAMIC_NO_PIC=-mno-dynamic-no-pic
  else
    MDYNAMIC_NO_PIC=
    MNO_DYNAMIC_NO_PIC=
  fi])

but .. the results need to be available to the mh-darwin

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #24 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
So perhaps for the top level something like:
--- config/mh-darwin    2013-09-30 22:13:57.243907474 +0200
+++ config/mh-darwin    2015-04-08 10:36:58.100665592 +0200
@@ -1,18 +1,29 @@
 # The -mdynamic-no-pic ensures that the compiler executable is built without
 # position-independent-code -- the usual default on Darwin. This fix speeds
-# compiles by 3-5%.
-BOOT_CFLAGS += \
+# compiles by 3-5%.  Don't add it if the compiler doesn't also support
+# -mno-dynamic-no-pic to undo it.
+DARWIN_MDYNAMIC_NO_PIC := \
 `case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \
-                 echo -mdynamic-no-pic ;; esac;`
+   $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \
+   && echo -mdynamic-no-pic ;; esac`
+DARWIN_GCC_MDYNAMIC_NO_PIC := \
+`case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \
+   $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \
+   || echo -mdynamic-no-pic ;; esac`

 # ld on Darwin versions >= 10.7 defaults to PIE executables. Disable this for
 # gcc components, since it is incompatible with our pch implementation.
-BOOT_LDFLAGS += \
-`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
+DARWIN_NO_PIE := `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;;
esac;`
+
+BOOT_CFLAGS += $(DARWIN_MDYNAMIC_NO_PIC)
+BOOT_LDFLAGS += $(DARWIN_NO_PIE)

 # Similarly, for cross-compilation.
-STAGE1_CFLAGS += \
-`case ${host} in i?86-*-darwin* | powerpc-*-darwin*)\
-                 echo -mdynamic-no-pic ;; esac;`
-STAGE1_LDFLAGS += \
-`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
+STAGE1_CFLAGS += $(DARWIN_MDYNAMIC_NO_PIC)
+STAGE1_LDFLAGS += $(DARWIN_NO_PIE)
+
+# Without -mno-dynamic-no-pic support, add -mdynamic-no-pic just to later
+# stages when we know it is built with gcc.
+STAGE2_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC)
+STAGE3_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC)
+STAGE4_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC)

Thus, add -mdynamic-no-pic for gcc (or fixed clang) bootstrap compiler to
BOOT_CFLAGS and STAGE1_CFLAGS, but only to STAGE{2,3,4}_CFLAGS otherwise?

Then GCC_PICFLAG, being a configure snippet, can surely just use normal
autoconfy way.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #25 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #24)
> So perhaps for the top level something like:

yeah looks better than what i was drafting.

> --- config/mh-darwin	2013-09-30 22:13:57.243907474 +0200
> +++ config/mh-darwin	2015-04-08 10:36:58.100665592 +0200
> @@ -1,18 +1,29 @@
>  # The -mdynamic-no-pic ensures that the compiler executable is built without
>  # position-independent-code -- the usual default on Darwin. This fix speeds
> -# compiles by 3-5%.
> -BOOT_CFLAGS += \
> +# compiles by 3-5%.  Don't add it if the compiler doesn't also support
> +# -mno-dynamic-no-pic to undo it.
> +DARWIN_MDYNAMIC_NO_PIC := \
>  `case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \
> -                 echo -mdynamic-no-pic ;; esac;`
> +   $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \
> +   && echo -mdynamic-no-pic ;; esac`
> +DARWIN_GCC_MDYNAMIC_NO_PIC := \
> +`case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \
> +   $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \
> +   || echo -mdynamic-no-pic ;; esac`

I don't think we need the test here ^ ?

>  # ld on Darwin versions >= 10.7 defaults to PIE executables. Disable this
> for
>  # gcc components, since it is incompatible with our pch implementation.
> -BOOT_LDFLAGS += \
> -`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
> +DARWIN_NO_PIE := `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;;
> esac;`
> +
> +BOOT_CFLAGS += $(DARWIN_MDYNAMIC_NO_PIC)
> +BOOT_LDFLAGS += $(DARWIN_NO_PIE)
>  
>  # Similarly, for cross-compilation.
> -STAGE1_CFLAGS += \
> -`case ${host} in i?86-*-darwin* | powerpc-*-darwin*)\
> -                 echo -mdynamic-no-pic ;; esac;`
> -STAGE1_LDFLAGS += \
> -`case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;`
> +STAGE1_CFLAGS += $(DARWIN_MDYNAMIC_NO_PIC)
> +STAGE1_LDFLAGS += $(DARWIN_NO_PIE)
> +
> +# Without -mno-dynamic-no-pic support, add -mdynamic-no-pic just to later
> +# stages when we know it is built with gcc.
> +STAGE2_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC)
> +STAGE3_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC)
> +STAGE4_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC)
> 
> Thus, add -mdynamic-no-pic for gcc (or fixed clang) bootstrap compiler to
> BOOT_CFLAGS and STAGE1_CFLAGS, but only to STAGE{2,3,4}_CFLAGS otherwise?
> 
> Then GCC_PICFLAG, being a configure snippet, can surely just use normal
> autoconfy way.

well, GCC_PICFLAG is not really very autoconf-y at present, just a bunch of
tests of triple.  Will try to find some cycles later on.
>From gcc-bugs-return-482964-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Apr 08 09:27:52 2015
Return-Path: <gcc-bugs-return-482964-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 23626 invoked by alias); 8 Apr 2015 09:27:52 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 23590 invoked by uid 48); 8 Apr 2015 09:27:48 -0000
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/65422] [C++11] Rejected valid double expansion packs.
Date: Wed, 08 Apr 2015 09:27:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: mpolacek at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on cc everconfirmed
Message-ID: <bug-65422-4-QU9gOvpGyE@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65422-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65422-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-04/txt/msg00516.txt.bz2
Content-length: 480

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide422

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-04-08
                 CC|                            |mpolacek at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #26 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #25)
> > +DARWIN_GCC_MDYNAMIC_NO_PIC := \
> > +`case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \
> > +   $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \
> > +   || echo -mdynamic-no-pic ;; esac`
> 
> I don't think we need the test here ^ ?

I wanted to avoid adding -mdynamic-no-pic twice for the case when bootstrap
compiler is gcc (once in BOOT_CFLAGS, once in STAGE{2,3,4}_CFLAGS.
Sure, the test could be 
DARWIN_GCC_MDYNAMIC_NO_PIC := \
`case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \
   test -z "$(DARWIN_MDYNAMIC_NO_PIC)" && echo -mdynamic-no-pic ;; esac`
instead or similar.

> > Thus, add -mdynamic-no-pic for gcc (or fixed clang) bootstrap compiler to
> > BOOT_CFLAGS and STAGE1_CFLAGS, but only to STAGE{2,3,4}_CFLAGS otherwise?
> > 
> > Then GCC_PICFLAG, being a configure snippet, can surely just use normal
> > autoconfy way.
> 
> well, GCC_PICFLAG is not really very autoconf-y at present, just a bunch of
> tests of triple.  Will try to find some cycles later on.

What I meant is that it is processed by autoconf.
Anyway, perhaps an alternative would be to just add -mdynamic-no-pic if
-mdynamic-no-pic is in CFLAGS.
Like
  $1=-fno-common
  case "${CFLAGS}" in *-mdynamic-no-pic*) \
    $1='-fno-common -mno-dynamic no-pic';; esac
in config/picflag.m4 ?
Needs verification that -mdynamic-no-pic is really in CFLAGS when it should and
not when it should not be.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35249|0                           |1
        is obsolete|                            |

--- Comment #27 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 35255
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35255&action=edit
patch against 221916


Jakub's suggested approach to picflag.m4 seems reasonable.
AFAIK, the only place that GCC adds the flag is in mh-darwin which is now
checked.

If someone building GCC passes "-mdynamic-no-pic" on the command line for (say)
an i686-darwin12 native cross with clang as the compiler - then it will,
presumably, fail but that's something easy for the person doing the build to
rectify (and someone building native crosses is probably not a novice anyway)


checking on powerpc-darwin9 (GCC 5 bootstrap) x86_64-darwin12 (gcc 5 bootstrap)
x86_64-darwin13 (clang XCode6 bootstrap) i686-darwin10 (gcc-4.2.1 bootstrap).

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #28 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I have successfully  bootstrapped r221917 on x86_64-apple-darwin14 with the
patch in comment 27.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #29 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #27)
> Created attachment 35255 [details]

> checking on powerpc-darwin9 (GCC 5 bootstrap) x86_64-darwin12 (gcc 5
> bootstrap) x86_64-darwin13 (clang XCode6 bootstrap) i686-darwin10 (gcc-4.2.1
> bootstrap).

these all completed ok and sanity-checks seem reasonable.

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #30 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #29)
> (In reply to Iain Sandoe from comment #27)
> > Created attachment 35255 [details]
> 
> > checking on powerpc-darwin9 (GCC 5 bootstrap) x86_64-darwin12 (gcc 5
> > bootstrap) x86_64-darwin13 (clang XCode6 bootstrap) i686-darwin10 (gcc-4.2.1
> > bootstrap).
> 
> these all completed ok and sanity-checks seem reasonable.

Thanks for testing it.  Will you post the patch, or shall I?

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #31 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #30)
> (In reply to Iain Sandoe from comment #29)
> > (In reply to Iain Sandoe from comment #27)
> > > Created attachment 35255 [details]
> > 
> > > checking on powerpc-darwin9 (GCC 5 bootstrap) x86_64-darwin12 (gcc 5
> > > bootstrap) x86_64-darwin13 (clang XCode6 bootstrap) i686-darwin10 (gcc-4.2.1
> > > bootstrap).
> > 
> > these all completed ok and sanity-checks seem reasonable.
> 
> Thanks for testing it.  Will you post the patch, or shall I?

Posted:
https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00382.html

FWIW: I also posted a fix for the clang driver:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150406/127137.html

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

--- Comment #32 from Iain Sandoe <iains at gcc dot gnu.org> ---
Author: iains
Date: Fri Apr 10 06:43:52 2015
New Revision: 221967

URL: https://gcc.gnu.org/viewcvs?rev=221967&root=gcc&view=rev
Log:
    PR target/65351
config/
    * mh-darwin: Only apply -mdynamic-no-pic for m32 Darwin when the compiler
in
    use supports -mno-dynamic-no-pic.
    * picflag.m4: Only append -mno-dynamic-no-pic for Darwin when
-mdynamic-no-pic
    is present in CFLAGS.

libiberty/
    * configure: Regenerate.
libada/
    * configure: Regenerate.
libgcc/
    * configure: Regenerate.
gcc/
    * configure: Regenerate.


Modified:
    trunk/config/ChangeLog
    trunk/config/mh-darwin
    trunk/config/picflag.m4
    trunk/gcc/ChangeLog
    trunk/gcc/configure
    trunk/libada/ChangeLog
    trunk/libada/configure
    trunk/libgcc/ChangeLog
    trunk/libgcc/configure
    trunk/libiberty/ChangeLog
    trunk/libiberty/configure

[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #33 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Hopefully fixed now.