[Bug target/65351] [5 Regression] libiberty's pic version contains non-pic code on m32 darwin; causes bootstrap fail building libcc1.

["iains at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65351

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #35174|0                           |1
        is obsolete|                            |

--- Comment #11 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 35212
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35212&action=edit
minimum change

OK - So Jakub's patch works with a minor change (quote the two components) viz:

-    $1=-fno-common
+    $1='-fno-common -mno-dynamic-no-pic'


1. the minimum change to fix this bug is to reconfigure libiberty with the
changed picflag.m4 (the attached patch includes the regenerated
libiberty/configure so that folks can test if they like).
 -- Perhaps we should extend that to all cases where */configure.ac calls
GCC_PICFLAG (although it's not needed for this pr, it might save confusion when
someone subsequently reconfigures).

2. I investigated --enable-host-shared and this seems to be a can of worms.
 - some places in the GCC tree just don't consider the possibility that the
host/target might need pic options
 - most places just jam -fPIC regardless of the host.
 - if I go through all of these cases and add in GCC_PICFLAG /
GCC_PICFLAG_TARGET as appropriate I can get --enable-host-shared builds to
complete on m32 darwin (but it doesn't seem like stage4 change and isn't a
regression in any case).
 - Even on x86_64 linux I don't see --enable-host-shared producing any .so for
these host-side libs (it seems to just generate convenience libs with PIC
code).
 - It's possible that some other places should be linking the PIC version of
libiberty (e.g. libsupc++) …

- I need to test this minimum change on a couple more boxes.
>From gcc-bugs-return-482586-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Thu Apr 02 11:57:38 2015
Return-Path: <gcc-bugs-return-482586-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 27259 invoked by alias); 2 Apr 2015 11:57:38 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 27193 invoked by uid 55); 2 Apr 2015 11:57:34 -0000
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug preprocessor/61977] [4.8/4.9/5 Regression] powerpc preprocessor breaks on lines that end with "vector"
Date: Thu, 02 Apr 2015 11:57:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: preprocessor
X-Bugzilla-Version: 4.9.1
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.5
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-61977-4-4njBcL1qO9@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-61977-4@http.gcc.gnu.org/bugzilla/>
References: <bug-61977-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-04/txt/msg00138.txt.bz2
Content-length: 659

https://gcc.gnu.org/bugzilla/show_bug.cgi?ida977

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Author: jakub
Date: Thu Apr  2 11:57:02 2015
New Revision: 221839

URL: https://gcc.gnu.org/viewcvs?rev"1839&root=gcc&view=rev
Log:
    PR preprocessor/61977
    * lex.c (cpp_peek_token): Temporarily clear pfile->cb.line_change.

    * gcc.target/powerpc/pr61977-1.c: New test.
    * gcc.target/powerpc/pr61977-2.c: New test.

Added:
    trunk/gcc/testsuite/gcc.target/powerpc/pr61977-1.c
    trunk/gcc/testsuite/gcc.target/powerpc/pr61977-2.c
Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/libcpp/ChangeLog
    trunk/libcpp/lex.c