[Bug go/65353] New: [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[Bug go/65353] New: [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

            Bug ID: 65353
           Summary: [5 Regression] unknown ptrSize for $GOARCH "arm64" on
                    aarch64-linux-gnu
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: go
          Assignee: ian at airs dot com
          Reporter: doko at gcc dot gnu.org
                CC: cmang at google dot com

$ go tool cgo -godefs types.go
unknown ptrSize for $GOARCH "arm64"

with a separately built go tool (1.2), built using gccgo-4.9, this works as
expected.

filing this as a regression for now.

$ cat types.go 
// +build ignore

package pty

import "C"

type (
        _C_int  C.int
        _C_uint C.uint
)

$ go tool cgo -godefs types.go
// Created by cgo -godefs - DO NOT EDIT
// cgo -godefs types.go

package pty

type (
        _C_int  int32
        _C_uint uint32
)

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

--- Comment #1 from Matthias Klose <doko at gcc dot gnu.org> ---
patch by Michael Hudson posted at https://launchpad.net/bugs/1361946

--- a/libgo/go/cmd/cgo/main.go
+++ b/libgo/go/cmd/cgo/main.go
@@ -133,6 +133,7 @@
        "386":   4,
        "amd64": 8,
        "arm":   4,
+       "arm64": 8,
        "ppc64": 8,
        "ppc64le": 8,
        "s390x": 8,
@@ -142,6 +143,7 @@
        "386":   4,
        "amd64": 8,
        "arm":   4,
+       "arm64": 8,
        "ppc64": 8,
        "ppc64le": 8,
        "s390x": 8,

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Matthias Klose from comment #1)
> patch by Michael Hudson posted at https://launchpad.net/bugs/1361946
> 
> --- a/libgo/go/cmd/cgo/main.go
> +++ b/libgo/go/cmd/cgo/main.go
> @@ -133,6 +133,7 @@
>         "386":   4,
>         "amd64": 8,
>         "arm":   4,
> +       "arm64": 8,
>         "ppc64": 8,
>         "ppc64le": 8,
>         "s390x": 8,
> @@ -142,6 +143,7 @@
>         "386":   4,
>         "amd64": 8,
>         "arm":   4,
> +       "arm64": 8,
>         "ppc64": 8,
>         "ppc64le": 8,
>         "s390x": 8,

Except hat is broken for ilp32.

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[michael.hudson at canonical dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

Michael Hudson-Doyle <michael.hudson at canonical dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |michael.hudson at canonical dot co
                   |                            |m

--- Comment #3 from Michael Hudson-Doyle <michael.hudson at canonical dot com> ---
ilp32 will need to be a new GOARCH; "arm64p32" would fit with the existing
GOARCH value of amd64p32 for intel.

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
                 CC|                            |jakub at gcc dot gnu.org

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[ian at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

--- Comment #4 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Tue Mar 10 00:14:58 2015
New Revision: 221293

URL: https://gcc.gnu.org/viewcvs?rev=221293&root=gcc&view=rev
Log:
    PR go/65353.
cmd/cgo: Add all gccgo GOARCH values to size maps.

Modified:
    trunk/libgo/go/cmd/cgo/main.go

[Bug go/65353] [5 Regression] unknown ptrSize for $GOARCH "arm64" on aarch64-linux-gnu

[ian at airs dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65353

Ian Lance Taylor <ian at airs dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Ian Lance Taylor <ian at airs dot com> ---
Should be fixed.

Thanks for reporting it.