From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48205 invoked by alias); 18 Mar 2015 02:32:18 -0000 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org Received: (qmail 48147 invoked by uid 48); 18 Mar 2015 02:32:14 -0000 From: "hubicka at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug lto/65380] [5 Regression][ICF] LTO: ICE in add_symbol_to_partition_1, at lto/lto-partition.c:158 Date: Wed, 18 Mar 2015 02:32:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: lto X-Bugzilla-Version: 5.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: hubicka at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: hubicka at gcc dot gnu.org X-Bugzilla-Target-Milestone: 5.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2015-03/txt/msg01754.txt.bz2 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65380 --- Comment #10 from Jan Hubicka --- Actually perhaps we manage to produce external alias of non-external symbol that also should not happen. Index: ipa-icf.c =================================================================== --- ipa-icf.c (revision 221461) +++ ipa-icf.c (working copy) @@ -809,6 +809,15 @@ sem_function::merge (sem_item *alias_ite bool original_address_matters = original->address_matters_p (); bool alias_address_matters = alias->address_matters_p (); + if (DECL_EXTERNAL (alias->decl)) + { + if (dump_file) + fprintf (dump_file, + "Not unifying; " + "alias is external.\n\n"); + return false; + } + if (DECL_NO_INLINE_WARNING_P (original->decl) != DECL_NO_INLINE_WARNING_P (alias->decl)) { @@ -1767,6 +1870,14 @@ sem_variable::merge (sem_item *alias_ite "Symbol aliases are not supported by target\n\n"); return false; } + if (DECL_EXTERNAL (alias->decl)) + { + if (dump_file) + fprintf (dump_file, + "Not unifying; " + "alias is external.\n\n"); + return false; + } sem_variable *alias_var = static_cast (alias_item); May help.