public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/65380] [5 Regression][ICF] LTO: ICE in add_symbol_to_partition_1, at lto/lto-partition.c:158
Date: Wed, 18 Mar 2015 02:13:00 -0000	[thread overview]
Message-ID: <bug-65380-4-oUcIV1IUP4@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-65380-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65380

--- Comment #8 from Jan Hubicka <hubicka at gcc dot gnu.org> ---
I am with terrible internet connection and it still does not reproduce for me
(I suppose difference between GNU LD and gold).
It is however clear what happens, we try to add symbol's alias that is external
and we do not expect external symbols to be in partitions.

Does the following (untested) help?
Index: lto-partition.c
===================================================================
--- lto-partition.c     (revision 221399)
+++ lto-partition.c     (working copy)
@@ -198,7 +198,7 @@
   /* Add all aliases associated with the symbol.  */

   FOR_EACH_ALIAS (node, ref)
-    if (!node->weakref)
+    if (!node->weakref && !DECL_ExTERNAL (node->decl))
       add_symbol_to_partition_1 (part, ref->referring);

   /* Ensure that SAME_COMDAT_GROUP lists all allways added in a group.  */


  parent reply	other threads:[~2015-03-18  2:13 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 16:43 [Bug lto/65380] New: [5 Regression] " burnus at gcc dot gnu.org
2015-03-10 16:43 ` [Bug lto/65380] " burnus at gcc dot gnu.org
2015-03-10 19:55 ` hubicka at gcc dot gnu.org
2015-03-11  9:36 ` rguenth at gcc dot gnu.org
2015-03-11 10:29 ` burnus at gcc dot gnu.org
2015-03-16  0:36 ` hubicka at gcc dot gnu.org
2015-03-16  7:52 ` burnus at gcc dot gnu.org
2015-03-16  7:59 ` [Bug lto/65380] [5 Regression][ICF] " burnus at gcc dot gnu.org
2015-03-17  0:51 ` hubicka at ucw dot cz
2015-03-18  2:13 ` hubicka at gcc dot gnu.org [this message]
2015-03-18  2:14 ` hubicka at gcc dot gnu.org
2015-03-18  2:32 ` hubicka at gcc dot gnu.org
2015-03-18  8:22 ` burnus at gcc dot gnu.org
2015-03-18 13:19 ` marxin at gcc dot gnu.org
2015-03-18 18:28 ` hubicka at gcc dot gnu.org
2015-03-19 18:56 ` marxin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65380-4-oUcIV1IUP4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).