[Bug fortran/65429] ICE on implied-length character empty array constructor

[Bug fortran/65429] ICE on implied-length character empty array constructor

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-03-15
     Ever confirmed|0                           |1

[Bug fortran/65429] ICE on implied-length character empty array constructor

[drikosev at otenet dot gr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

drikosev at otenet dot gr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drikosev at otenet dot gr

--- Comment #1 from drikosev at otenet dot gr ---
Created attachment 35169
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35169&action=edit
zero-sized implicit array constructor (character type)

Hi,

This patch have been applied to 4.8.4; having applied some patches from CentOS
and MacPorts, it is almost the 10th patch I apply to 4.8.4. 

So, one might have to apply this patch manually to 4.9 or newer.

Regards,
Ev. Drikos

[Bug fortran/65429] ICE on implied-length character empty array constructor

[dominiq at lps dot ens.fr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

--- Comment #2 from Dominique d'Humieres <dominiq at lps dot ens.fr> ---
I wonder if the patches in comment 1 or at
https://gcc.gnu.org/ml/fortran/2015-03/msg00143.html are not papering over the
real issue. I have modified the FX' test as

  CHARACTER(*, kind = 4), PARAMETER :: animals(*)  = [ CHARACTER(10) :: ]
  print *, kind(animals), len(animals), size(animals), "'", animals, "'"
  end

With the patch in the fortran mailing list I get

           4           0           0 ''

i.e., the kind is properly recorded, but not the length, while I am expecting
that animals be an array of size zero of character(10) of kind == 4. I had a
look at the standard, but did not find anything relevant for this case.

[Bug fortran/65429] ICE on implied-length character empty array constructor

[drikosev at otenet dot gr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

--- Comment #3 from drikosev at otenet dot gr ---
With the patch one can avoid a segmentation fault but I don't know very well
the internals of gfortran.

So, I've no idea if and how one can obtain the length without array elements;
some debugging didn't help at all.

[Bug fortran/65429] ICE on implied-length character empty array constructor

[drikosev at otenet dot gr]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

--- Comment #4 from drikosev at otenet dot gr ---
So, the proper solution is described at:

https://gcc.gnu.org/ml/fortran/2015-03/msg00163.html

[Bug fortran/65429] ICE on implied-length character empty array constructor

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

--- Comment #5 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Wed Apr 22 22:43:46 2015
New Revision: 222342

URL: https://gcc.gnu.org/viewcvs?rev=222342&root=gcc&view=rev
Log:
2015-04-22  Steven G. Kargl  <kargl@gcc.gnu.org>

    PR fortran/65429
    * decl.c (add_init_expr_to_sym): Set the length type parameter.

    PR fortran/65429
    * gfortran.dg/pr65429.f90: New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/pr65429.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/65429] ICE on implied-length character empty array constructor

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

--- Comment #6 from kargl at gcc dot gnu.org ---
Author: kargl
Date: Wed Apr 22 23:12:30 2015
New Revision: 222343

URL: https://gcc.gnu.org/viewcvs?rev=222343&root=gcc&view=rev
Log:
2015-04-22  Steven G. Kargl  <kargl@gcc.gnu.org>

    PR fortran/65429
    * decl.c (add_init_expr_to_sym): Set the length type parameter.

    PR fortran/65429
    * gfortran.dg/pr65429.f90: New test.


Added:
    branches/gcc-5-branch/gcc/testsuite/gfortran.dg/pr65429.f90
Modified:
    branches/gcc-5-branch/gcc/fortran/ChangeLog
    branches/gcc-5-branch/gcc/fortran/decl.c
    branches/gcc-5-branch/gcc/testsuite/ChangeLog

[Bug fortran/65429] ICE on implied-length character empty array constructor

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65429

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |kargl at gcc dot gnu.org
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.2

--- Comment #7 from kargl at gcc dot gnu.org ---
Fixed on trunk and 5.1 branch.  Closing.