[Bug ipa/65432] [5 Regression] Invalid read of size 1: ipa_icf::sem_item_optimizer::merge_classes(unsigned int) (ipa-icf.c:2958)

["marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65432

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Markus Trippelsdorf from comment #4)
> (In reply to Martin Liška from comment #3)
> > Created attachment 35057 [details]
> > Suggested patch
> > 
> > I guess the problem is caused by missing xstdup_for_dump wrappers.
> > Can you please Markus test for me the patch?
> 
> The patch fixes the issue. Thanks.

Thanks. I'm going to send the patch to mailing list.
>From gcc-bugs-return-480685-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Wed Mar 18 13:26:32 2015
Return-Path: <gcc-bugs-return-480685-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 36688 invoked by alias); 18 Mar 2015 13:26:32 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 36617 invoked by uid 48); 18 Mar 2015 13:26:28 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug lto/65243] [5 Regression] lto1 ICE (segfault) on powerpc64le-linux-gnu
Date: Wed, 18 Mar 2015 13:26:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: lto
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: WAITING
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 5.0
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields: bug_status cf_reconfirmed_on everconfirmed
Message-ID: <bug-65243-4-J07m2YV2QR@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-65243-4@http.gcc.gnu.org/bugzilla/>
References: <bug-65243-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2015-03/txt/msg01829.txt.bz2
Content-length: 1065

https://gcc.gnu.org/bugzilla/show_bug.cgi?ide243

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|2015-03-02 00:00:00         |2015-03-18
     Ever confirmed|0                           |1

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
The original ICE means that in

inline hashval_t
external_ref_hasher::hash (const value_type *r)
{
  dw_die_ref die = r->type;
  hashval_t h = 0;

  /* We can't use the address of the DIE for hashing, because
     that will make the order of the stub DIEs non-deterministic.  */
  if (! die->comdat_type_p)
    /* We have a symbol; use it to compute a hash.  */
    h = htab_hash_string (die->die_id.die_symbol);

die->die_id.die_symbol is NULL (I suppose).

I suppose the guard means that in non-LTO this _is_ a comdat type.  But
LTO somehow demoted it?

We still lack a proper testcase.