public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vries at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/65442] New: pass_lim misses support for exit-first loops
Date: Mon, 16 Mar 2015 14:58:00 -0000	[thread overview]
Message-ID: <bug-65442-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65442

            Bug ID: 65442
           Summary: pass_lim misses support for exit-first loops
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vries at gcc dot gnu.org

Consider test.c:
...
#include <string.h>

const char *something (void);

size_t
f (unsigned int n)
{
  const char *s = something ();
  size_t sum = 0;
  size_t t;
  unsigned int i;

  if (!s)
    return 0;

  for (i = 0; i < n; ++i)
    {
      t = strlen (s);
      sum += t;
    }

  return sum;
}
...

The resulting code with -O2 -fno-tree-ch from the optimized dump is: 
...
f (unsigned int n)
{
  unsigned int i;
  size_t t;
  size_t sum;
  const char * s;
  size_t _3;

  <bb 2>:
  s_6 = something ();
  if (s_6 == 0B)
    goto <bb 6>;
  else
    goto <bb 3>;

  <bb 3>:
  # sum_14 = PHI <0(2)>
  # i_12 = PHI <0(2)>
  goto <bb 5>;

  <bb 4>:
  t_9 = strlen (s_6);
  sum_10 = sum_1 + t_9;
  i_11 = i_2 + 1;

  <bb 5>:
  # sum_1 = PHI <sum_14(3), sum_10(4)>
  # i_2 = PHI <i_12(3), i_11(4)>
  if (i_2 != n_8(D))
    goto <bb 4>;
  else
    goto <bb 6>;

  <bb 6>:
  # _3 = PHI <0(2), sum_1(5)>
  return _3;

}
...

The strlen is not taken out of the loop. It could be taken out of the loop,
provided it's guarded with the loop condition.

This PR is similar to PR65440. There the strlen is conditional in the loop
body, which is entered unconditionally. Here the strlen is unconditional in the
loop body, which is entered conditionally.


             reply	other threads:[~2015-03-16 14:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 14:58 vries at gcc dot gnu.org [this message]
2015-03-18 11:36 ` [Bug tree-optimization/65442] " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-65442-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).