public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/65460] New: parloops transforms offloaded functions
@ 2015-03-18  8:55 vries at gcc dot gnu.org
  2015-03-18  8:56 ` [Bug tree-optimization/65460] " vries at gcc dot gnu.org
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-03-18  8:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

            Bug ID: 65460
           Summary: parloops transforms offloaded functions
           Product: gcc
           Version: 5.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vries at gcc dot gnu.org

The offload variant of PR65458 - parloops transforms omp-thread functions.

AFAIU, running the parloops pass on the host version of offloaded functions,
may as well speed up as degrade performance. 

It's probably best to disable parloops for offloaded functions, at least until
we do a targeted exercise to speed up host execution of offloaded functions.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
@ 2015-03-18  8:56 ` vries at gcc dot gnu.org
  2015-03-18 11:27 ` rguenth at gcc dot gnu.org
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-03-18  8:56 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

--- Comment #1 from vries at gcc dot gnu.org ---
Created attachment 35052
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=35052&action=edit
tentative patch


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
  2015-03-18  8:56 ` [Bug tree-optimization/65460] " vries at gcc dot gnu.org
@ 2015-03-18 11:27 ` rguenth at gcc dot gnu.org
  2015-03-22  9:53 ` vries at gcc dot gnu.org
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2015-03-18 11:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2015-03-18
     Ever confirmed|0                           |1

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
  2015-03-18  8:56 ` [Bug tree-optimization/65460] " vries at gcc dot gnu.org
  2015-03-18 11:27 ` rguenth at gcc dot gnu.org
@ 2015-03-22  9:53 ` vries at gcc dot gnu.org
  2015-04-17 10:15 ` vries at gcc dot gnu.org
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-03-22  9:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

--- Comment #3 from vries at gcc dot gnu.org ---
Author: vries
Date: Sat Mar 21 22:22:52 2015
New Revision: 221562

URL: https://gcc.gnu.org/viewcvs?rev=221562&root=gcc&view=rev
Log:
Mark offloaded functions as parallelized

2015-03-21  Tom de Vries  <tom@codesourcery.com>

    PR tree-optimization/65460
    * omp-low.c (expand_omp_target): Set parallelized_function on
    cgraph_node for child_fn.

Modified:
    branches/gomp-4_0-branch/gcc/ChangeLog
    branches/gomp-4_0-branch/gcc/omp-low.c


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2015-03-22  9:53 ` vries at gcc dot gnu.org
@ 2015-04-17 10:15 ` vries at gcc dot gnu.org
  2015-06-08 12:27 ` vries at gcc dot gnu.org
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-04-17 10:15 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

--- Comment #4 from vries at gcc dot gnu.org ---
stage1 ping: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00861.html


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2015-04-17 10:15 ` vries at gcc dot gnu.org
@ 2015-06-08 12:27 ` vries at gcc dot gnu.org
  2015-06-08 12:34 ` vries at gcc dot gnu.org
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-06-08 12:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #5 from vries at gcc dot gnu.org ---
patch: https://gcc.gnu.org/ml/gcc-patches/2015-03/msg01063.html


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2015-06-08 12:27 ` vries at gcc dot gnu.org
@ 2015-06-08 12:34 ` vries at gcc dot gnu.org
  2015-06-09 21:15 ` vries at gcc dot gnu.org
  2015-06-09 21:17 ` vries at gcc dot gnu.org
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-06-08 12:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

--- Comment #6 from vries at gcc dot gnu.org ---
stage1 ping^2: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00557.html


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2015-06-08 12:34 ` vries at gcc dot gnu.org
@ 2015-06-09 21:15 ` vries at gcc dot gnu.org
  2015-06-09 21:17 ` vries at gcc dot gnu.org
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-06-09 21:15 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

--- Comment #7 from vries at gcc dot gnu.org ---
Author: vries
Date: Tue Jun  9 21:14:46 2015
New Revision: 224303

URL: https://gcc.gnu.org/viewcvs?rev=224303&root=gcc&view=rev
Log:
Mark offloaded functions as parallelized

2015-06-09  Tom de Vries  <tom@codesourcery.com>

        PR tree-optimization/65460
        * omp-low.c (expand_omp_target): Set parallelized_function on
        cgraph_node for child_fn.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/omp-low.c


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [Bug tree-optimization/65460] parloops transforms offloaded functions
  2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2015-06-09 21:15 ` vries at gcc dot gnu.org
@ 2015-06-09 21:17 ` vries at gcc dot gnu.org
  7 siblings, 0 replies; 9+ messages in thread
From: vries at gcc dot gnu.org @ 2015-06-09 21:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65460

vries at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #8 from vries at gcc dot gnu.org ---
patch committed to trunk, marking resolved fixed.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-06-09 21:17 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-18  8:55 [Bug tree-optimization/65460] New: parloops transforms offloaded functions vries at gcc dot gnu.org
2015-03-18  8:56 ` [Bug tree-optimization/65460] " vries at gcc dot gnu.org
2015-03-18 11:27 ` rguenth at gcc dot gnu.org
2015-03-22  9:53 ` vries at gcc dot gnu.org
2015-04-17 10:15 ` vries at gcc dot gnu.org
2015-06-08 12:27 ` vries at gcc dot gnu.org
2015-06-08 12:34 ` vries at gcc dot gnu.org
2015-06-09 21:15 ` vries at gcc dot gnu.org
2015-06-09 21:17 ` vries at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).